Minutes:

-Mike emailed the UCOSP steering committee and they have given the mentors an evaluation rubric.
-Midterm evaluations are due this Wednesday. If you think you can’t complete your project this semester then it’s a good time to talk to the mentors.
-Anthony has no roadblocks this week, and is working on addressing a code review.
-Christian has a tip about Django database development. Django has ways to minimize database queries and can group them in other queries. He recommends reading the docs on select_related() and other database docs.
-Review board 1.7 will require Django 1.4. This adds prefetch_related functionality.
-Curtis has had a busy week, no updates aside from his status report.
-Willer is having database issues which will be resolved in non-meeting time.
-Dave has no concerns that weren’t stated in his status report.
-Yazan has no roadblocks, but needs a new project. The “expand all” button is sometimes annoying when you only want to expand a bit. Christian has some half-finished code for that which Yazan can finish up.
-Wilson is having trouble finding out where to place his changes, this is brought up in his review. He’s also having problems with a checkbox being “checked” when it should really render as “unchecked”. His project is almost done – he will need a new project soon.
-For client-side debugging, use Chrome dev tools for Chrome or firebug for Firefox.
-Steve continues the discussion on how Review Bot will get code. The initial idea might be to query RB for the files. Christian points out that what’s needed is the repository configuration (including SSH keys) which can be done by looking directly at RB’s database. Then create an abstraction layer over SCM tools, starting with checkout update on git.
-Steve is also concerned because his webhooks extension has started relying on his extension modifications. These modifications should be reviewed asap!
-Jim will be working throughout reading week, and will try to post a review request soon. Jim also found a bug, which he will be fixing.
-Steve asked Christian about his WIP T-shirt designs again, which would be awesome!

Status:

- Submitted Issue Tracking integration for code review

- Addressed very minor issue with SettingsForm-generated admin pages.

Next Steps:

- Address code reviews for Issue Tracking integration

- Look into adding options for SettingsForm to the extension generation script

Roadblocks:

- None

Curtis

Status:

- Added a Template Hooks section to the Building Extensions documentation.

- Made a couple revisions to Interdiffs.

- Started work on a prototype version of the reviewboard-social extension.

Next Steps:

- Continue working on the social extension.

Roadblocks:

- Currently switching over to a new mac, found out linux wont install on a MacBook Pro 8,2. Installing in a VM today.

- Yay new mac!

Dave

Status:

- Moved files works but doesn’t save chunks yet

- rbtools updated to pass -M flag

- Reading week! Will get lots of stuff done this week.

Next Steps:

- Get moved files to save chunks

- Detect moves on other version control systems in rb and rbtools

Roadblocks:

- Midterm week, not much free time but will make up for it this week.

Jim

Status:

- Made some progress with changed Description/Testing, have some basic functionality down

- Still stuck on the comment object not correctly sync’ed bug..will keep investigating

Next Steps:

- Working on building a prototype for the diff of changed Description/Testing section, should be able to come up with screenshots by end of weekend

Roadblocks:

- Busy week with interviews/midterms/assignments, will work more next week(reading week) to catch things up

Steven

Status:

- Made a small change to djblets (committed to master http://reviews.reviewboard.org/r/2886/)

- Added admin sites for extensions in djblets ( http://reviews.reviewboard.org/r/2888/ )

- Updated Web Hooks extension ( http://reviews.reviewboard.org/r/2855/ )

- Worked on ReviewBot.

Next Steps:

- Add the ability for extensions to have default settings.

- Fix issues with extension admin sites.

- Update Web Hooks to use new extension capabilities.

Roadblocks:

- Need more information on how extension admin sites should act / input on a bug

- Has anyone figured out how I should implement review bots access to the code (continuation from last week)

- Web Hooks depends on my extension changes

Wei Lu

Status:

- Could not make any progress in testing code due to django evolution

Next Steps:

- Get over the roadblock with assistance

Roadblocks:

- Stuck with django evolution for >10 hours; tried everything but it just didn’t work for me

Wilson

Status:

- made progress in understanding javascript, playing with code

Next Steps:

- look for new project

- making the comment box reflect changes made in the database

Roadblocks:

- figuring out relation between different coding languages

Yazan

Status:

- Required fields almost done

- Working on improved summary table

Next Steps:

- Submit improved summary table

- Pick up a new task

Roadblocks:

- Concern: Possible code conflict with r2859

From my experiences on the team I can safely say it gives new developers a leg up on the learning curve when starting. I was able to leverage Review Board to quickly learn exactly what  I should, and should not be doing in my code. Through each new code review I was determined not to repeat the same mistakes that were made in my previous review. The intuitive review interface clearly communicates these mistakes back to the developer, allowing them to make the changes and learn from their mistakes.

Review Board also acts as an effective communication platform for any distributed team utilizing it, as it allows the entire team to see the progress of each component, and add their own input to how the end solution should look. This is very important, as communication is one of the toughest aspects when working with a team not based in one site.

I started off in the Code Sprint by getting my feet wet with a couple bugs and a small project. Due to the fact that I haven’t used Django recently, and that the Review Board code base itself is quite large and complex this meant I was in for quite a steep learning curve. I have now moved on to my second project, which itself comes in two parts. The code based part of the project is a rating extension which will allow users to leave anonymous feedback on the quality of the code reviews they receive, while also tracking their own aggregated results over a period of time. These results will allow users to reflect on their code reviewing habits, and make improvements if necessary. This project will be leveraging brand new scripts to simplify the extension building process, by tempting out the base code required for an extension to exist in a Review Board instance.

The second half of this project will involve writing documentation to guide others using these scripts on how to take their extension stub and turn it into a functional and integrated part of their Review Board environment. A lot of developers get the idea that by adding this “one feature” to the project, it will vastly improve their experience using Review Board. This has many problems however, because if every one of these features are added they will start to bloat the code base, making Review Board run slower and harder to maintain. This also requires developer hours, which could be spent working on other features which would benefit more than just a handful of developers. Adding this “one feature” also runs the risk of alienating other developers with features or functionality they don’t need, want, or understand. The great thing about extensions is that they allow these developers requesting the feature to easily create and add the feature to their own instance of Review Board, without impacting everyone else’s experience.

It’s great to be able to work on such a far reaching project like Review Board, and know my improvements are being used all across the world. The project could not be nearly as successful without the big effort put in by each of the mentors. Their ability to offer prompt code reviews, technical guidance, and project ideas really makes working on Review Board a lot of fun. Due to their efforts, more time is spent in the learning or “eureka” phases of development than stuck in a frustrating roadblock.

- Mike announced that mentors will determine part of our grades base on: 1) being pesent, 2) communication, 3) how well you take the code review criticism & 4) your projects. Nothing have we heard from the universities about the evaluation.

- Yazan was suggested to make the required field flag a star with “(required)” at the end and set required=”required”. On the summary table, Yazan would make a filter instead of collapsing (a little dropdown or toggles above it for showing opened issues or all; default to opened issues).

- Wilson has recovered and is doing well with his current review request. He will pick up another project soon.

- Steven learned from Mike and Christian that the WebHooks being blocked automatically is fine for now and that the POST request it sends should use JSON. Steven proposed to make some tools that can retrieve from the code base. Christian had three alternatives: pointing to the review board database, having an own clone of database or making some channel. They would talk about another issue, djblets extensions admin, afterwards.

- Jim learned some routines to involve djblets 0.6.x and see remote branches from Mike and David. He would need his master updated in this case.

- Dave had an OSError in his VM when he had to restart the dev server after file changes. Mike suggested him to try a fresh clone, and they would resolve the error later.

- Curtis wanted to look at similar some code on template hooks. Mike would show him how to use the review-summary-header-post hook after the meeting.

- Anthony had email issues. he would start looking at some unit tests (e.g. notifications/tests.py) Christian and Mike mentioned.

- Wei asked how to manually test his project. Mike suggested to set up a repository for the local reviewboard install, connect it to the actual Review Board Github repository, generate diffs against the current Review Board source, and post them to the local instance.

REMINDER —- Feb 28: status reports, Wilson; minutes, David.

Status

• Picked up a new project (Issue Tracker Integration)
• Got the web-UI aspects working

Next Steps

• Do more testing and post a code review

Roadblocks

• I am not sure what the best way is to test the e-mail notifications fetaure.

Curtis

Status

• Implemented Christian’s and Mike’s changes, moved logic to the view. Could use a quick review (ship its hopefully).http://reviews.reviewboard.org/r/2810/
• Used Antony’s script to generate my extension stub. Started working on the social extension backend, very basic functionality for the controller>model>view>dashboard_template working.

Next Steps

• Continue working on the social extension, next week we want to have a functional prototype working.

Roadblocks

• Could use a quick tutorial on template hooks. ie. How can my extension use a template hook in a Review Board template to add something to the page?

Dave

Status

• Almost done better moved/renamed files project

Next Steps

• Finish project, get more info about binary files project

Roadblocks

• Strange Linux problems

Jim

Status

• still working on diff rendering with descriptions and tests.
• also investigating the bug that I discovered (comment gets out of sync between interdiff and summary)

Next Steps

• continue what I am doing

Roadblocks

• none for now

Steven

Status

• Put basic web hooks extension up for review
• Prototyped webhooks and reviewbot
• Working on improving webhooks and getting reviewbot ready for review

Next Steps

• Add support for repo cloning to SCM tools
• Continue with reviewbot

Roadblocks

• Would like some feedback on webhooks before I continue with current path

Wei Lu

Status

• found and solved the problems in the code reused from r/2615
• made further changes according to the comments in the thread

Next Steps

• test it properly and debug, then post a review request to replace r/2615

Roadblocks

• not sure how to test it on the local dev server properly

Wilson

Status

• Made progress on project, near completion
• More reading

Next Steps

• Finish up and submit for review
• Read more

Roadblocks

• None

Yazan

Status

• Working on required fields, almost done
• Did some work on moving/enhancing summary table

Next Steps

• Submit work for review

Roadblocks

• None

preview-email/html/

• Anthony is waiting for a ship-it on his last review and is looking for a new project next week.
• Steve is looking for inputs in his project on which tool to use for the web request handling code. Candidates are Twisted, Node.js and Tornado. As recommended by Christian, Steve is going to try out Tornado. His code is going to be here.
• Jim is waiting for a ship-it in his last review. He found another bug that’s related to the component he is currently working on and he will open a bug for it.
• Yazan is doing fine and has plenty of work for the week. He also upload the photos for the code sprint here. Later, Yazan asks Christian for his input in this issue. Christian feel that it is not the top priority right now.
• Dave is going to take over Christian’s change for attachment review(binary diff). Dave also had a question about diff data for moved files and Christian answers it. The thing that was mentioned is moved files are hard to track with only diffs.
• Curtis is waiting for a ship-it for his review and needs feedback on interface designs for reviewboard-social link
• Wilson has a question regarding diff being unavailable but it seems to be nothing major. He also has another quick question later regarding cleaning up ”evolution” history and Christian answers it.
• Wei has a question regarding the “evolution” folder when he is exploring the code and Mike answers it. So “evolution” files are Python scripts that update database schema in Django. Wei also has a simple question regarding WebAPI and Christian answers it.
• Mike will be added to the mod list for reviewboard-dev

The next meeting is on February 11th, 2012. David will be collecting status reports and Wei will be taking meeting minutes.

February 11th – status reports: David, minutes: Wei Lu

Status

• Fleshed out basic options for the other hooks (ReviewRequestActionHook,
  DiffViewerActionHook, working on ReviewRequestDropdownActionHook)

Next steps

• I’m going to look into picking up another project

Roadblocks

• Not sure if I should add this to the code review I already have out, so
  I’m waiting for some movement there

Steven

Status

• Working on simple WebHooks extension

Next steps

• ReviewBot

Roadblocks

• None

Jim

Status

• Trying to fix a bug that’s preventing me from checking-in previous
  project
• Reading the diff utility code and see if I can re-use it and come up
  with a prototype for description change renderin

Next steps

• Keep on what I am currently doing

Roadblocks

• None

Yazan

Status

• Working on moving summary table/adding buttons
• Adding required fields to review request

Next steps

• Submitting features for review

Roadblocks

• None

Dave

Status

• Better familiarized myself with code base of project scope (better moved
  files in diff viewer)
• Planned and started coding project

Next steps

• Continue working on project

Roadblocks

• None

Curtis

Status

• Initial mock ups of how the reviewboard-social extension interfaces will look are up for review: http://reviews.reviewboard.org/r/2843/
• Interdiffs is ready for review: http://reviews.reviewboard.org/r/2810/
• Learning about extensions & reviewboard, as well as Anthony’s extension script

Next steps

• Start the back end work required for the reviewboard-social extension, while the designs for the interfaces are reviewed and modified

Roadblocks

• None

Wilson

Status

• Sick, green phlegm everywhere

Next steps

• Get better

Roadblocks

• Nasal congestion

- Sorry I haven’t done much this week, not feeling well at all

Wei

Status

• Made changes to r/2818 according to the comments and retested; got it pushed to master; closed r/2818
• Starting project “Tracking User Changes” by reproducing the behavior on local test server
• Downloaded and applied the starting code for project “Tracking User Changes” from previous review post r/2615
• Researched the source code and diff for the project; learned django template syntax btw

Next steps

• Started coding for the project
• Hopefully posted a review request when early changes are done

Roadblocks

• The project has been related to 8 files and 15 changes already; only intuitively understood the relationship between them so far; wish to get some extra help separately on their relationship

- Setup the development environment

- Understood some basic project ideas

- Fixed a bug in rb-site and post the review request

Next step:

- Follow up with the comments on my review request of rb-site

- Learn Django template language in order to touch the main projects

- Pick “Tracking User Changes” as my first project, starting by exam how “Tracking User Changes” is done

Feelings:

- I was really happy to see everyone during the sprint; everyone is very friendly; good luck and have fun for everyone!

- The open source development environment feels very efficient and comfortable

Note:

- I put too much effort on rb-site, did not get aware of the other main projects; now I am starting my own project, so it is time to write this sprint report

Cheers,

Wei Lu Liu

• Jim needed better clarification on his project. The discussion will be taken offline to cover it in detail.
• Dave’s only blocking issue was resolved by Christian.
• Steve has a question about his extension design, if it (PEP8 extension) should extend the base extension or talk to it. Further discussion will be taken offline.
• Anthony needs to make a new review request for his code review, as it is in a different repository. His extension scaffolding script will need continued polish after some feedback from developers (Curtis and Steve) have used it.
• Yazan will start by adding required flags on fields which are required before a review is submitted. He will also be looking into uplifting the issue table, and writing some failing tests for dashboard counters. Yazan also has all the pictures from the code sprint.
• Curtis is investigating custom template tags and is looking for a more elegant solution to determining the enumeration of a diff. He will have some mockups for the reviewboard-social extension ready for next week.
• Wilson will post his progress up on Review Board, after he receives a quick walk through on the post-review process. He will also be learning more HTML and Django.
• Wei can update his code review and check off issues once they are fixed. He will be taking on Jacob’s project from laster semester, Tracking User Changes.
• Development issues can be posted to the review-dev mailing list instead of the UCOSP list. As always, you can post in #reviewboard-students if you need any help.

The next meeting is on February 4th, 2012. Wei will be collecting status reports and Jim will be taking meeting minutes.

February 4th – status reports: Wei Lu, minutes: Jim

Status

• Completed Expose Toggles for Opening Issues in Review Summary Dialog, pending for submission.
• Started reading on the Diff application and trying to figure out how to do diff’s on description/testing done sections

Next steps

• keep reading on the code base for diff application
• communicate with Christian and David about how better change description rendering should be done

Roadblocks

• None

Dave

Status

• Per-user timezone changes were reviewed and pushed
• Chose next project, “Better Moved/Renamed Files”

Next steps

• Plan next project

Roadblocks

• Can’t continue with “Inline File Attachments” project for the moment

Steven

Status

• No changes since sprint (Sick)

Next steps

• Continue on static analysis extension
• Catch up on hours

Roadblocks

• None

Anthony

Status

• finished first iteration of the extension scaffolding generator, and it is currently undergoing code review

Next steps

• Wait until the first commit for the generator gets committed
• Take another pass at the existing extensions and see what else can be automated

Roadblocks

• None

Yazan

Status

• Wrap up r2816

Next steps

• Get projects approved

Roadblocks

• None

Curtis

Status

• Fixed issue 1252 and 2271, and the changes were pulled into master.
• Currently working on the interdiffs project.

Next steps

• Start the first iteration of the reviewboard-social extension.

Roadblocks

• Having trouble identifying how I can pull the revision numbers out of the models in an intelligent way. The current solution I have is pretty “hacky” and I am not very satisfied with its implementation.

Wilson

Status

• Read through MDN’s Javascript guide part 1/3 (Introductory)
• Nothing too different from the sprint

Next steps

• Finish MDN’s Javascript guide
• go through w3school’s html guide

Roadblocks

• None

Wei

Status

• Finished posting review request r2818

Next steps

• Follow up with the comments on r2818
• Chose and start next bug for the project

Roadblocks

• Not able to use the student blog yet
• Got sick earlier this week, have to speed up next week