[Open Academy] Status Reports: Feb 28, 2015


Sun Wang Jun

1. What project are you working on?
Checklist extension.

2. What you accomplished this week:
Refactored and improved upon the old checklist extension UI and front end code.
Did a few very trivial code reviews.

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/2015-Checklist-Extension-oLIpxP1SzyX
Will be pushing my updates to https://reviews.reviewboard.org/r/6969

4. What you plan to do next week:
Continue working on checklist templates

5. What, if anything, is blocking you from making progress?
Midterm tests.

6. Any other questions?
Nope.



Chenxi Ni

1) What project are you working on?
Changing Review Request Ownership

2) What you accomplished this week.
finish bug #3505.
make the ownership changeable on the UI level
added attributes to database table

3) Links to anything you’ve done this week (hackpads, review requests, blog posts, etc)
My RR for bug 3505:

https://reviews.reviewboard.org/r/6856/

My WIP RR for my feature:

https://reviews.reviewboard.org/r/6990/

My hackpad:

https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP

4) What you plan to do next week.
Fix the bug I encounted and work on Add submitter information when the information in a ReviewRequestDraft is dumped into the ReviewRequest model

5) What, if anything, is blocking you from making progress?
The returned draft from server ‘PUT’ to browser has no ‘submitter’ field as talked on the slack. Looking forwards to more discuss on this bug.

6) Any other questions
Not yet.



Teresa Fan

1. What project are you working on?
Interactive Issue Summaries

2. What you accomplished this week:
Addressed feedback/review comments, started adding the buttons to the table.

3. Links to anything you’ve done this week:
My ongoing review request for part 2: https://reviews.reviewboard.org/r/6910/
Review request with mockups for part 3: https://reviews.reviewboard.org/r/6966/
WIP code for part 3: https://reviews.reviewboard.org/r/6997/
My school’s course for this program also had us give midterm presentations this week, so here’s mine: https://docs.google.com/presentation/d/1I4For9WYlWwIYWREm2yZ3B6gXnMRmj5sz7TClmSAhEE/edit?usp=sharing

4. What you plan to do next week:
Keep working on part 3 (getting the buttons to show up and work)

5. What, if anything, is blocking you from making progress?
Nothing.

6. Any other questions?
As I’m fixing issues brought up with my review requests, should I update the diffs? If so, how? (is it just commit the changes and rbt post again?)



Stanley Yeo

1. What project are you working on?
Improve Review Bot’s admin interface

2. What you accomplished this week:
Finished implementing widget and writing styles for the project.

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/6998/

https://reviews.reviewboard.org/r/6999/

https://reviewboard.hackpad.com/Stanleys-Note-y91i8NygfSk

4. What you plan to do next week:
update RRs based on feedbacks
fix bugs

5. What, if anything, is blocking you from making progress?
Nothing.

6. Any other questions?
Anselina and Steven, please take a look at the RRs I’ve uploaded and see if my approach is right one.



Mingyi Chen

1. What project are you working on?
Add infinite scrolling to the diff viewer

2. What you accomplished this week:
Finish writing part of the functions(hasMore and getMore).

3. Links to anything you’ve done this week:
hackpads: https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY

4. What you plan to do next week:
Accomplish the other functions..

5. What, if anything, is blocking you from making progress?
No, it’s time to work.

6. Any other questions?
No.



Rohan Meringenti

1. What project are you working on?
Highlight Active Issues

2. What you accomplished this week:
Coded up the backend function, still some bugs dealing with how it looks frontend
side to work out. After Midterms weeks, I’ll finish up this project.

3. Links to anything you’ve done this week:
Nothing this week. WIP patch coming in a few days.

4. What you plan to do next week:
Finish project by eliminating bugs and testing.
Code review 3 others.

5. What, if anything, is blocking you from making progress?
Just that its midterm week. After midterm, should finish last couple steps of project

6. Any other questions?
No.



Tran Nguyen

1. What project are you working on?
Working on adding pre-post hook to run some commands such as pyflakes or
flake8 before actually posting to the server.

2. What you accomplished this week:
Just debugging and familiar with the tool.
Finishing up some comments on uncommitted flag for Git.

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/6879/

4. What you plan to do next week:
Specs out what needs to be done for pre-post hoook.

5. What, if anything, is blocking you from making progress?
Nothing

6. Any other questions?
No.



Jessica Qian

1. What project are you working on?
trivial publishes

2. What you accomplished this week:
just some testing, not much, still finishing up midterms

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem

4. What you plan to do next week:
finish up trivial publishes for review requests

5. What, if anything, is blocking you from making progress?
midterms, almost done though.

6. Any other questions?
none



Wu Di

1. What project are you working on?
Better Diff Comment Bubbles

2. What you accomplished this week:
Addressed review comments.

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/6970

https://reviews.reviewboard.org/r/6932

4. What you plan to do next week:
Write tests for xss vulnerabilities for comments.
Continue working on resizing of the draft comments.

5. What, if anything, is blocking you from making progress?
Midterm test.

6. Any other questions?
I’m not familiar with xss vulnerabilities testing, is it a frontend or backend test? Do I just need to check whether script tags are escaped in comments?



Xuanyi Lin

1. What project are you working on?
Framework and UI for integrating with third party services

2. What you accomplished this week:
Webapi resource for integrations.

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/Xuanyis-notes-R9JtPE1o279

4. What you plan to do next week:
Continue to work on the webapi resource follow by backbone for the admin page.

5. What, if anything, is blocking you from making progress?
Midterm week.

RR on part 1 of my project if possible.

https://reviews.reviewboard.org/r/6918/

6. Any other questions?
Nope.

The relationship between ReviewRequest and ReviewRequestDraft

Despite having worked on various parts of Review Board for several years, the distinction between a ReviewRequest and ReviewRequestDraft has often been a bit blurry for me. I’ve had the occasion recently to explore the relationship between these two models, and I wanted to write it down for future code-spelunkers.

The way I want to explain this is by exploring the lifetime of a ReviewRequest, from cradle to grave. So, let’s get started.

When a ReviewRequest is first created, it has barely information in any of its fields, and the public attribute is set to false. When the user starts making modifications to a Review Request though, a Review Request Draft is then created. The changes that the user makes after creating the initial Review Request actually update the Review Request Draft instead. Even if the Description and Testing Done fields have been populated, that information is not in the ReviewRequest: all fields are set on the ReviewRequestDraft.

When the user clicks “Publish” on a review request page, the information in a ReviewRequestDraft is dumped into the ReviewRequest model. The ReviewRequestDraft model is deleted, and the state on the ReviewRequest is set to public. Congratulations, your review request is now visible!

Suppose now you want to make a change to a review request. Perhaps you’ve updated the Testing Done field, or you’re adding a new reviewer to it, or you’re changing the summary. What happens is that a new ReviewRequestDraft is created for the ReviewRequest, with a copy of all of the current fields in the ReviewRequest, and any changes you make go into that ReviewRequestDraft.

So when you, or anybody who has mutation-privledges for a ReviewRequest sees the review request page, and a ReviewRequestDraft exists, you see the information in the ReviewRequestDraft. For anybody without mutation-privledges looking at the page, they see the unchanged ReviewRequest data.

When it comes time to publish the draft, the changes in the ReviewRequestDraft get, again, dumped into the ReviewRequest (a ChangeDescription is also created in order to document the changes being made to the ReviewRequest) and the ReviewRequestDraft is destroyed.

When a ReviewRequest is marked submitted or discarded, that state change occurs on the ReviewRequest, and ReviewRequestDraft does not need to be created.

So that’s how changes occur on ReviewRequests.

[Open Academy] Status Reports Feb 16-22


Chenxi Ni

What project are you working on?

Changing Review Request Ownership

What you accomplished this week.

Add tests for my bug #3505.
WIP adding attributes to database table: learning about python property

Links to anything you’ve done this week (hackpads, review requests, blog posts, etc)

What you plan to do next week.

Finish my bug and add attributes to database table. Figure out how property works in python and change the code.

What, if anything, is blocking you from making progress?
Nothing now. I am learning Django and Python further for my project.

Any other questions
Not yet. Looking forwards to my replying on bug #3505



Teresa Fan

What project are you working on?

Interactive Issue Summaries

What you accomplished this week.

Made revisions to my part 2 code based on David’s comments. Thought of different options for the UI and made mockups for adding buttons to the expanded content.

Links to anything you’ve done this week (hackpads, review requests, blog posts, etc)

My ongoing review request (where I’ve been putting my updates/mockups) for part 2: https://reviews.reviewboard.org/r/6910/

Review request with mockups for part 3: https://reviews.reviewboard.org/r/6966/ 

What you plan to do next week.
Mull over possible other affordances. Implement part 3 (adding the buttons) based on feedback I get from the mockups.

What, if anything, is blocking you from making progress?
It’d be great if I got feedback on the mockups! I’m also open to other suggestions, so if you have one you want to see let me know.

Any other questions?
Nope.



Mingyi Chen

1. What project are you working on?
Add infinite scrolling to the diff viewer
2. What you accomplished this week:
Scrolling to the end of the page will automatically execute the function
3. Links to anything you’ve done this week:
4. What you plan to do next week:
Accomplish function hasMore().
5. What, if anything, is blocking you from making progress?
Not familiar with backbone.
6. Any other questions?

No.



Sihang Chen

1. What project are you working on?
Allow reviews and comments to be wrapped
2. What you accomplished this week?
I have my easyFix bug issue #3636 shipped.
3. Links to anything you’ve done this week?
4. What you plan to do next week?
Find out where to add codes to add a wrap button.
5. What, if anything, is blocking you from making progress?
In China, we are recently celebrating the Chinese New Year, and I have to spend more time together with my family.
6. Any other questions?

No yet.



Sun Wang Jun

1. What project are you working on?
Checklist extension.

2. What you accomplished this week:
Improved the UI of the checklist interface.

3. Links to anything you’ve done this week:
What I crossed out or added into https://reviewboard.hackpad.com/2015-Checklist-Extension-oLIpxP1SzyX
Work in progress review request: https://reviews.reviewboard.org/r/6969/

4. What you plan to do next week:
Finalize the minimum functionality for the checklist interface, then continue working on checklist templates.

5. What, if anything, is blocking you from making progress?
Nothing now!

6. Any other questions?
Will ask on Slack in any.



Wu Di
1. What project are you working on?
Better Diff Comment Bubbles

2. What you accomplished this week:
Published review request for the second part of the project, which is to display overlapping comment bubbles side by side.
Updated the first part of the project based on review comments.

3. Links to anything you’ve done this week:
Part 1: https://reviews.reviewboard.org/r/6932/
Part 2: https://reviews.reviewboard.org/r/6970/

4. What you plan to do next week:

Start on the third part of the project which is to resize and move draft comments to redefine the line range.

5. What, if anything, is blocking you from making progress?

Nothing.

6. Any other questions?

No.



Tran Nguyen

1) What project are you working on?
   – Uncommited flag for git and Mercurial

2) What you accomplished this week.
  – Addressed some comments on git version
– Starting exploring some Mercurial commands.

3) Links to anything you’ve done this week (hackpads, review requests, blog posts, etc)
  – https://reviews.reviewboard.org/r/6879/

4) What you plan to do next week.
  – Hopefully close this issue on Mercurial. and change the code.

5) What, if anything, is blocking you from making progress?
  – Mostly feedback for my work.

6) Any other questions
– Not yet.



Xuanyi Lin

1. What project are you working on?
Framework and UI for third-party services

2. What you accomplished this week:
Update for the review request on the first part of my project.
Research on backbone and webAPIResource for the UI admin page.
3. Links to anything you’ve done this week:
4. What you plan to do next week:
Implement the UI admin page for integration.
5. What, if anything, is blocking you from making progress?
Backbone and webAPIResource for the integration object.
It will be great to have some feedback for the first part of the project as well.
6. Any other questions?
No.



Stanley Yeo

1. What project are you working on?

Improve Review Bot’s admin interface

2. What you accomplished this week:

Updated old review requests.

Setup dev environment for reviewbot.

Understand how reviewbot works.

Researched json web editors/forms.

Read Django admin documents.

3. Links to anything you’ve done this week:

https://reviews.reviewboard.org/r/6886/

https://reviews.reviewboard.org/r/6919/

https://reviewboard.hackpad.com/Stanleys-Note-y91i8NygfSk

4. What you plan to do next week:

Start implementing admin form of Tool-profile.

5. What, if anything, is blocking you from making progress?

I’ve waited to talk with smacleod, as he has some previous experience with the project, but I couldn’t reach him this weekend.

6. Any other questions?

No.


Rohan Meringenti

1. What project are you working on?

Highlight Active Discussions
2. What you accomplished this week:
I’ve been travelling for a competition this week, so not too
much this week. I’ve played around with the frontend to see
what would look good to highlight areas of focus.
3. Links to anything you’ve done this week:
4. What you plan to do next week:
Integrating the front end and backend changes together
5. What, if anything, is blocking you from making progress?
Just finished the last of my competition trips, so should be much more free from now on.
6. Any other questions?
No.questions

Jessica Qian
1. trivial publishes
2. it should be working for review requests
4. i have a lot of midterms next week, so i will so very simple tasks like testing my code. will hopefully upload for review by end of this week.
5. nothing, i’m making progress slowly, but am able to figure stuff out with enough time.
6. none


Feng Chen

What project are you working on?

Write a plugin for Review Bot

What you accomplished this week.

Rebuild my environment

Links to anything you’ve done this week

https://reviewboard.hackpad.com/Fengs-Note-lHTmrx16YQd

What you plan to do next week.

Learning django and python more. Learn something about fedora as well.

What, if anything, is blocking you from making progress?

Spring festival and my grandma’s illness

Any other questions

[UCOSP] Status Reports: Feb 21, 2015


Chris Arnold

1) What project are you working on?
  • Mute and Archive Review Requests
2) What you accomplished this week.
  • fixed archive query
  • POST request for archiving works (yay!)
  • discovered the magic of PDB!
  • hid “Hide” button when review request is already hidden (archived/muted)
  • added “show archived/hide archived” button on dashboard and hooked it up to a URL query
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • complete banner for unarchiving
  • implement unarchiving
  • write tests
5) What, if anything, is blocking you from making progress?
  • my “show-archived=1” URL query seems to work fine except when I want to combine it with other queries, such as “?view=outgoing”. I am able to append my own query with a “&” but my problem is when the query is already combined “?view=outgoing&show-archived=1” and I want to change the 1 to a 0. I am trying to figure out how to index strings or either rethink the logic and am currently stuck here
6) Any other questions
  • unarchiving should happen automatically when the submitter rbt posts again, any other scenarios to be considered? I was thinking maybe when the submitter responds to a comment or marks something as “fixed” or other actions?
  • should my “show archived/hide archived” button be changed to “show hidden/hide hidden” when I add muting, or should I add a separate “show muted/hide muted” button?
  • difference between archiving and muting: review request should unarchive itself when there’s new activity, while muted should stay muted until manually unmated… any other things?


Vincent Le

1) What project are you working on?

– I am working on the file provider framework

2) What you accomplished this week.

– Addressed to the rest of Barret’s and Christian’s issues
– added get_queryset to both file_provider.py and file_provider_file.py, and made any necessary changes to get and get_list
– cleaned up the test cases and the two files above
– did some manual testing with uploads from DropBox and http requests
– added file upload logic to base_file_attachment.py
– added test cases for the above
– added unique account check
– fixed initialization of fileproviders/fileproviderfile.py
– removed WIP from two of my review requests

3) Links to anything you’ve done this week:

– FileProvider module implementation with Django: https://reviews.reviewboard.org/r/6806/
– FileProvider WebApi integration: https://reviews.reviewboard.org/r/6948/
– New Error for Djblets WebApi – DUPLICATE_ITEM: https://reviews.reviewboard.org/r/6968/              – Examples of uploading files: https://reviewboard.hackpad.com/Extra-Log-for-Vinces-Reports-38dBJnwv9IW

4) What you plan to do next week.

– Design the UI for the upload
– Start looking into backbone and how the file uploads are done with files from local machine
– Start working on the UI, at least get the base ui looks done without any api calls.

5) What, if anything, is blocking you from making progress?

– Nothing yet

6) Any other questions
1) I wasn’t sure about the error I added for the file provider api (DUPLICATE_ITEM), whether it should be part of djblets, reviewboard or not included at all. What should I do?
2) When are the mid-term reports coming out? I would like to know how I’m doing and what improvements I can make.



Jessica Yuen

1) What project are you working on?
  • rb-gateway
2) What you accomplished this week.
  • Refactored rb-gateway into a state suitable for submission based on feedback
  • Reorganized my hackpad
  • Landed initial rb-gateway patch.
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Implement APIs for post commit UI (get branches, get changes, get commits)
5) What, if anything, is blocking you from making progress?
  • Nothing, sorry I’ve been a bit busier this week and didn’t accomplish as much as I hoped.
6) Any other questions
  • Nope.

Jason Tseng
1) What project are you working on?
  • Responsive UI
2) What you accomplished this week.
  • Learning on Backbone.js
  • Moved previous banner menu toggle logic into new backbone view
  • Fixed tab display/align issue in user page
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Properly setting up the backbone view file/insertion
  • Confirm side menu toggle design
  • rebase changes through all branches
5) What, if anything, is blocking you from making progress?
  • Lack of input on the design side (previously posted on google dev)
6) Any other questions
  • Nope.


Theo Belaire

1) What project are you working on?

RBTools

2) What you accomplished this week.

Almost landed r/6797

3) Links to anything you’ve done this week:

review request: https://reviews.reviewboard.org/r/6797/

4) What you plan to do next week.

Get a new project

5) What, if anything, is blocking you from making progress?
Nothing atm.


Tien Vu

1) What project are you working on?
    Diff Doctor
2) What you accomplished this week
    Finally understood how GitWeb (cgit probably has a similar issue)’s availability has the potential for failing a patch.
    More stepping around with the code, now I understand what context data is being grabbed and how the page is rendered (this seriously confused me before, with the inheritance)
    Adjusted some code to render my custom template (instead of the diff_fragment_error one), but it doesn’t do anything special except print stuff from the exception in patch(), where I stick a lot more data into. This is not really what I intend to actually code, but I’m testing around for now.
3) Links to anything you’ve done this week:
    None. I’ve taken notes local to my computer, but it is just the usual code investigation with PDB that won’t make that much sense to anyone else. If this is necessary then I’ll put it on Hackpad.
4) What you plan to do next week.
   I have kind of been delaying work for my templates review request, since I wanted to figure out the big idea behind my more recent project first (Diff Doctor), it’s harder. I will get back to that when I can finish these items:
   – Display a download link for failed diffs, including the original file, the diff, and possibly the .rej file
   – Figure out how to display anything at all with pygments (syntax highlighter). I would like to display the contents of the original file and the diff on the web page.
Then I will attend to my templates code. After that, I want to:
   – “Investigate” the patch problem, like if original file is empty or looks like error HTML, act accordingly
5) What, if anything, is blocking you from making progress?
  – I lost some time this week on not so useful things, like trying to recreate the diff problem with GitHub, or fixing compilation issues with cgit.
6) Any other questions
  – patch()’s parameters for original file and diff are strings. It is writing them to temp files on the local machine, but to get download links, we would need them to be stored somewhere on the server (according to my understanding, you can’t href into local directories, it’s platform/machine dependent). So two problems
  – The original file needs to be stored somewhere
  – The diff can be pulled out of context data, with reverse() which gives a url like: http://localhost:8080/r/99/diff/1/download/111/orig/. But the patch function itself doesn’t have such data. Should I rewrite the function, and should the scope of my work go outside just the patch() function (like other parts that renders the page)

Chester Li

1) What project are you working on?

  • Post-commit review request support for GitLab

2) What you accomplished this week.

  • Fixed the issue in the unit test for review #6786.
  • Roughly implemented all needed functions and classes for the GitLab project.
  • Read GitLab API.
  • Helped peers.

3) Links to anything you’ve done this week:

4) What you plan to do next week.

  • Write unit tests.
  • Debug the code.

5) What, if anything, is blocking you from making progress?

  • The GitLab API document.
  • Haven’t built up very good understanding on Git.
  • Not very useful GitLab community / IRC channel.
  • Network connection.
  • Bad time management because of traveling

6) Any other questions

  • For the `get_change()` function in `GitHub` class in review board.hostingsvce.github, I want to confirm if I understand it in the right way:
    • All we want is to get `author_name`, `revision`, `parent_revision`, `date`, `message`, `diff` to return a Commit object.
    • The goal of getting `tree` and `blobs` is to build up diff.
  • Could you please explain the cache in `get_change()` function, I don’t quite understand how the cache is generated and how it works.
  • Could you please explain the term `revision` in here? Is it sha? Or id of the project or branch?
  • Is `parent_revision` necessary? Because it is default as an empty string in the definition. In GitLab API, I haven’t seen any description about `revision`  (maybe I missed something).
  • Any tips to test the GitLab project on virtual environment? Say, Bitnami.
  • In GitLab class, when we call self.client.http_get(), are we calling the function from HostingService from service.py or GitHubClient in the same file? Because in GitLab class, we are calling http_get() function from HostingService, but if so, what is the purpose of http_get() in GitHubClient / GitLabClient classes and how to call this function?

[UCOSP] Status Report For Week Feb 9 – Feb 15


Jessica Yuen

1. What project are you working on?

- rb-gateway

2. What you accomplished this week:

- Added test cases for checking whether ReviewBoardGateway hosting service subclass can find the repository on rb-gateway, whether authorization sends the expected data, for checking service support capabilities, and checking repository field values.

- Added get_file and get_file_exists implementations to hosting service subclass.

- Added APIs to rb-gateway for getting file blob and checking file existence based on commit id, file path pairing. 

- Made demo video to demonstrate rb-gateway

3. Links to anything you’ve done this week:

- https://reviews.reviewboard.org/r/6831/

- https://reviews.reviewboard.org/r/6850/

4. What you plan to do next week:

- clean up rb-gateway a bit and hopefully get initial patch submitted

- clean up my Hackpad

- Either add Hg support, or add more APIs to rb-gateway to support more advanced functionalities that RB needs (I don’t know which yet – I want to talk to a mentor about this)

5. What, if anything, is blocking you from making progress?

- Nothing

6. Any other questions?

- Nope!

Tien Vu

1) What project are you working on?

 Diff Doctor

2) What you accomplished this week?

- A lot of investigating code. Stepped through most of the stack to display a diff (reviewboard/diffviewer)

- Read Django docs about models and databases to make sense of the DiffSet and FileDiff models

- Rewrote some of the template code for Jinja2

- Made demo video

 

3) Links to anything you’ve done this week

 

https://reviews.reviewboard.org/r/6833/

https://reviewboard.hackpad.com/Tien-Feb-8-o3XQYinbxcc

 

4) What you plan to do next week

Look for specific cases where APIs to return original files fail (therefore failing the patch). I’ll decide what to do from there, as of right now I’m still not 100% clear of my tasks ahead. I might take a look at the diff validator code as well.

 

5) Any blockers for your project?

Not really. 

 

6) Other questions?

No.

Vincent Le

1) What project are you working on?

    – File provider framework

2) What you accomplished this week.

    – Made test cases for reviewboard/fileproviders

    – Redid the file_provider_file to use get_list and get_item, had to take a look into url regex

    – Learned that Django or some component of the framework decodes url automatically, i.e. %7E into ~

    – Addressed most of the issues addressed by Barret and Christian

    – Filmed my demo video

3) Links to anything you’ve done this week:

    – FileProvider module: https://reviews.reviewboard.org/r/6806/

    – FileProvider webapi: https://reviews.reviewboard.org/r/6948/

    – My hackpad: https://reviewboard.hackpad.com/Vincents-File-Upload-Log-sh2QycRO45Z

    – My demo video: https://www.dropbox.com/s/relu15xppvykcjj/VID_20150213_223907.mp4?dl=0

4) What you plan to do next week.

    – Address to issues raised by Barret and Christian

    – move any neccessary parts to get_queryset for both webapi

    – clean up file_provider_file.py

    – get the file upload integrated into file_attachments.py

5) What, if anything, is blocking you from making progress?

    – None yet

6) Any other questions

    – None yet

Chester Li

1) What project are you working on?

  • The post-commit review request support with GitLab

2) What you accomplished this week?

  • Read and built up better understanding on GitLab API
  • Changed some functions in GitLabClient class.
  • Finished unit test for review 6787

3) Links to anything you’ve done this week

4) What you plan to do next week

  • Finish the rest of functions in GitLab and GitLabClient classes.

5) Any blockers for your project?

  • The GitLab API document.
  • The poor internet connection in my current area.

6) Other questions?

  • Nope


Christopher Arnold

1. What project are you working on?

Mute and Archive Review Requests

2. What you accomplished this week.

  • midterm demo!
  • scrapped review_request_visit API and decided on two separate archived_request_visit and muted_request_visit APIs to prevent visits from being exposed
  • added archive/unarchive/mute/unmute functions in reviewRequestVisit model
  • began archive banner
  • webAPI url for archived review requests

3. Links to anything you’ve done week:

Hackpad: https://reviewboard.hackpad.com/Chriss-Notes-aOjnNWbg014

Review Request: https://reviews.reviewboard.org/r/6830/

4. What you plan to do next week.

  • make full connection between button click to database change for archiving and unarchiving
  • complete banner
  • write some tests

5. What, if anything, is blocking you from making progress?

  • getting a 405 error when I make a POST request in my archived_review_request.py, what might be wrong?

6. Any other questions.

  • so far, I’ve went in a couple of wrong directions and had to backtrack a bit. I’d really like it if someone could look at what I’ve done this week to tell me if I’m on the right track and any pointers I should keep in mind going forward
  • when would we want to use `user = resources.user.get_object(request, *args, **kwargs)` as opposed to `user = request.user`?
  • what’s the best way to test webAPI?
  • what does the @property decorator do?

Jason Tseng

1) What project are you working on?

Responsive UI

2) What you accomplished this week?

  • Demo
  • Some advancement on the progress with admin/user page
  • posting design discussions on google dev discussion board

3) Links to anything you’ve done this week

4) What you plan to do next week

  • wrap up admin/user page
  • revisit previous feedbacks

5) Any blockers for your project?

  • Been testing with adding responsive ui for tabs under user’s page, but having issues displaying properly under smaller screen width. In current best attempt, under certain width, the first tab would stuck with two lines while the second and third using only one line, causing different height between the three and thus unaligned display of buttons.

6) Other questions?

n/a

Theo Belaire

1) What project are you working on?

RB Tools, better parent_base

2) What you accomplished this week?

  • Demo
  • I’m ready to land, I feel, at least the first part.

3) Links to anything you’ve done this week

4) What you plan to do next week

  • Populate the Branch field if possible.
  • I’m planning on showing up for office hours and asking a lot of questions, since I’m feeling a bit lost.

5) Any blockers for your project?

  • I would like more feedback about my patch, and I don’t feel super comfortable with `upstream_branch` and how I interact with it.

6) Other questions?

N/A

[Open Academy] Status Report for week from 7th to 14th


Tran Nguyen

  1. What project are you working on?
    — Adding uncommitted flag to support viewing staged and workingcopy
    2. What you accomplished this week?
    — Addresses many comments from David for my projects, almost ready for
    supporting Mercurial
    3. Links to anything you have done this week?
    https://reviews.reviewboard.org/r/6879/
    4. What you plan to do next week:
    — Start my implementation for Mercurial if possible.
    — Supporting uncommitted flag and exclude_pattern at the same time
    (current throw error).
    5. What, if anything, is blocking you from making progress?
    — Most likely the CR step, but I think I can start working on
    Mercurial now.
    6. Any other questions?
    — What everyone do for Valentine =)


Feng Chen

  1. What project are you working on?

— I’m trying to writing a doc about “building the docs”

  1. What you accomplished this week?

— I tried to building the docs .

  1. Links to anything you have done this week?

https://reviewboard.hackpad.com/Fengs-Note-lHTmrx16YQd

  1. What you plan to do next week:

— writing the document mentioned above.

  1. What, if anything, is blocking you from making progress?

— Fedora makes me confused sometimes, but learn something new make me excited.

Mercurial now.

  1. Any other questions?

— No


CHEN, Mingyi

  1. What project are you working on?

Add infinite scrolling to the diff viewer

  1. What you accomplished this week:

WIP infinity scroll on page without considering the memory use.

  1. Links to anything you’ve done this week:

No hackpads. :(

  1. What you plan to do next week:

Do what I planned to do last week.

  1. What, if anything, is blocking you from making progress?

Not familiar with backbone.

  1. Any other questions?

No.

 


Sun Wang Jun

  1. What project are you working on?

Checklist extension.

 

  1. What you accomplished this week:

Nothing much, just explored how to hook into various pages and template points.

 

  1. Links to anything you’ve done this week:

Minor updates to https://reviewboard.hackpad.com/2015-Checklist-Extension-oLIpxP1SzyX

 

  1. What you plan to do next week:

Finish up checklist template manager for users.

 

  1. What, if anything, is blocking you from making progress?

Final week of catching up with school work!

 

  1. Any other questions?

I actually removed certain existing functionality of the original checklist extension, but I continued work on the checklist templates component.

Not sure if it will be a wise idea to post what I currently have for review since the core front-end functionality has been stripped.

Why didn’t Tran answer his own question?

(@Tran : He works on homework and plays video games)

 


Teresa Fan

  1. What project are you working on?

Interactive Issue Summaries

 

  1. What you accomplished this week:

Merged together changes from the first and second part of my project. Tried some different approaches to part 2 based on review comments.

 

  1. Links to anything you’ve done this week:

Ongoing review request for part 2: https://reviews.reviewboard.org/r/6910/

 

  1. What you plan to do next week:

Make changes to my code for part 2 as it gets reviewed, and think about different options for incorporating the new functionalities into the UI. Possibly create some mockups, and then start on part 3.

 

  1. What, if anything, is blocking you from making progress?

Nothing, progress is just slowing down a bit as school gets busier, but doing my best to keep it going.

 

  1. Any other questions?

Nope. For those of you also on the East Coast right now, stay warm!

 


Rohan Meringenti

  1. What project are you working on?

Higlighting Active Issues

 

  1. What you accomplished this week:

Made documentation changes to EasyFix Bugs. Also read all the Git docs, so hopefully Git problems will not happen in the future! Concerning the project, I’ve been playing

around with the timestamp of last visited, and have figured out how to make changes on backend

 

  1. Links to anything you’ve done this week:

https://reviewboard.hackpad.com/ReviewBoard-Notes-Rohan-Meringenti-E057rBWwVOw Just taking notes on the function in question

 

  1. What you plan to do next week:

Put a WIP patch in a day or two, depending on travel that reflects changes on both backend and frontend

 

  1. What, if anything, is blocking you from making progress?

Nothing, if anything I have more time now, since its my last week of travel for competitions

 

  1. Any other questions?

Nope.

 


Xuanyi Lin

  1. What project are you working on?

Framework and UI for integrating with third-party services

 

  1. What you accomplished this week:

Added unit tests to the first part of my project. Worked on the basic structure of the admin UI for managing the integrations.

 

  1. Links to anything you’ve done this week:

Review request for part 1 of my project: https://reviews.reviewboard.org/r/6918/

 

  1. What you plan to do next week:

Update the first part of my code base on the review, and continue to work on the UI component of my project.

 

  1. What, if anything, is blocking you from making progress?

Nothing much. Will be working on part 2 of the project while part 1 is being reviewed.

 

  1. Any other questions?

Happy Lunar New year!

 


Chenxi Ni

1) What project are you working on?

Changing Review Request Ownership

2) What you accomplished this week.

Modify failed tests for my bug #3505.

Change code by the comments.

WIP adding attributes to database table

 

3) Links to anything you’ve done this week (hackpads, review requests,

blog posts, etc)

My RR:https://reviews.reviewboard.org/r/6856/

My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP

4) What you plan to do next week.

Finish my bug this week and for spring festival I will try more work if I have time.

 

5) What, if anything, is blocking you from making progress?

Nothing now.

 

6) Any other questions

Not yet. I will ask in slack if any.

 


Sihang Chen

  1. What project are you working on?

I’ve chosen the project Allow reviews and comments to be wrapped on wide screen, and I’m learning the JavaScript currently and trying to know more about how the codes work.

  1. What you accomplished this week:

I’ve learned something about JavaScript and try to understand the project I’ll be working on.

  1. Links to anything you’ve done this week:

Not this week.

  1. What you plan to do next week:

Keep learning and as soon as I totally understand how the entire project works, I’ll be working on it.

  1. What, if anything, is blocking you from making progress?

It still takes time to understand the entire project or reviewboard, and how does everything work.

  1. Any other questions?

I’ve made some change about fixing the easyFix issue #3636, https://reviews.reviewboard.org/r/6894/ , and there’s no reply yet, looking forward to your help. ^_^

 


Wu Di

  1. What project are you working on?

Better Diff Comment Bubbles

  1. What you accomplished this week:

Finished part 1 of the project.

  1. Links to anything you’ve done this week:

https://reviews.reviewboard.org/r/6932/

  1. What you plan to do next week:

Start working on part 2 of the project to spread out the overlapping bubbles.

  1. What, if anything, is blocking you from making progress?

Nothing much.

  1. Any other questions?

No.


Stanley Yeo

1. What project are you working on?
- Just finished Resizable Image Comment Regions, and started working on Improve Review Bot’s admin interface
2. What you accomplished this week:
- Finished first project (Resizable Image Comment Regions)
- Updated ReviewRequest several times
- Started setting up environments for Improve Review Bot
3. Links to anything you’ve done this week:
4. What you plan to do next week:
- Ask Anselina Chia more about the project
– Make TODO list for it
– Start coding
5. What, if anything, is blocking you from making progress?

– I started late, and couldn’t talk with Anselina much. I will start early next week.

6. Any other questions?
- No.

Jessica Qian
1. What project are you working on?

“Trivial” publishes

2. What you accomplished this week:

I did do-release-upgrade, and upgraded Ubunto, but that messed up my development environment completely… I tried to fix it, but nothing worked, so I ended up deleting and resetting up my entire dev environment.

I added a checkbox to the frontend. I made suggested edits to my Easyfix bug. (I haven’t posted any of these up for review yet).

3. Links to anything you’ve done this week:

https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem

4. What you plan to do next week:

I want to finish the trivial publishing for review requests (not reviews), and post it up for review.

5. What, if anything, is blocking you from making progress?

Other than the issue I ran into with the Ubuntu upgrade, not much.

6. Any other questions?
None

[UCOSP] Status Reports: Feb 07, 2015


Theo Blaire
1) What project are you working on?
• rbtools, better parent-base

2) What you accomplished this week?
• Got sick.
• Fixed this, and remembered to publish my diff this time.
• Editor exiting with non-zero status aborting

3) Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6797/
https://reviews.reviewboard.org/r/6843/

4) What you plan to do next week
• Think of a way to demo nicely, pass midterms, finish that editor patch.

5) Any blockers for your project?
• I have no idea how to properly test that editor thing. It pops up with rbt merge, but I don’t know how to use that.



Jessica Yuen
1) What project are you working on?
• rb-gateway

2) What you accomplished this week?
• Implemented Basic Auth for rb-gateway
• Adding Port to config file for rb-gateway
• Added authorization and fixed the form on the Review Board Gateway hosting service side
• Hooked up rb-gateway to Review Board (i.e. you can add an rb-gateway repository now and rbt post to it)

3) Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6831/
https://reviews.reviewboard.org/r/6850/

4) What you plan to do next week
• Implement test cases for the hosting service
• Implement get_file and get_file_exists on the hosting service side
• Make the video for the ucosp student demo due soon
• More rb-gateway work if time allows

5) Any blockers for your project?
• No, just midterm season soon so will be busier.

6) Other questions?
• Can I get a review of my WIPs?



Christopher Arnold
1) What project are you working on?
• Mute and Archive Review Requests

2) What you accomplished this week.
• revised how the archive query filters the query set
• uses ._query rather than another method that passes an extra_query
• learning more about templates
made plans to add button to the review detail template

3) Links to anything you’ve done this week:
• hackpad: https://reviewboard.hackpad.com/Chriss-Notes-aOjnNWbg014
• review request: https://reviews.reviewboard.org/r/6830/

4) What you plan to do next week.
• add the button that toggles visibility
• finish fixing filtering archived query

5) What, if anything, is blocking you from making progress?
• would like feedback on my review request: https://reviews.reviewboard.org/r/6830/

6) Any other questions
• none right now



Tien Vu
1) What project are you working on?
• Was working on generating auto-commit messages based on Jinja2 templates, now investigating “Diff Doctor”

2) What you accomplished this week?
• Read up PEP8, might take some actual coding to remember all the conventions.
• Cleaned up code for templates.
• Made some draft “unit tests” that needs feedback.
• Managed to reproduce the “Broken Diff” bug.
• Understand and getting more comfortable with diffs and patches (formats of diffs and how the linux commands -diff and -patch work).

3) Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6833/
https://reviews.reviewboard.org/r/6906/
• random notes: https://reviewboard.hackpad.com/Tien-Feb-2-7vacG0AzY7F

4) What you plan to do next week
• I’m not sure about this, because I’m flying to Vietnam for a 5 day “vacation”. I haven’t been back for a long time and probably won’t be for another while, so I intend to spend my time here with friends and relatives. However, I’m planning to do these next:
• Clean up templates/unit tests
• Investigate the Diff Doctor further. I know that there needs to be adequate error handling for the server side command “patch -o “, and this needs to be on the webUI. I need to figure out where the diffs are coming from and sources of broken diffs that occur “naturally” (when I reproduced the bug, I played with the diff file, normally this doesn’t happen).
• Then I want to talk to a mentor to further divide up my work into pieces for the rest of the semester.

5) Any blockers for your project?
• Sort of, I need feedback on my 2 review requests.

6) Other questions?
• Not for now.



Vincent Le
1) What project are you working on?
• Working on the “File Provider framework”

2) What you accomplished this week?
• Worked on search, list and meta for test derived objects
• Worked on the test cases for those
• Worked on the docstring for file_provider webapi
• Was messing around with uploading and saving images on the server

3) Links to anything you’ve done this week
• My WIP progress for the backend: https://reviews.reviewboard.org/r/6806/
• My hack pad: https://reviewboard.hackpad.com/Vincents-File-Upload-Log-sh2QycRO45Z
• Code review for : https://reviews.reviewboard.org/r/6830/
• Code review for : https://reviews.reviewboard.org/r/6833/
• Image of changes I did for when I was messing around: https://reviewboard.hackpad.com/Extra-Log-for-Vinces-Reports-38dBJnwv9IW

4) What you plan to do next week
• Add test cases for uploading files
• Finish uploading files POST request
• Add test cases for `reviewboard/fileproviders/test.py` for the functions found in `./fileprovider.py`
• Add documentation for `file_provider_content`

5) Any blockers for your project?
• Not yet

6) Other questions?
• When I make changes and post to ReviewBoard. I get these errors for `reviewboard/settings.py` (from ReviewBot) with changes I haven’t made. Should I drop them or mark them as fixed?
• Is there any difference between dropping them and marking them as fixed?



Chester Li
1. What project are you working on?
• I am working on issue 3704 (WIP) and post-commit review requests for GitLab.

2. What you accomplished this week.
• Modified api_get_commits(), but not 100% completed because I am not too sure I fully understand GitLab API
• maybe need to change number parameter, possibly remove ‘start’
• need to test the url format
• Implemented api_get_tree(), same progress as the api_get_commits().
• Implemented api_get_heads(), same progress as the api_get_commits().
• Implemented _build_api_url().
• Implemented _check_api_errors().
• Got better understanding on GitLab API.

3. Links to anything you’ve done week:
https://reviews.reviewboard.org/r/6782/
https://reviewboard.hackpad.com/Chesters-Code-Sprint-Logs-Keep-updating-t6UxLoMfjmD

4. What you plan to do next week.
• Keep working on that GitLab project, harder.

5. What, if anything, is blocking you from making progress?
• The ambiguous GitLab API document and it is a little bit hard to seek for online help with the specific GitLab topic.

6. Any other questions.
• One technic question:
• In GitLab class, when we call self.client.http_get(), are we calling the function from HostingService from service.py or GitHubClient in the same file? Because in GitLab class, we are calling http_get() function from HostingService, but if so, what is the purpose of http_get() in GitHubClient / GitLabClient classes and how to call this function?


Jason Tseng
1) What project are you working on?
• Responsive UI
2) What you accomplished this week?
• Split previous review request into smaller chunks
• WIP – admin & user page
3) Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6796
https://reviews.reviewboard.org/r/6922/
https://reviews.reviewboard.org/r/6923/
https://reviews.reviewboard.org/r/6893/
https://reviewboard.hackpad.com/Jasons-Pad-k2QPr3KBxDc

4) What you plan to do next week
• Gather input on UI design and finish admin/user page

5) Any blockers for your project?
• N/A

6) Other questions?
• N/A