[Open Academy] Status Reports, March 21st


Rohan Meringenti

1. What project are you working on?
Highlighting Active Issues

2. What you accomplished this week:
Finished up front end and made changes as suggested by David for style

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/7008/ Highlighting active issues review request

4. What you plan to do next week:
Work on revokable ship-it labels, have both frontend and backend completed as well as webapi updated

5. What, if anything, is blocking you from making progress?
Nothing

6. Any other questions?
Nope


Sun Wang Jun

1. What project are you working on?
Checklist extension (templates)

2. What you accomplished this week:
Finished up initial part of checklist templates for account pages
Fixed an issue that caused the extension to be hidden after it reloads
Minor code reviews here and there

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/7099/ initial checklist templates implementation
https://reviews.reviewboard.org/r/7103/ review request for extension account page issue

4. What you plan to do next week:
Integrate templates into the existing checklist
Improve on the API related code for the existing checklist

5. What, if anything, is blocking you from making progress?
https://reviews.reviewboard.org/r/6969/ needs reviews so as to facilitate what I plan to do next week

6. Any other questions?
How would extensions use translations?


Zhiyu Xia

1. What project are you working on?
Add per-user Default reviewer setting

2. What you accomplished this week:
Change the setting page of global dafualt reviewers and
Do something about per-user setting

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/Zhiyus-Notes-WLFl1aHM4fE
The diff may be uploaded to reviewboard next week

4. What you plan to do next week:
Finished the per-user setting page about default reviewers.

5. What, if anything, is blocking you from making progress?
to design the per-user setting view.

6. Any other questions?
No


Teresa Fan

1. What project are you working on?
Interactive Issue Summaries

2. What you accomplished this week.
Got the fix/drop buttons in the issue summary table to successfully change the status of issues!

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/6997/
https://reviewboard.hackpad.com/Teresas-Notes-gI6ljBKu7ra

4. What you plan to do next week.
Figure out why when an issue is reopened, the button bar doesn’t reappear correctly in the table.

5. What, if anything, is blocking you from making progress?
Nothing for now, I haven’t gotten the chance to investigate what the reason might be yet.

6. Any other questions.
When creating a CommentIssueBarView, why are the reviewID and commentID fields supposed to be the same? The names are misleading–I had thought the reviewID field should be the actual ID of the review instead of just the same as the comment ID, which was the source of my bug from last week. Or am I mistaken about what the review/comment IDs mean?


Mingyi Chen

1. What project are you working on?
Add infinite scrolling to the diff viewer

2. What you accomplished this week.
Accomplish the infinite scroll and fix all the bugs it appears.
Upload to the rb.

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7047/
https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY

4. What you plan to do next week.
Learn about the the javascript memory management. And try to reduce the memory usage.

5. What, if anything, is blocking you from making progress?
Current loading framework is not easy to do the memory management.

6. Any other questions.
How to test what I’ve done(infinite scroll) is correct.


Wu Di

1. What project are you working on?
Better Diff Comment Bubbles
I’m currently extending the project to allow replying to reviews from the diffviewer page.

2. What you accomplished this week:
Fixed issues in current review requests.
Did some code reviews.
Came up with specification and mockup for the replying to reviews project

3. Links to anything you’ve done this week:
Mockup and specification: https://reviewboard.hackpad.com/Wu-Dis-Notes-sULvWjtXN56#:h=Allow-replying-to-reviews-from

4. What you plan to do next week:
If there are no problems with the specification, I’ll proceed with this project and get the comment dialog to display the fully rendered reviews properly.

5. What, if anything, is blocking you from making progress?
I picked this project from the Ideas without sufficient definition section of the student project ideas page. Before I proceed, can the mentors have a look to make sure that the specification that I came up with are correct?

6. Any other questions?
None for now.


Chen Sihang

1. What project are you working on?
Add Unreviewed section in the Dashboard.

2. What you accomplished this week.
Accomplish the front-end view part which is to add the two unreviewed section in the dashboard sidebar.

3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Chen-Sihangs-Notes-1t6Ki8onOzy

4. What you plan to do next week.
Continue working on the function of the unreviewed thing.

5. What, if anything, is blocking you from making progress?
Understand the structure of the project.

6. Any other questions.
No.


Jessica Qian

1. What project are you working on?
“Trivial” publishes

2. What you accomplished this week:
I did not do much this week because of midterms.

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/7022
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem

4. What you plan to do next week:
I will make final edits to backend methods for trivial reviews, and start frontend edits.

5. What, if anything, is blocking you from making progress?
​None​


Stanley Yeo

1. What project are you working on?
Add OAuth2 provider support

2. What you accomplished this week:
Updated RRs.
Studied OAuth2.
Researched OAuth2-django libraries.

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/Stanleys-Note-y91i8NygfSk
https://reviews.reviewboard.org/r/6999/

4. What you plan to do next week:
Understand studying OAuth
Pick on or two libraries to try with reviewboard
Start Implementing

5. What, if anything, is blocking you from making progress?
None

6. Any other questions?
None


Ni Chenxi

1) What project are you working on?
Changing Review Request Ownership

2) What you accomplished this week.
[WIP] adding tests. I’ve add some tests about the front end and try to add some about backend.

3) Links to anything you’ve done this week (hackpads, review requests,
blog posts, etc)
My WIP RR for my feature: https://reviews.reviewboard.org/r/6990/
My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP

4) What you plan to do next week.
Finish the tests.

5) What, if anything, is blocking you from making progress?
How can I test whether a user that is not the current submitter change the submitter?

6) Any other questions
Not yet.


Lin Xuanyi

1. What project are you working on?
Framework and UI for integrating with third-party services

2. What you accomplished this week:
Iterate on the design for the UI admin page.
Added permissions to both model and admin page.
Integrate the backbone model with the WebApi resource.
Writing test for the webapi resource.
Split the review for part 2.

3. Links to anything you’ve done this week:
Integration model: https://reviews.reviewboard.org/r/6918/
WebApi resource for Integration: https://reviews.reviewboard.org/r/7105/
Integration admin page(Backbone): https://reviews.reviewboard.org/r/7106/

4. What you plan to do next week:
Complete the test for part 2.
Write integration form.

5. What, if anything, is blocking you from making progress?
None.

6. Any other questions?
None.


Chen Feng

1) What project are you working on?
Create a new tool plugin.

2) What you accomplished this week.
Nothing. I am working on a project for our trainning lesson. I’ll continue my work this weekend.

3) Links to anything you’ve done this week (hackpads, review requests, blog posts, etc)
Hackpad notes:
https://reviewboard.hackpad.com/Fengs-Note-lHTmrx16YQd

4) What you plan to do next week.
Fixed the bug.

5) What, if anything, is blocking you from making progress?
Not yet.

[UCOSP] Status Reports: March 15th to 21st


Vincent Le

1) What project are you working on?
– FileProvider framework

2) What you accomplished this week.
– Made changes as suggested by Christian and Barret in my reviews
– Added search logic to show search results on the options for selection. Search result is displayed after 500ms after the last key up in the search field, or display the current path when search field is empty.
– Started implementing display metadata for selected files
– Did some small refactoring for my JS file
– Fixed a bug regarding metadata in my test cases and testing class for FileProviders

3) Links to anything you’ve done this week:
– FileProvider module implementation with Django : https://reviews.reviewboard.org/r/6806/
– FileProvider WebApi integraton : https://reviews.reviewboard.org/r/6948/
– [WIP] FileProvider Framework UI : https://reviews.reviewboard.org/r/7009/

4) What you plan to do next week.
– Finish display metadata
– Make my file navigation for FileProvider modal compatibile with any provider
– Get to create accounts

5) What, if anything, is blocking you from making progress?
– Nothing I can think of yet

6) Any other questions
– Nothing I can think of yet


Chester Li

1) What project are you working on?
  • Post-commit review request support for GitLab


2) What you accomplished this week.
  • Refactored code for 2 review requests according to reviews.
  • One bug fix has been submitted
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Start a new project, do as much as I can
5) What, if anything, is blocking you from making progress?
  • I was basically waiting for the review and did some changes.
6) Any other questions
  • Not yet


Tien Vu

1) What project are you working on?
    – Diff Doctor
2) What you accomplished this week.
    – In summary, replaced failed patch traceback with inline Pygments, as collapsible links. I tried to figure out how to make it like the plus button for a review request change, but I lack the frontend knowledge, so I’m sticking with <a href>.
3) Links to anything you’ve done this week:
    – Learned how to use Pygments: http://pygments.org/docs/
4) What you plan to do next week.
    – Decide what to do when patch fails because of a non PatchError (like SCMError). Right now it just links to a template that displays the error like {{ error.msg }}.
    – After this, is there anything major left to do for my 2 projects? For Diff Doctor, Christian suggested me to skip “step 2″ of analyzing the source problem of failing the patch, but we agreed to skip over this because it’s too complicated for now. The other 2 parts of showing the .zip and showing the reject files instead of the traceback works. Should I pick a smaller project to work on?
5) What, if anything, is blocking you from making progress?
    – How can I land my changes to master? Should I at least push my branch(es) up?
6) Any other questions
    – No


Jessica Yuen

1. What project are you working on?
rb-gateway
2. What you accomplished this week.
Sorry I’ve been a super occupied with other work this week…
- Fixed outstanding issues on existing review requests (7053 & 7054)
- Added unit testing for configuration loading

3. Links to anything you’ve done week:
4. What you plan to do next week.
- Since Pencils Down is a week and half from now, I think I’ll just concentrate on adding any missing test cases, getting rb-gateway to a polished state. I think it’s already pretty complete for the features that have been requested so far, but let me know if I’m wrong.

5. What, if anything, is blocking you from making progress?
- N/A

6. Any other questions.
- Nope.


Chris Arnold

1) What project are you working on?
  • Mute and Archive Review Requests
2) What you accomplished this week.
  • handled automatic unarchiving
  • fixed URL query
  • split up project into smaller review requests
3) Links to anything you’ve done this week:
4) What you plan to do next week
  • attend to several reviews by David and Barret
  • getting used to the workflow of using several review requests that depend on each other
  • tests
5) What, if anything, is blocking you from making progress?
  • the splitting up of my project
6) Any other questions
  • I’ve split up my project, but it’s been trickier than I thought, especially when trying to decide which line of code belongs to which review request… Working on my project seems a lot more fragile now, and my pace has definitely slowed down. It seems like I need to rebase AND rbt post up to 3 branches whenever I want to make a change, since all my review requests rely on each other.
    • Any tips out there that I could use to make this process easier?
    • Is there a slick way to transfer changes from one review request to another?


Jason Tseng

1. What project are you working on?

Responsive UI

2. What you accomplished this week.

- Additional aesthetic update on part 1

- Changes applied to the rest

- half way on secondary menu button design

3. Links to anything you’ve done week:

- https://reviews.reviewboard.org/r/6796

4. What you plan to do next week.

- Finish secondary menu button

5. What, if anything, is blocking you from making progress?

- passing review on part 1

6. Any other questions.

- Nope.

[Open Academy] Status reports – March 14, 2015

Chenxi Ni

1) What project are you working on?

Changing Review Request Ownership

2) What you accomplished this week.

Finish adding some notifications to users before they publish with different submitter.

3) Links to anything you’ve done this week (hackpads, review requests,

blog posts, etc)

My WIP RR for my feature:  https://reviews.reviewboard.org/r/6990/

My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP

4) What you plan to do next week.

Start with adding tests.

5) What, if anything, is blocking you from making progress?

Not yet.

6) Any other questions

Not yet.

Teresa Fan

1. What project are you working on?

Interactive Issue Summaries

2. What you accomplished this week.

Addressed comments on my review request.

3. Links to anything you’ve done week

https://reviews.reviewboard.org/r/6997/

4. What you plan to do next week.

Get the buttons to actually work, I haven’t properly hooked them up with the commentManagerModel.

5. What, if anything, is blocking you from making progress?

Nothing for now, spring break is over so I’ll be back to making real progress.

6. Any other questions.

How do I remove a diff file from a review request? My review request mistakenly includes the .DS_Store file.

Sun Wang Jun

1. What project are you working on?

Checklist extension (user templates)

2. What you accomplished this week:

Updated checklist extension UI review request

Understood WebAPIResource, Backbone.js

Started work on templates

3. Links to anything you’ve done this week:

https://reviews.reviewboard.org/r/6969/ // updated review request

4. What you plan to do next week:

Finish up user templates

Start thinking about integration with the current ui

5. What, if anything, is blocking you from making progress?

Extension keeps shutting down after a while, I know when it happens but I don’t know why it happens:

a) The logger restarts

b) Then the extension shuts down, and restarts

c) But the AccountPagesHook no longer hooks into account pages

which means I have to manually restart the entire server to get the hook working again

6. Any other questions?

I think I asked in Slack at inappropriate timings… so:

a) I think it will be less confusing if checklist templates were to be called checklist groups, or something else. Any opinions?

b) I can live with the extension shutting down problem for now, just wastes a few seconds everytime, or should I focus on fixing that first?

c) In the checklist templates/groups, is there a need for the checklist items to be checked by default? I can think of a possible use case as checking all items by default, so that the user only unchecks.

And a misc question: Does WebAPI not allow or deal with XML request payloads in incoming HTTP requests? I wanted to use Backbone.Collection.create but that sends POST request data as Request Payload instead of Form Data, as a result the @webapi_request_fields was not able to extract the fields.

  

Xuanyi Lin

1. What project are you working on?

Framework and UI for integrating with third-party services

2. What you accomplished this week:

Implemented webapi for Integration and ConfguredIntegration model

Implemented the backbone model and template

Added resource path for icon from integration

Partially done admin page for integrations

Fix issues for my previous RR

3. Links to anything you’ve done this week:

RR for part 1 of my project: https://reviews.reviewboard.org/r/6918/

RR for part 2 of my project: https://reviews.reviewboard.org/r/7034/

Code review: https://reviews.reviewboard.org/r/6999/

4. What you plan to do next week:

Finish up on the backbone and template for integrations

Split the current RR for part 2 into two parts

Work on test for part 2 if possible

5. What, if anything, is blocking you from making progress?

Nothing much for now.

6. Any other questions?

Nope.

Wu Di

1. What project are you working on?

Better Diff Comment Bubbles

2. What you accomplished this week:

Implemented all the functionalities of the third part of the project to make the draft comments movable and resizable.

Updated the first project based on review comments.

3. Links to anything you’ve done this week:

Hackpad: https://reviewboard.hackpad.com/Wu-Dis-Notes-sULvWjtXN56

Part 1: https://reviews.reviewboard.org/r/6932/

Part 3: https://reviews.reviewboard.org/r/7032/

4. What you plan to do next week:

Review code.

Update my review requests when necessary.

Start looking for a new project.

5. What, if anything, is blocking you from making progress?

Some code reviews for part 2 (https://reviews.reviewboard.org/r/6970/) would be nice.

6. Any other questions?

I’ve finished implementing the moving and resizing functionalities based on Christian’s comments, but I’m not sure whether it’s correctly done.

Part 2 of my project modifies the same file textBasedCommentBlockView.js as part 3 of the project, they are independent of each other but should I integrate them now?

Rohan Meringenti

1. What project are you working on?

Highlighting Active Issues

2. What you accomplished this week:

Made front end changes to site to reflect new issues

Started backend for grouping issues. Trying to come up with

some ideas for how to reflect the changes in the front end to be ui friendly.

3. Links to anything you’ve done this week:

https://reviews.reviewboard.org/r/7008

4. What you plan to do next week:

Start looking for a new project

Review code

Finish part 2 of the project

5. What, if anything, is blocking you from making progress?

I’ll put up an update to front end when I get home today. I had a question on how less files were being generated. I updated one of the less

files to add a class tag with a style elements. However, when I add the tag in the html the changes aren’t there, do I have to compile the less files for the

new changes to show up? I’m not really familiar with how less works.

6. Any other questions?

If I wanted to post screenshots for how the page looks with the front end changes, how would I be able to do that in a review?

Stanley Yeo

1. What project are you working on?

Improve Review Bot’s admin interface

2. What you accomplished this week:

Updated RRs

3. Links to anything you’ve done this week:

https://reviews.reviewboard.org/r/6998/

https://reviews.reviewboard.org/r/6999/

4. What you plan to do next week:

Finish current project.

Pick another project to work on.

5. What, if anything, is blocking you from making progress?

None.

6. Any other questions?

None.

Jessica Qian

1. What project are you working on?

“Trivial” publishes

2. What you accomplished this week:

Trivial publishes work completely for review requests.

3. Links to anything you’ve done this week:

https://reviews.reviewboard.org/r/7022

https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem

4. What you plan to do next week:

Not much, because it is midterm week again.

5. What, if anything, is blocking you from making progress?

None.

6. Any other questions?

Nope.

Mingyi Chen

1. What project are you working on?

Add infinite scrolling to the diff viewer

2. What you accomplished this week:

Test for scroll bugs and fix.

3. Links to anything you’ve done this week:

https://reviews.reviewboard.org/r/7047

https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY

4. What you plan to do next week:

Finish the project

5. What, if anything, is blocking you from making progress?

Scroll to the bottom and scroll up, it will still recognize it at the bottom.

6. Any other questions?

No. :)

[UCOSP] Status Reports – March 14, 2015

Jessica Yuen

1) What project are you working on?
  • rb-gateway
2) What you accomplished this week.
  • Added unit tests to Review Board Gateway on RB’s side; landed
  • Added a test suite for all Git functionalities that rb-gateway is currently performing
  • Submitted a review request to have rb-gateway return a diff for commits with no parent
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Fix outstanding issues with existing review requests
  • Add more test collections for rb-gateway (Focus will be on the routes.go, but hopefully I’ll have time to add all remaining tests)
  • Depending on my progress against the above tasks, and whether or not there’s more work I can do for this project currently, I might pick up another mini project? I’m not sure. I really like this project and would like to keep working on it though.
5) What, if anything, is blocking you from making progress?
  • N/A
6) Any other questions
  • Not right now.

Chester Li

1) What project are you working on?
  • Post-commit review request support for GitLab
2) What you accomplished this week.
  • Added unit tests and debugged for the project. The whole project is waiting to be reviewed.
  • Did code reviews.
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • I think my current project is done so far, so probably start a new one?
  • Review peers’ code
5) What, if anything, is blocking you from making progress?
  • Only GitLab’s incomplete API
6) Any other questions
  • If I would like to start a new project, how much time I have until the end of the term?
  • May I get some regular feedback, say every 2 weeks, from mentors? For improving my development process, because it seems like we would not have feedback until finals besides some chunks of responses from Slack chat.

Tien Vu

1) What project are you working on?
  • Diff Doctor
2) What you accomplished this week.
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Land these projects
  • Proceed to stage 2 of Diff Doctor
5) What, if anything, is blocking you from making progress?
  • I updated my 2 review requests. I closed “most” of the issues and commented on a few because I didn’t agree with the suggestions. Am I supposed to do this, or just drop the issue?
  • I injured my lower back, and can’t sit for more than 20 minutes at a time. Not good for any kind of studying. I’ll need to see a doctor next week
6) Any other questions
  • No, but I would like feedback on my 2 projects and land them sooner than later.

Vincent Le

1) What project are you working on?
  • FileProvider Framework
2) What you accomplished this week.
  • Changed the http status code for DUPLICATE_ITEM in djblets and reflected the changes in the test cases
  • Fixed my backbone models for FileProvider and FileProviderNode, to work and match the new changes
  • Added more functionality for File Provider UI: Changing accounts, navigating, selecting items
  • Cleaned up the mock/test code
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Add displaying of meta-information
  • Fix a collection url issue (discussed in questions)
  • Create account
5) What, if anything, is blocking you from making progress?
  • Applied to this week, was sick and had lots of assignments
6) Any other questions
  • Is there any code styling for CSS or JS?
  • I am not sure if I am doing the backbone collection right. As an example:this._fileProviderAccountsCollection = new RB.ResourceCollection([], {
    model: RB.FileProvider,
    extraQueryData: {
    ‘order-by': ‘account_name,provider_name’
    }
    });

    this._fileProviderAccountsCollection.url = “/api/file-providers/”;

    I am not sure how to set URL correctly to point to my FileProvider url. I have a feeling it has something to do with parentResource but I am not sure how.

Chris Arnold

1) What project are you working on?
  • Mute and Archive Review Requests
2) What you accomplished this week.
  • investigating ‘published’ triggers to handle automatic unarchiving
  • beginning testing
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • split up project into smaller review requests
  • finish automatic unarchiving
  • fix URL query
  • tests
5) What, if anything, is blocking you from making progress?
  • nothing right now
6) Any other questions
  • a follow up from last week’s question I asked (which Mike answered): “how should I approach simultaneously removing all archived states for one review request?”
    • the use case for this would be when there’s new activity for a review request and review request should become visible again to all users who archived it
    • should looping through every user (for that review request) be done on the JavaScript side or the webAPI?
  • what’s the best (easiest) way to split up my project into smaller review requests (probably into 3 or 4 separate review requests)?

Theo Belaire

1) What project are you working on?
  • rbtools
2) What you accomplished this week.
  • Cleaned up r/6797/, and writing more tests.
  • Read code for rbt post -u.
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Finish tests, check for efficiency issues on large repos.
5) What, if anything, is blocking you from making progress?
6) Any other questions
  • Not right now.

Jason Tseng

1) What project are you working on?

  • Responsive UI

2) What you accomplished this week.

  • Finish code styling updates on part 1
  • Rebased all master branch and part 1 to the rest of the parts (2-6)
  • Revisited all parts with code styling comments from part 1

3) Links to anything you’ve done this week:

4) What you plan to do next week.

  • Secondary menu button design
  • Look up new projects

5) What, if anything, is blocking you from making progress?

  • Confirmation on changes in part 1 (#6796)

6) Any other questions

  • n/a

[UCOSP] Status Reports for week March 1st to March 7th

Theo Belaire
1. What project are you working on?
-review board tool.
2. What you accomplished this week.
-Thought about the speeding up rbt post -u via caching the review id.
3. Links to stuff you’ve done.
Faster rbt post -u
4. What you plan to do next week.
Write tests, land the old parent base code.
5. Any blockers?
Homework of doom.
6. Other questions
N/a

Chester Li
1) What project are you working on?
  • Post-commit review request support for GitLab
 
2) What you accomplished this week.
  • Made post-commit support for GitLab work on my local server.
  • Wrote unit tests for review request #6786 and #6872
  • Did some code reviews.
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Finish up unit tests and land the whole project.
  • If the project will be done next week, I would like to start a new one.
5) What, if anything, is blocking you from making progress?
  • GitLab API string format.
6) Any other questions
  • N/A

Jessica Yuen
1. What project are you working on?
rb-gateway
2. What you accomplished this week.
- Finished fixing issues surrounding post-commit APIs on rb-gateway; landed
- Refactored rb-gateway URLs to use path parameters over query parameters; landed
- Implemented all post commit APIs on RB’s side, tested that they work
- Did a couple code reviews
 
3. Links to anything you’ve done week:
4. What you plan to do next week.
This week will all be about testing. :(
- Implement post commit UI unit tests on RB’s side
- Implement a testing suite / framework for rb-gateway
- Hopefully get #6850 landed (after adding more tests and fixing future issues)
- Discuss what’s next for this project
 
5. What, if anything, is blocking you from making progress?
- N/A
 
6. Any other questions.
- Where should I be taking rb-gateway (in terms of new APIs / other features) after I complete ‘What you plan to do next week.’?

Tien Vu
1. What project are you working on?
DiffDoctor
2. What you accomplished this week.
Copy pasted from my commit messages
commit 81d9a173ca1e287a91790b5bc81307bc91395dda
Author: Tien <tienv@sfu.ca>
Date:   Sat Mar 7 18:09:13 2015 -0800
Move location of diff file rejection download
Summary of changes:
- Deleted PatchErrorView, instead rendering content in ReviewsDiffFragmentView
- Simplified get() function in PatchErrorDownloadView
- Add exception handling for SCMErrors (which are in turn thrown when HTTPErrors are thr
- Added a wrapper in DiffFragmentView to let subclasses insert extra context variables w
- Change template code in diff_fragment_error.html to display Diff Doctor information
commit daceec0d39a53f0fe6daefe832ea345ce48f6d46
Author: Tien <tienv@sfu.ca>
Date:   Tue Mar 3 21:01:12 2015 -0800
WIP: introductory phase for Diff Doctor
Summary of changes:
- Created a view for viewing patch results
- Created a view for downloading patch files (does not work yet)
- Created a PatchError class, which is now caught by ReviewDiffFragmentView
3. Links to anything you’ve done week:
Diagram depicting my idea of the DiffDoctor project + steps to do
Also read up on Django templates, and the custom template tags defined in djblets. I will need this knowledge
4. What you plan to do next week
- Attend to my old project @ https://reviews.reviewboard.org/r/6833/, do any necessary clean-ups
- Improve code based on feedback for DiffDoctor, to land “Introductory step of project”. I am pretty sure the code works (views, exception handling, and the zip download), however there could be other side problems.
- Start looking at “phase 2″: diagnosing the “real” problem behind patch() failure and display useful content in diff_fragment_error.html.
5. What, if anything, is blocking you from making progress?
- Nothing too special, I guess I am used to getting stuck by now :D
6. Any other questions.
- This project is somewhat weakly defined. It’s supposed to be, I understand, and want to move in the right direction. I would like to know if Christian’s description of tasks fits with my diagram of the project
Also, whether I’ve implemented the “introductory step” correctly, with description in
- I feel like I should do some code reviews, but also feel that I don’t know enough about the code architecture or Python (yet) to do so. Investigating unknown code takes time, going through it will be inefficient (time is limited). Is there a project that is somewhat related to what I’m doing (like stuff in reviews/views, diff fragments…) that I can take a shot at?


Vincent Le

1) What project are you working on?

– File Provider Framework

2) What you accomplished this week.

– Drew up one mock image
– Refactored File_Provider_File to File_Provider_Node
– Changed the initialization of Node/File/Dir in reviewboard.fileproviders.tree
– Started working on the UI, with mock data
– Added some functionality to the upload dialog view
– Started working a bit on the models for the webapi (backbone side)

3) Links to anything you’ve done this week:

– FileProvider UI Mockup: https://reviewboard.hackpad.com/File-Provider-UI-mockup-hlsI7BmPjzq
– FileProvider module implementation with Django: https://reviews.reviewboard.org/r/6806/
– FileProvider WebApi integraton: https://reviews.reviewboard.org/r/6948/
– [WIP] FileProvider Framework UI: https://reviews.reviewboard.org/r/7009/

4) What you plan to do next week.

– Add some more functionality to the view
– Have the models work with the json payload from webapi
– integrate model into the view

5) What, if anything, is blocking you from making progress?

– BackBone.JS, don’t fully understand it

6) Any other questions

– None


 Christopher Arnold

1) What project are you working on?
  • Mute and Archive Review Requests
2) What you accomplished this week.
  • finished banners
  • implemented automatic refreshing
  • finished unarchiving
  • finished all of muting and unmuting
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • implement automatic unarchiving (on new activity)
  • rename the show/hide archived button to show/hide hidden
    • is “hide hidden” okay for wording??
  • write tests
5) What, if anything, is blocking you from making progress?
  • (from two weeks ago) my “show-archived=1” URL query seems to work fine except when I want to combine it with other queries, such as “?view=outgoing”. I am able to append my own query with a “&” but my problem is when the query is already combined “?view=outgoing&show-archived=1” and I want to change the 1 to a 0. I am trying to figure out how to index strings or either rethink the logic and am currently stuck here
6) Any other questions
  • how should I approach simultaneously removing all archived states for one review request? currently the webAPI can only unarchive one review request per user
  • will the issues we bring up in “5) what is blocking you” be answered in these status reports or should they be more for Slack?
  • is there a way to add/edit a previous diff’s Change Summary?
  • is “hide hidden” okay for wording??
  • what other things should I consider for this project besides what I mentioned in “4) What do you plan to do next week?”


 Jason Tseng

1) What project are you working on?
  • Responsive UI
2) What you accomplished this week.
  • Updated some code styling according to feedbacks. Didn’t get to have much done this week due to travel.
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Code cleaning for Responsive UI
5) What, if anything, is blocking you from making progress?
  • N/A
6) Any other questions
  • How long do we have till end of the program? Possibility in starting new project?

UCOSP Status Reports: Feb 22 – Feb 28


Tien Vu

1. What project are you working on?
- Diff Doctor
2. What you accomplished this week.
- Clarify(ing) my exact steps for the project with Chris
- Came up with some code to see if I’m on right track
3. Links to stuff you’ve done.
4. What you plan to do next week.
I need to carefully read Chris’s feedback on my dummy work, think about it for a while, and then decide on what to do next.
5. Any blockers?
Nothing unsolvable at the moment
6. Other questions
——

Chester Li
1) What project are you working on?
Post-commit review request support for GitLab
2) What you accomplished this week.
Refactored the code3) Links to anything you’ve done this week:
hackpad: https://reviewboard.hackpad.com/Chesters-Code-Sprint-Logs-Keep-updating-t6UxLoMfjmD
project review request: https://reviews.reviewboard.org/r/6872/4) What you plan to do next week.
Keep debugging.
Writing tests5) What, if anything, is blocking you from making progress?
No6) Any other questions
No

—–

Vincent Le

1) What project are you working on?

– FileProvider framework

2) What you accomplished this week.

– Made changes to the feedback suggested by Christian (assertion message removal, used better asserts, changed file/dir design)
– Updated webapi responses to differentiate between files and directories
– Added new exceptions for webapi, for objects not found
– Learned a bit about backbone.js to help get me started
– Did some mockup designs on the UI

3) Links to anything you’ve done this week:

– Learn backbone.js through this tutorial: http://adrianmejia.com/blog/2012/09/11/backbone-dot-js-for-absolute-beginners-getting-started/
– FileProvider module implementation with Django: https://reviews.reviewboard.org/r/6806/
– FileProvider WebApi integration: https://reviews.reviewboard.org/r/6948/
– Mock-up: https://reviewboard.hackpad.com/File-Provider-UI-mockup-hlsI7BmPjzq

4) What you plan to do next week.

– Finish up the UI mockup, just one more image (a clearer version of the UI)
– Work on the UI, get the interface down
– add some interaction and linkage to the webapi

5) What, if anything, is blocking you from making progress?

– Nothing

6) Any other questions

– Not yet

—–

Jessica Yuen
1. What project are you working on?
rb-gateway2. What you accomplished this week.
I’ve been completing the post commit APIs on rb-gateway’s side
– rb-gateway API for getting all commits
– rb-gateway API for getting a single commit with the diff
– rb-gateway API for getting all branches
– a code review
– minor fix for access logging in rb-gateway3. Links to anything you’ve done week:
https://reviews.reviewboard.org/r/6973/
https://reviews.reviewboard.org/r/6972/
https://reviews.reviewboard.org/r/6872/#review16956
https://reviewboard.hackpad.com/Jessicas-Hackpad-YoeQkh0kDE04. What you plan to do next week.
– rb-gateway get_commits API needs to return at max one page of commits
– rb-gateway get_change API’s diff needs to include full indexes
– remove the bug tracker field from Review Board Gateway hosting service form
– change the API URIs in rb-gateway to be more RESTful
– (If time allows) integrate the post commit API onto Review Board’s side5. What, if anything, is blocking you from making progress?
Struggling a bit on identifying how to return full patch indexes with libgit2 / git2go. Will probably figure it out eventually though…

6. Any other questions.
Nope.

—–

Christopher Arnold
1) What project are you working on?
Mute and Archive Review Requests2) What you accomplished this week.
added banner
got half-way through unarchiving
unfortunately didn’t have much time this week due to midterm week3) Links to anything you’ve done this week:
hackpad: https://reviewboard.hackpad.com/Chriss-Notes-aOjnNWbg014
review request: https://reviews.reviewboard.org/r/6830/4) What you plan to do next week.
add muting once archiving is done
start automatic unarchiving
change review request description to an overview and keep smaller changes for individual diffs5) What, if anything, is blocking you from making progress?
(from last week) my “show-archived=1” URL query seems to work fine except when I want to combine it with other queries, such as “?view=outgoing”. I am able to append my own query with a “&” but my problem is when the query is already combined “?view=outgoing&show-archived=1” and I want to change the 1 to a 0. I am trying to figure out how to index strings or either rethink the logic and am currently stuck here
can’t figure out why my delete method in archived_review_request webAPI is not being picked up with .destory in archivedReviewRequestModel.js and alerts/PDB don’t seem to be helping. I’m tracing the problem to ‘Backbone.Model.prototype.destroy.call’, not really sure where it goes from there. My code is in the diff I just posted

6) Any other questions
will the issues we bring up in “what is blocking you” be answered in these status reports or should they be more for Slack?
in the webAPI, currently I’m using POST for archiving and DELETE for unarchiving but looks like the djblets webapi resource suggests using PUT for both instead, should I be using that?
is there a way to add/edit a previous diff’s Change Summary?


Jason Tseng

1) What project are you working on?
Responsive UI

2) What you accomplished this week.
Proper insertion of backbone views
Rebased changes through branches
Code styling fixes according to comments

3) Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/6796/
https://reviews.reviewboard.org/r/6922/

4) What you plan to do next week.
Confirm side menu toggle design
Wrap up code styling / comments updates

5) What, if anything, is blocking you from making progress?
N/A

6) Any other questions
N/A

—–


Theo Belaire

1) What project are you working on?
RBTools
2) What you accomplished this week.
Nothing, tons of homework right now

3) Links to anything you’ve done this week:
4) What you plan to do next week.
Fix and land
Write up plan for faster rbt post -u.

5) What, if anything, is blocking you from making progress?
N/A

6) Any other questions
N/A

[Open Academy] Status Reports March 2-8

Tran Nguyen

1. What project are you working on?
Adding pre_post_hook
2. What you accomplished this week.
Added the pre_post_hook in .reviewboardrc of rbtools with command
“pyflakes .”, and check self.config for the string
rbtools/commands/post.py to see if the string exists. Able to execute
the command using subshell.
STILL making fixed based on mentors’ comments on uncommitted flag.
3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/6879/
4. What you plan to do next week.
Pushed up my initial draft for pre_post_hook.
5. What, if anything, is blocking you from making progress?
So I think for my uncommitted flag, there are some mix comments between
mentors on how I should specify the uncommitted flag option. I think
either way works fine for me, and I find myself going back and forth
editing cosmetic issues. I know it’s for maintenance purposes but it
doesn’t help me learn a whole lot by fixing those issues.
6. Any other questions.
Nope.


Jessica Qian

1. What project are you working on?
‘Trivial’ publishes
2. What you accomplished this week.
I posted my WIP on RR for trivial review requests.
I finished fixing backend methods for trivial reviews.
3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem
https://reviews.reviewboard.org/r/7022/
4. What you plan to do next week.
I am currently stuck on sending the value of “trivial” from the checkbox to the update method for trivial review requests, so I will work on that.
5. What, if anything, is blocking you from making progress?
A lot of operations happens when you click the Publish button. I’ve been trying to understand how I can pass the trivial parameter for a couple weeks now, but it’s very complicated…
6. Any other questions.
None


Xuanyi Lin

1. What project are you working on?
Framework and UI for integrating with third-party services
2. What you accomplished this week.
Learn about Backbone
Implemented the basic structure for integrations admin page.
3. Links to anything you’ve done week
Part 1: https://reviews.reviewboard.org/r/6918/
[WIP] Part 2 integrations admin page: https://reviews.reviewboard.org/r/7034/
https://reviewboard.hackpad.com/Xuanyis-notes-R9JtPE1o279
4. What you plan to do next week.
Implement the views for managing all integrations and individual configured integrations.
5. What, if anything, is blocking you from making progress?
Nothing.
6. Any other questions.
Nope.


Wu Di

1. What project are you working on?
Better Diff Comment Bubbles
2. What you accomplished this week.
Studied Stanley’s project on making the image comments movable and resizable, currently still attempting to get the diff bubbles to be resizable.
Added css vulnerabilities testing to part 1 of the project.
Updated part 2 of the project based on Barret’s comments on hover behaviour.
3. Links to anything you’ve done week
Part 1: https://reviews.reviewboard.org/r/6932/
Part 2: https://reviews.reviewboard.org/r/6970/
Part 3 [WIP]: https://reviews.reviewboard.org/r/7032/
4. What you plan to do next week.
Continue working on the resizing of the diff comment bubbles.
5. What, if anything, is blocking you from making progress?
Nothing.
6. Any other questions.
Currently i’m modifying the textBasedCommentBlockView to handle the mousedown and mouseup events in order to perform the resizing, I’m able to detect the new $beginRow and $endRow but I’m not sure of how to get the view to update them.


Rohan Meringenti

1. What project are you working on?
Highlight Active Issues
2. What you accomplished this week.
Got the backend working properly, which is modeled in the front end as well!
3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7008/
4. What you plan to do next week.
Make the front end changes pretty, so user’s have an easier time noticing changes
5. What, if anything, is blocking you from making progress?
Nothing for now, I’ll be done with this project this week most likely, so I’ll likely start tackling something new.
6. Any other questions.
nope.


Teresa Fan

1. What project are you working on?
Interactive Issue Summaries
2. What you accomplished this week.
Got the fix/drop buttons to display properly!
3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Teresas-Notes-gI6ljBKu7ra
https://reviews.reviewboard.org/r/6997/
4. What you plan to do next week.
Get the buttons to actually work, I haven’t properly hooked them up with the commentManagerModel.
5. What, if anything, is blocking you from making progress?
Nothing for now, although if anyone has time to look over my review request and give me feedback on what I have so far, that’d be great (I just want to make sure I’m going in the right direction and don’t waste more time on something that I should actually be going about a different way).
6. Any other questions.
I second Stanley’s question, I also have spring break this week so I wasn’t sure if I still have to work or not (I might still work a little anyway, but perhaps not devote as much time as usual).


Sun Wang Jun

1. What project are you working on?
Checklist extension
2. What you accomplished this week.
Submitted first part of project for review, and updated the review after comments
3. Links to anything you’ve done week
https://reviewboard.hackpad.com/2015-Checklist-Extension-oLIpxP1SzyX
https://reviews.reviewboard.org/r/6969
4. What you plan to do next week.
Split current review request into two
Begin work on templates
5. What, if anything, is blocking you from making progress?
Nothing
6. Any other questions
Nope


Chenxi Ni

1) What project are you working on?
Changing Review Request Ownership
2) What you accomplished this week.
Fix the bug I encounted when echo the ‘submitter’ on the UI
Add submitter information when the information in a ReviewRequestDraft is dumped into the ReviewRequest model
Make changed field shows correctly after publish.
3) Links to anything you’ve done this week (hackpads, review requests, blog posts, etc)
My WIP RR for my feature: https://reviews.reviewboard.org/r/6990/
My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP
4) What you plan to do next week.
Add tests and maybe fix some details of my project.
5) What, if anything, is blocking you from making progress?
Not yet.
6) Any other questions
I have accomplish the main functions of my project(That is, I can modify submitter now). I guess there some more I should do.
1.Should I add some notifications to users before they publish with different submitter?
2.What kind of tests should I add?


Stanley Yeo

1. What project are you working on?
Improve Review Bot’s admin interface
2. What you accomplished this week.
Updated RRs
Wrote comments
3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Stanleys-Note-y91i8NygfSk
https://reviews.reviewboard.org/r/6999/
4. What you plan to do next week.
Fix bugs, if nay.
Update RRs, based on feedback.
5. What, if anything, is blocking you from making progress?
anselina and smacleod seemed pretty busy this week. So, I couldn’t get any feedback/review for my RR.
6. Any other questions.
Wonder what to do while waiting for review.
CMU has spring break this week, and I wonder if I can skip working this week.


Mingyi Chen

1. What project are you working on?
Add infinite scrolling to the diff viewer
2. What you accomplished this week.
Infinite Scrolling but have sth wrong
3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY
4. What you plan to do next week.
Fix the bugs. Add post it!
5. What, if anything, is blocking you from making progress?
Is it better to get the diff data once or several times from pages.
6. Any other questions.
N/A