[Open Academy] Status Reports, April 18, 2015

Mingyi Chen

1. What project are you working on?

  • Add infinite scrolling to the diff viewer
  • Read-only site mode

2. What you accomplished this week

  • Read the code, find how many should be stopped.
  • Add a button to stop admin settings.

3. Links to anything you’ve done this week
https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY

4. What you plan to do next week

Add a notice bar to the whole website.

5. What, if anything, is blocking you from making progress?

How many functions do review board have, and how many should be stopped.

6. Any other questions?

The previous project is still waiting for review!


Sihang Chen

1. What project are you working on?

Add the unreviewed section to my dashboard.

2. What you accomplished this week

Finish the counting function of the incoming unreviewed review requests.

3. Links to anything you’ve done this week
https://reviews.reviewboard.org/r/7193/

4. What you plan to do next week

Done some tests and change the codes.

5. What, if anything, is blocking you from making progress?

No.

6. Any other questions?

Nope, will ask on Slack if I have.


Teresa Fan

1. What project are you working on?

Interactive Issue Summaries

2. What you accomplished this week

Fixed up my code based on review comments (and solved some git issues).

3. Links to anything you’ve done this week

4. What you plan to do next week

Continue working on that review request until it’s ready to be shipped.

5. What, if anything, is blocking you from making progress?

More reviews are welcome! Also, see below

6. Any other questions?

What would be best for me to do next, considering I only have a couple weeks left in my semester?


Sun Wang Jun

1. What project are you working on?

Checklist extension

2. What you accomplished this week

Fixed trivial issues raised in my review requests

3. Links to anything you’ve done this week

4. What you plan to do next week

Clear the remaining issues raised

5. What, if anything, is blocking you from making progress?

Projects and exams

6. Any other questions?


Wu Di

1. What project are you working on?

  • Better diff comment bubbles
  • Allow replying to reviews from the diffviewer

2. What you accomplished this week

Relooked at jQuery’s draggable and resizable following Christian’s comments in my review, but still found it unsuitable for moving and resizing the comment bubbles.

3. Links to anything you’ve done this week
https://reviewboard.hackpad.com/Wu-Dis-Notes-sULvWjtXN56

4. What you plan to do next week

Fix outstanding issues in my review request.

5. What, if anything, is blocking you from making progress?

Projects and exams.

6. Any other questions?


Xuanyi Lin

1. What project are you working on?

Framework and UI for integrating with third-party services

2. What you accomplished this week

  • Fixed issues in my reviews
  • Add Config template to integration forms
  • Implement Rbslack with integration framework

3. Links to anything you’ve done this week

4. What you plan to do next week

Fix issues for my reviews.

5. What, if anything, is blocking you from making progress?

6. Any other questions?


Feng Chen

1. What project are you working on?

Create a new plugin

2. What you accomplished this week

Download Review Bot and find the direction to write the plugin.

3. Links to anything you’ve done this week

4. What you plan to do next week

Complete the project.

5. What, if anything, is blocking you from making progress?

Basketball Competition and my course.

6. Any other questions?


Chenxi Ni

1. What project are you working on?

OAuth2 provider support

2. What you accomplished this week

Set the environment of OAuth2

3. Links to anything you’ve done this week
https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP

4. What you plan to do next week

Try to submit a WIP review for my project. Write basic code such as adding models to Django.

5. What, if anything, is blocking you from making progress?

No

6. Any other questions?

Not yet


Stanley Yeo

1. What project are you working on?

Auto-add users to groups

2. What you accomplished this week

  • Implement signal handlers to add newly registered user to global default groups
  • Fix issues in previous RR
  • Write test codes
  • Update RR (soon)

3. Links to anything you’ve done this week
https://reviews.reviewboard.org/r/7165/

4. What you plan to do next week

  • Update RR
  • Write tests
  • Finish previous RRs

5. What, if anything, is blocking you from making progress?

6. Any other questions?


Rohan Meringenti

1. What project are you working on?

Revokable Ship its / Looking for new quick project

2. What you accomplished this week

  • Updating RR soon
  • Written tests
  • Made changes in accordance to reviews

3. Links to anything you’ve done this week

I’ll update the https://reviews.reviewboard.org/r/7170/ today or tomorrow.

4. What you plan to do next week

Pick up a new quick project and start it

5. What, if anything, is blocking you from making progress?

No. Just some tests right now, so i’ll be a day or too late in updating my RR

6. Any other questions?


Jifei Wen

1. What project are you working on?

pep257 && shellcheck

2. What you accomplished this week

fix bug in pep257 && shellcheck

3. Links to anything you’ve done this week

4. What you plan to do next week

there is someting wrong at shellcheck and i will try again

5. What, if anything, is blocking you from making progress?

6. Any other questions?

[Open Academy] Status reports – March 28th, 2015


Sihang Chen

1. What project are you working on?
Add the unreviewed section to the dashboard.
2. What you accomplished this week:
Actually, I’ve been busy preparing some documents for a competition, so I’ve got little time to do the reviewboard thing, and all I’ve done was to try to figure out how to automatically add the two additional columns in the database when building the project automatically.
3. Links to anything you’ve done this week:
No update to my hacked, the links to last week:
https://reviewboard.hackpad.com/Chen-Sihangs-Notes-1t6Ki8onOzy
4. What you plan to do next week:
Next week I’ll have more time and try to work out the database thing.
5. What, if anything, is blocking you from making progress?
I still have the school work to do and another project to work on, but I’ll accomplish what I’m supposed to finish for review board, that’s for sure.
6. Any other questions?
No, if any, I’ll ask on Slack.


Teresa Fan

1. What project are you working on?
Interactive Issue Summaries

2. What you accomplished this week.
Fixed a minor bug where the button divs where rendering in two places (although one was left empty).
Investigated why buttons are disabled when an issue is reopened (see #4).

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/6997/
https://reviewboard.hackpad.com/Teresas-Notes-gI6ljBKu7ra

4. What you plan to do next week.
Still working on the bug where when an issue is reopened after it was dropped/fixed in-table, the button bar doesn’t reappear correctly in the table (they appear disabled).

5. What, if anything, is blocking you from making progress?
The bug mentioned above, but I’ll put a little more time into it before I really say I’m stuck.

6. Any other questions.
I think the problem is that I have 2 separate commentIssueBars, one that I made for the table and the other that was existing for the place in the actual review. How do I get my new bar to “listen” to the other bar so that it properly updates the in-table status to “open” when it’s reopened from outside the table?


Jessica Qian

1. What project are you working on?
“Trivial” publishes

2. What you accomplished this week.
Recorded the demo.
Finished backend for trivial reviews.

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7022/
https://reviews.reviewboard.org/r/7125/
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem

4. What you plan to do next week.
I will work on frontend for trivial reviews if the UI details get sorted out. Otherwise, I will choose a bug fix to work on.

5. What, if anything, is blocking you from making progress?
I didn’t know my project was for trivial review requests only, so I already set up the backend for trivial reviews. However, the UI details for trivial reviews is undetermined…

6. Any other questions.
None.


Mingyi

1. What project are you working on?
Add infinite scrolling to the diff viewer

2. What you accomplished this week.
Record the video
Push release on the review board.

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7047/
https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY

4. What you plan to do next week.
Waiting for evaluation. And try to make it better.

5. What, if anything, is blocking you from making progress?
No.

6. Any other questions.
Waiting now ~:)


Chenxi

1) What project are you working on?
Changing Review Request Ownership

2) What you accomplished this week.
add all tests.
now correcting code by comments

3) Links to anything you’ve done this week (hackpads, review requests,
blog posts, etc)
My WIP RR for my feature: https://reviews.reviewboard.org/r/6990/
My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP

4) What you plan to do next week.
Finish the project and find another.

5) What, if anything, is blocking you from making progress?
No.

6) Any other questions
Not yet.


Sun Wang Jun

1. What project are you working on?
Checklist extension (integrating templates)

2. What you accomplished this week.
Video demo.
Fixed a bug and improved UI for stuff in current review requests.

3. Links to anything you’ve done week
https://reviewboard.hackpad.com/2015-Checklist-Extension-oLIpxP1SzyX#:h=Integration
https://drive.google.com/file/d/0ByHWCSTdXEMLMkFHUUlWbWxqeWs/view

4. What you plan to do next week.
Most probably re-working the checklist from ground up to support templates

5. What, if anything, is blocking you from making progress?
Contemplating whether to just modify the existing code or to re-design checklists

6. Any other questions.
What are the things we should look out for before pressing Ship It for others’ review requests, assuming we are allowed to do so?


Jifei

1. What project are you working on?

PEP257 ReviewBot tool
2. What you accomplished this week:

PEP257 ReviewBot tool
3. Links to anything you’ve done this week:

https://reviews.reviewboard.org/r/7101/
4. What you plan to do next week:

complete the docstring and perfect the PEP257
5. What, if anything, is blocking you from making progress?

None

6. Any other questions?

i can not find the entry point at `reviewbot.tool`


Rohan Meringenti

1. What project are you working on?
Revokable Ship its

2. What you accomplished this week.
Finished Backend of removable ship its
Working on unit tests

3. Links to anything you’ve done week
Nothing right now, Updating with demo video later today.

4. What you plan to do next week.
Update ship it counter and republish the page after the ship it model changes

5. What, if anything, is blocking you from making progress?
I posted this in #students last night, but I was confused as to what .publish() method does. I need the page to refresh
after the model is loaded. I was looking at how the ship it button worked here,(this calls the publish method), but im not sure how
to replicate the reload.

6. Any other questions.
nope.


xuanyi

1. What project are you working on?
Framework and UI for integrating with third-party services

2. What you accomplished this week.
Added Webapi Resource test
Implemented integration form
Updated Integration class

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/6918/
https://reviews.reviewboard.org/r/7105/
https://reviews.reviewboard.org/r/7106/
https://reviews.reviewboard.org/r/7136/ [WIP]

4. What you plan to do next week.
Continue to work on integration form and config template

5. What, if anything, is blocking you from making progress?
Will be great to have some feedback for my previous RR so that I could improve on it.

6. Any other questions.
Currently, I am trying to make use of the IntegrationForm(a subclass of SiteSettingsForm) to provide the form field for changing the description of an ConfiguredIntegration in the configure page. However, the description field exist as a model field rather than within the json field of the model, so I will need to update them differently. Is there any better way of doing this?


wudi

1. What project are you working on?
Allow replying to reviews from the diffviewer

2. What you accomplished this week:
Haven’t made much progress this week, I was reading up the codebase on how the components talk together to create a review reply.
Got the reviews panel in the comment editor dialog to display the rendered comment and reply hierarchy.
Fixed a bug in my review request after updating with the changes in master.

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/7032/
https://reviewboard.hackpad.com/Wu-Dis-Notes-sULvWjtXN56

4. What you plan to do next week:
I have a rough idea of how to simplify the current UI design based on Christian’s reply, will proceed with it for now and see how it turns out. I’ll try to get a working prototype of the review reply editor by end of the week.

5. What, if anything, is blocking you from making progress?
None.

6. Any other questions?
No.


Viet-Tran Nguyen

1. What project are you working on?
– uncommitted flag and pre-post hook
2. What you accomplished this week?
– just come back from spring break, so minor bugs fix from the above features.
3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/6879/
https://reviews.reviewboard.org/r/7066/

4. What you plan to do next week:
Finishing up the left over comments for these two features and move on to something new.

5. What, if anything, is blocking you from making progress?
None.

6. Any other questions?
No.


Zhiyu

1. What project are you working on?
Add per-user Default reviewer setting.

2. What you accomplished this week:
//Read the code of the api-token function ui and web-api.
Add a simple list (ui) for my new feature.
Try to provide a web api for it.

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/Zhiyus-Notes-WLFl1aHM4fE
It will be updated tomorrow.
The diff which has not uploaded yet will be uploaded to reviewboard after my finishing it in general。

4. What you plan to do next week:
To finish it.

5. What, if anything, is blocking you from making progress?
No

6. Any other questions?
No‍


Stanley Yeo

1. What project are you working on?
Auto-add users to groups

2. What you accomplished this week:
update RRs
understand local_site
understand signal

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/6999/
https://reviewboard.hackpad.com/Stanleys-Note-y91i8NygfSk

4. What you plan to do next week:
Implement signal handlers, and test.

5. What, if anything, is blocking you from making progress?
I’ve been busy due to midterm exams :(

6. Any other questions?
No

[Open Academy] Status reports – April 11th, 2015


Tran Nguyen

1.What project are you working on?
Extension framework testing

2. What you accomplished this week.
Discuss with Christian what needs to be done, start looking at extension
manager, install rbtmod extension and trace point

3. Links to anything you’ve done week:
Nothing new except the two pending CR
https://reviews.reviewboard.org/r/6879/
https://reviews.reviewboard.org/r/7066/

4. What you plan to do next week.
Gather the remaining knowledge to start implementing extension testing
framework

5. What, if anything, is blocking you from making progress?
Nothing yet, I will ask on Slack.

6. Any other questions.
Nope.



Teresa Fan

1.What project are you working on?

Interactive Issue Summaries

2.What you accomplished this week.

Finally fixed my bug so that now issue statuses update in both places correctly regardless of where you update them.

Wrote tests for this.

3.Links to anything you’ve done week

https://reviews.reviewboard.org/r/6997/

https://reviewboard.hackpad.com/Teresas-Notes-gI6ljBKu7ra

4.What you plan to do next week.

Next steps originally included adding a link with the number of replies that brought you to the comment, but maybe that’s not necessary anymore since we have the ‘See comment’ link. I also thought about making the cell expand on hover instead of click.

5.What, if anything, is blocking you from making progress?

If anyone could review my code that’d be great!

6.Any other questions.

Asking in Slack about git problems. See #4 for questions about what would be best to do next.



Rohan Meringenti

1.What project are you working on?

Revokable Ship it Labels

2.What you accomplished this week.

Finallly fixed my bug with the event listeners. You can now see the changes immediately on the page. Furthermore, the ship it counter has also been updated for the review request.

3.Links to anything you’ve done week

https://reviews.reviewboard.org/r/7170/

4.What you plan to do next week.

Finish style, add tests. and pick a new task

5.What, if anything, is blocking you from making progress?

If someone could look at my WIP that would be great. All the big changes are already there, I just have to add style and tests now.

6.Any other questions.

Nope



Chen Feng

1.What project are you working on?

Create a new plugin.

2.What you accomplished this week.

reset my environment, and fixed a bug.

3.Links to anything you’ve done week

https://reviews.reviewboard.org/r/7191/

https://reviewboard.hackpad.com/Fengs-Note-lHTmrx16YQd

4.What you plan to do next week.

Download Review Bot. Write my project.

5.What, if anything, is blocking you from making progress?

NO

6.Any other questions.

No~ if have, I’ll ask it in slack.



Sihang Chen

  1. What project are you working on?

Add unreviewed section to dashboard.

  1. What you accomplished this week.

Accomplish the function to show the unreviewed review requests, and the count number of outgoing unreviewed review requests, but still not many tests.

  1. Links to anything you’ve done week

hackpad: https://reviewboard.hackpad.com/Chen-Sihangs-Notes-1t6Ki8onOzy

reviewboard_reviewrequests: https://reviews.reviewboard.org/r/7193/

  1. What you plan to do next week.

Continue working on the incoming count number.

  1. What, if anything, is blocking you from making progress?

School work of my own.

  1. Any other questions.

Not yet, but please review my review requests at the link above, thank you so much ^_^.



Chen Mingyi

  1. What project are you working on?

Add infinite scrolling to the diff viewer

Read-only site mode

  1. What you accomplished this week.

Fix issues and start a new project.

  1. Links to anything you’ve done week

https://reviews.reviewboard.org/r/7047/

https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY

  1. What you plan to do next week.

To stop some actions.

  1. What, if anything, is blocking you from making progress?

How many functions do review board have, and how many should be stopped.

  1. Any other questions.

The previous project is still waiting for review!



Chenxi Ni

1) What project are you working on?
OAuth2 provider support

2) What you accomplished this week.

looking into how OAuth2 works and follow the tutorial and try
3) Links to anything you’ve done this week (hackpads, review requests,
blog posts, etc)

My RR for my first project:  https://reviews.reviewboard.org/r/6990/

My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP
4) What you plan to do next week.

according to the tutorial to list what should be done and write more basic code.
5) What, if anything, is blocking you from making progress?

No.
6) Any other questions

Not yet.



Sun Wang Jun

  1. What project are you working on?

Checklist extension (templates)

  1. What you accomplished this week.

Refactored the checklist code base and updated the review request

  1. Links to anything you’ve done week

https://reviews.reviewboard.org/r/7176/

  1. What you plan to do next week.

Code the ui for templates

  1. What, if anything, is blocking you from making progress?

School projects

  1. Any other questions.

No



Stanley Yeo

  1. What project are you working on?

Improve Review Bot’s admin interface

Auto-add users to groups

  1. What you accomplished this week.

Wrote some documentation.

Test functionalities.

Update RR.

  1. Links to anything you’ve done week

https://reviews.reviewboard.org/r/7176/

  1. What you plan to do next week.

https://reviews.reviewboard.org/r/7165/

  1. What, if anything, is blocking you from making progress?

None

  1. Any other questions.

Please review 6998, 6999, 7165



Xuanyi

  1. What project are you working on?

Framework and UI for integrating with third-party services

  1. What you accomplished this week.

Update review request

Implement basic RBslack with integration.

  1. Links to anything you’ve done week

https://reviews.reviewboard.org/r/7105/

https://reviews.reviewboard.org/r/7136/

  1. What you plan to do next week.

Continue to work on integration form and rbslack with integration

  1. What, if anything, is blocking you from making progress?

Some questions on one of my review: https://reviews.reviewboard.org/r/6918/

School projects.

  1. Any other questions.

The rbslack integration could potentially be use to target specific group/user. However, will it be possible for subclass of SiteSettingForm to support autocomplete?



Jifei Wen

1.   What project are you working on?
reviewbot plugin PEP257 and shellcheck

2.   What you accomplished this week.
PEP257: fix bug and modify docstring shellcheck: write it

3. Links to anything you’ve done week:

https://reviews.reviewboard.org/r/7101/

https://reviews.reviewboard.org/r/7197/

4. What you plan to do next week.

modify both plugins

5. What, if anything, is blocking you from making progress?
no, i will ask at slack or reviews

6. Any other questions.
No.



Wu Di

1. What project are you working on? 
Allow replying to reviews from the diffviewer

2. What you accomplished this week. 
Got the updating of draft review replies and making new review replies to work properly.

Added in styling for the review reply editor.

3. Links to anything you’ve done week: 
https://reviews.reviewboard.org/r/7172/

4. What you plan to do next week. 
Continue working on getting the comment blocks to update its serialized comments upon adding or updating replies.

5. What, if anything, is blocking you from making progress? 
Would appreciate feedback on the current UI. (https://reviews.reviewboard.org/r/7172/file/891/)

Also, some reviews for my other two review request would be nice, https://reviews.reviewboard.org/r/6970 and https://reviews.reviewboard.org/r/7032.

I will be busy with my other school projects this week.

  1. Any other questions. 

Is there a good way to publish the review reply from the diffviewer? Christian suggested a while back to have a banner at the top of the page, similar to the draft review banner, but that would be confusing.

Or is it even a good idea to allow publishing/discarding of review replies in the diffviewer when the other replies of the review reply cannot be seen?

For example, you have an incomplete body top reply along with a diff comment reply, publishing the review reply will make both replies public, which is bad.

I think it isn’t very obvious that review replies are basically reviews where you make a bunch of replies to the body top/diff/file attachment comments of another review, this might cause users to publish a review reply thinking that they are only publishing one diff comment reply instead of all the other replies in the review reply.



Jessica Qian

1.What project are you working on?

“Trivial” reviews
2. What you accomplished this week.
I was working a separate presentation for this class.

I reviewed possible projects / bugfixes that I’m interested in.
3. Links to anything you’ve done week:
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem
https://reviews.reviewboard.org/r/7022/
https://reviews.reviewboard.org/r/7022/

4. What you plan to do next week.
Find time to discuss with a mentor about next plans.

5. What, if anything, is blocking you from making progress?
None.

[Open Academy] Status reports – April 4th, 2015


Mingyi Chen

1. What project are you working on?
Add infinite scrolling to the diff viewer

2. What you accomplished this week.
Fix issues and push release on the review board.

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7047/
https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY

4. What you plan to do next week.
Waiting for evaluation. And try to make it better.
Finish the project, select another:)

5. What, if anything, is blocking you from making progress?
No.

6. Any other questions.
Waiting now ~:)
I have dropped some issues, and post it again.Wait for it~



Rohan Meringenti

1. What project are you working on?
Removable Ship It Links

2. What you accomplished this week.
Got event listeners to listen to events and facilitate loading of page in api resource

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7170/

4. What you plan to do next week.
Add styling for new ship it label
write test cases for several situations in which deleting ship it labels

5. What, if anything, is blocking you from making progress?
None

6. Any other questions.
None



Wu Di

1. What project are you working on?
Allow replying to reviews from the diffviewer

2. What you accomplished this week.
Got one part working, replies can be made to another reply in the comment editor

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7172/

4. What you plan to do next week.
Add styling for the inline editor in the comment editor
Continue working on getting the inline editor to work properly

5. What, if anything, is blocking you from making progress?
None

6. Any other questions.
None



Sun Wang Jun

1. What project are you working on?
Checklist extension (integrating templates)

2. What you accomplished this week:
Began reworking of existing code to integrate templates

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/2015-Checklist-Extension-oLIpxP1SzyX

4. What you plan to do next week:
Finish up reworking of api to allow nested items
Start changing UI to include templates

5. What, if anything, is blocking you from making progress?
Projects for other modules, but should not affect much
Reviews for my requests will be nice: https://reviewboard.hackpad.com/Suns-Notes-CSvDSCiw0Lo#:h=My-Review-Requests-:heart:

6. Any other questions?
Nope



Jessica Qian

1. What project are you working on?
‘Trivial’ publishes

2. What you accomplished this week:
replied to comments on review

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem
https://reviews.reviewboard.org/r/7022/
https://reviews.reviewboard.org/r/7125/

4. What you plan to do next week:
we have poster presentations for this class, so i will mainly be working on that
will also browse for a new project or bug fix and try to get ui details for trivial reviews

5. What, if anything, is blocking you from making progress?
ui details for trivial reviews are unclear

6. Any other questions?
none



Stanley Yeo

1. What project are you working on?
Auto-add users to groups

2. What you accomplished this week.
Demo video
DB migration to add “is_default” field to group
Modify admin setting to show the “is_default” field on admin site
Write signal handler to handle a new user of a local site
Test
Post a Review Request.

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7165/
https://reviewboard.hackpad.com/Stanleys-Note-y91i8NygfSk

4. What you plan to do next week.
Update RR

5. What, if anything, is blocking you from making progress?
None

6. Any other questions.
None



Teresa Fan

1. What project are you working on?
Interactive Issue Summaries

2. What you accomplished this week.
Investigated why buttons are disabled when an issue is reopened (see #4).

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/6997/
https://reviewboard.hackpad.com/Teresas-Notes-gI6ljBKu7ra

4. What you plan to do next week.
Still working on the bug where when an issue is reopened after it was dropped/fixed in-table, the button bar doesn’t reappear correctly in the table (they appear disabled). I have to do my final presentation for the course I’m taking for this at school in 2 weeks, so I’m going to try my best to finish up this project.

5. What, if anything, is blocking you from making progress?
The bug mentioned above.

6. Any other questions.
Asking in Slack.



Tran Nguyen

1. What project are you working on?
Looking for new project

2. What you accomplished this week.
Address comments from old PR.

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/6879/
https://reviews.reviewboard.org/r/7066/

4. What you plan to do next week.
Find a new project

5. What, if anything, is blocking you from making progress?
No comments on my PR.

6. Any other questions.
No.



Xuanyi Lin

1. What project are you working on?
Framework and UI for third-party services

2. What you accomplished this week:
Updating the reviews according to the feedback
Integration forms and config template

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/6918/
https://reviews.reviewboard.org/r/7136/

4. What you plan to do next week:
Continue to work on integration forms and config template
Start to implement a functional integration.

5. What, if anything, is blocking you from making progress?
Removing load method from integration is causing some initialisation issue currently.

6. Any other questions?
Will be asking in the reviews and Slack.



Chenxi Ni

1) What project are you working on?
Changing Review Request Ownership

2) What you accomplished this week.
Finish the project and find Add OAuth2 provider support as next.

3) Links to anything you’ve done this week (hackpads, review requests,
blog posts, etc)
My WIP RR for my feature: https://reviews.reviewboard.org/r/6990/
My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP

4) What you plan to do next week.
look into how OAuth2 works and try to list what should do

5) What, if anything, is blocking you from making progress?
No.

6) Any other questions
Not yet.

[UCOSP] Status Report Mar 28

Vincent Le

1) What project are you working on?

    – FileProvider framework

2) What you accomplished this week.

    – Made changes as suggested by reviews

    – Added a `api/file-providers/` end-point to make API calls to know what file providers are supported

    – Added backbone.js model for file-providers from api calls to `api/file-providers/`. Integrated with the upload modal to use information needed for progression

    – Re-did the design for display of metadata, moving logic to files where needed and display path only for search results.

    – Added search logic to show search results on the options for selection. Search result is displayed after 500ms after the last key up in the search field, or display the current path when search field is white space

    – more variable refactoring as names were missed

    – made some reviews

3) Links to anything you’ve done this week:

    – FileProvider WebApi interaction with file provider account: https://reviews.reviewboard.org/r/6948/

    – [WIP] FileProvider Modal UI for uploads: https://reviews.reviewboard.org/r/7009/

    – FileProvider resource web API for providers: https://reviews.reviewboard.org/r/7124/

    – Reviews: https://reviews.reviewboard.org/users/VTL-Developer/reviews/

4) What you plan to do next week.

    – Clean up and finish r/7009 (test cases, making changes as response to reviews, etc.)

    – Demo Video

5) What, if anything, is blocking you from making progress?

    – N/A

6) Any other questions

    – N/A

Tien Vu

1. What project are you working on?

Diff Doctor

2. What you accomplished this week.

– Not sure what else to do for my 2 projects, so I went around for code reviews and bug fixing instead

3. Links to anything you’ve done:

https://reviews.reviewboard.org/r/6833/

https://reviews.reviewboard.org/r/6993/

Code reviews:

https://reviews.reviewboard.org/r/6879/

https://reviews.reviewboard.org/r/7066/

Learned about git hooks: http://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks

and fixed the bug at https://code.google.com/p/reviewboard/issues/detail?id=3824. Review request link:

https://reviews.reviewboard.org/r/7129/

4. What you plan to do next week.

– I need some direction here. What should I do?

5. What, if anything, is blocking you from making progress?

– What should I do if patching fails to something outside the patch() function (that throws a PatchError)? Like an SCMError.

– What else do I have to do to land my projects?

No luck with reproducing these bugs:

https://code.google.com/p/reviewboard/issues/detail?id=3108

https://code.google.com/p/reviewboard/issues/detail?id=3421

https://code.google.com/p/reviewboard/issues/detail?id=3687

6. Any other questions.

– No

Jessica Yuen

1. What project are you working on?

  • rb-gateway

2. What you accomplished this week.

  • Unit testing for all rb-gateway API’s, testing:
    • /repos/{repo}/file{id}, GET, HEAD
    • /repos/{repo}/commits/{id}/path/{path}, GET, HEAD
    • /repos/{repo}/path, GET
    • /repos/{repo}/branches, GET
    • /repos/{repo}/branches/{name}/commits, GET
    • /repos/{repo}/commits/{id}, GET
    • /session, GET
  • Minor fix to return 30 commits vs 20, to align with GitHub API, landed.
  • Addressed issues with 7053, landed

3. Links to anything you’ve done week:

4. What you plan to do next week.

  • Demo video
  • Reviews
  • Address any reviews on outstanding review request, 7134, get it landed.

5. What, if anything, is blocking you from making progress?

  • N/A

6. Any other questions.

  • Nope


Chester Li

1) What project are you working on?

  • Bug fixing and code reviewing

2) What you accomplished this week.

  • Landed the main project.
  • Reviewed code changes.
  • [WIP] bug fixing.

3) Links to anything you’ve done this week:

4) What you plan to do next week.

  • Recorded the demo and hopefully fixed issue 3811

5) What, if anything, is blocking you from making progress?

  • Was overwhelmed by other projects and homework

6) Any other questions

  • N / A


Christopher Arnold

1) What project are you working on?

  • Mute and Archive Review Requests

2) What you accomplished this week.

  • split up project into smaller review requests
  • finished automatic unarchiving
  • fixed URL query
  • finished ReviewRequestVisitTests in accounts.models
  • finished test_show_archived in datagrids.grids
  • wrote most of test_archived_review_request for the webapi
  • wrote most of reviewRequestEditorViewTests in static.rb.js.views

3) Links to anything you’ve done this week:

4) What you plan to do next week.

  • fix the last two tests mentioned above
  • video demo
  • polish documentation
  • do some reviews

5) What, if anything, is blocking you from making progress?

  • test_archived_review_request for the webapi: https://reviews.reviewboard.org/r/7087/diff/7/#6
    • I’m getting the same error for 3 of the DELETE tests: AssertionError: u’A’ != u’V’
    • When I print the visibility in the actual delete function, it is as expected (‘V’), but for some reason doesn’t show up like that in the test
  • I actually break 4 of the original tests (all similar) with my patch, can’t figure out how to fix my code
    • error is with setStarred: Expected spy success to have been called
      • on lines 46 and 65 of reviewGroupModelTests
      • and on lines 167 and 187 of reviewRequestModelTests
    • I think it has to do with how I implement addImmediately and removeImmediately when adding the trigger.

6) Any other questions

  • How complete is my project looking? Any more tests I should do?
  • Super stuck for a while now on the things I mentioned above, so I would appreciate any help :) Thank you!


Jason Tseng

1. What project are you working on?

Responsive UI

2. What you accomplished this week.

– Updates on part 1 and rebased through the rest

– secondary menu button design

3. Links to anything you’ve done week:

– https://reviews.reviewboard.org/r/6796

– https://reviews.reviewboard.org/r/6923/

4. What you plan to do next week.

– Demo

– Minor bug fixes

5. What, if anything, is blocking you from making progress?

– n/a

6. Any other questions.

– Nope.

[Open Academy] Status Reports, March 21st


Rohan Meringenti

1. What project are you working on?
Highlighting Active Issues

2. What you accomplished this week:
Finished up front end and made changes as suggested by David for style

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/7008/ Highlighting active issues review request

4. What you plan to do next week:
Work on revokable ship-it labels, have both frontend and backend completed as well as webapi updated

5. What, if anything, is blocking you from making progress?
Nothing

6. Any other questions?
Nope


Sun Wang Jun

1. What project are you working on?
Checklist extension (templates)

2. What you accomplished this week:
Finished up initial part of checklist templates for account pages
Fixed an issue that caused the extension to be hidden after it reloads
Minor code reviews here and there

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/7099/ initial checklist templates implementation
https://reviews.reviewboard.org/r/7103/ review request for extension account page issue

4. What you plan to do next week:
Integrate templates into the existing checklist
Improve on the API related code for the existing checklist

5. What, if anything, is blocking you from making progress?
https://reviews.reviewboard.org/r/6969/ needs reviews so as to facilitate what I plan to do next week

6. Any other questions?
How would extensions use translations?


Zhiyu Xia

1. What project are you working on?
Add per-user Default reviewer setting

2. What you accomplished this week:
Change the setting page of global dafualt reviewers and
Do something about per-user setting

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/Zhiyus-Notes-WLFl1aHM4fE
The diff may be uploaded to reviewboard next week

4. What you plan to do next week:
Finished the per-user setting page about default reviewers.

5. What, if anything, is blocking you from making progress?
to design the per-user setting view.

6. Any other questions?
No


Teresa Fan

1. What project are you working on?
Interactive Issue Summaries

2. What you accomplished this week.
Got the fix/drop buttons in the issue summary table to successfully change the status of issues!

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/6997/
https://reviewboard.hackpad.com/Teresas-Notes-gI6ljBKu7ra

4. What you plan to do next week.
Figure out why when an issue is reopened, the button bar doesn’t reappear correctly in the table.

5. What, if anything, is blocking you from making progress?
Nothing for now, I haven’t gotten the chance to investigate what the reason might be yet.

6. Any other questions.
When creating a CommentIssueBarView, why are the reviewID and commentID fields supposed to be the same? The names are misleading–I had thought the reviewID field should be the actual ID of the review instead of just the same as the comment ID, which was the source of my bug from last week. Or am I mistaken about what the review/comment IDs mean?


Mingyi Chen

1. What project are you working on?
Add infinite scrolling to the diff viewer

2. What you accomplished this week.
Accomplish the infinite scroll and fix all the bugs it appears.
Upload to the rb.

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7047/
https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY

4. What you plan to do next week.
Learn about the the javascript memory management. And try to reduce the memory usage.

5. What, if anything, is blocking you from making progress?
Current loading framework is not easy to do the memory management.

6. Any other questions.
How to test what I’ve done(infinite scroll) is correct.


Wu Di

1. What project are you working on?
Better Diff Comment Bubbles
I’m currently extending the project to allow replying to reviews from the diffviewer page.

2. What you accomplished this week:
Fixed issues in current review requests.
Did some code reviews.
Came up with specification and mockup for the replying to reviews project

3. Links to anything you’ve done this week:
Mockup and specification: https://reviewboard.hackpad.com/Wu-Dis-Notes-sULvWjtXN56#:h=Allow-replying-to-reviews-from

4. What you plan to do next week:
If there are no problems with the specification, I’ll proceed with this project and get the comment dialog to display the fully rendered reviews properly.

5. What, if anything, is blocking you from making progress?
I picked this project from the Ideas without sufficient definition section of the student project ideas page. Before I proceed, can the mentors have a look to make sure that the specification that I came up with are correct?

6. Any other questions?
None for now.


Chen Sihang

1. What project are you working on?
Add Unreviewed section in the Dashboard.

2. What you accomplished this week.
Accomplish the front-end view part which is to add the two unreviewed section in the dashboard sidebar.

3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Chen-Sihangs-Notes-1t6Ki8onOzy

4. What you plan to do next week.
Continue working on the function of the unreviewed thing.

5. What, if anything, is blocking you from making progress?
Understand the structure of the project.

6. Any other questions.
No.


Jessica Qian

1. What project are you working on?
“Trivial” publishes

2. What you accomplished this week:
I did not do much this week because of midterms.

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/7022
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem

4. What you plan to do next week:
I will make final edits to backend methods for trivial reviews, and start frontend edits.

5. What, if anything, is blocking you from making progress?
​None​


Stanley Yeo

1. What project are you working on?
Add OAuth2 provider support

2. What you accomplished this week:
Updated RRs.
Studied OAuth2.
Researched OAuth2-django libraries.

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/Stanleys-Note-y91i8NygfSk
https://reviews.reviewboard.org/r/6999/

4. What you plan to do next week:
Understand studying OAuth
Pick on or two libraries to try with reviewboard
Start Implementing

5. What, if anything, is blocking you from making progress?
None

6. Any other questions?
None


Ni Chenxi

1) What project are you working on?
Changing Review Request Ownership

2) What you accomplished this week.
[WIP] adding tests. I’ve add some tests about the front end and try to add some about backend.

3) Links to anything you’ve done this week (hackpads, review requests,
blog posts, etc)
My WIP RR for my feature: https://reviews.reviewboard.org/r/6990/
My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP

4) What you plan to do next week.
Finish the tests.

5) What, if anything, is blocking you from making progress?
How can I test whether a user that is not the current submitter change the submitter?

6) Any other questions
Not yet.


Lin Xuanyi

1. What project are you working on?
Framework and UI for integrating with third-party services

2. What you accomplished this week:
Iterate on the design for the UI admin page.
Added permissions to both model and admin page.
Integrate the backbone model with the WebApi resource.
Writing test for the webapi resource.
Split the review for part 2.

3. Links to anything you’ve done this week:
Integration model: https://reviews.reviewboard.org/r/6918/
WebApi resource for Integration: https://reviews.reviewboard.org/r/7105/
Integration admin page(Backbone): https://reviews.reviewboard.org/r/7106/

4. What you plan to do next week:
Complete the test for part 2.
Write integration form.

5. What, if anything, is blocking you from making progress?
None.

6. Any other questions?
None.


Chen Feng

1) What project are you working on?
Create a new tool plugin.

2) What you accomplished this week.
Nothing. I am working on a project for our trainning lesson. I’ll continue my work this weekend.

3) Links to anything you’ve done this week (hackpads, review requests, blog posts, etc)
Hackpad notes:
https://reviewboard.hackpad.com/Fengs-Note-lHTmrx16YQd

4) What you plan to do next week.
Fixed the bug.

5) What, if anything, is blocking you from making progress?
Not yet.

[UCOSP] Status Reports: March 15th to 21st


Vincent Le

1) What project are you working on?
– FileProvider framework

2) What you accomplished this week.
– Made changes as suggested by Christian and Barret in my reviews
– Added search logic to show search results on the options for selection. Search result is displayed after 500ms after the last key up in the search field, or display the current path when search field is empty.
– Started implementing display metadata for selected files
– Did some small refactoring for my JS file
– Fixed a bug regarding metadata in my test cases and testing class for FileProviders

3) Links to anything you’ve done this week:
– FileProvider module implementation with Django : https://reviews.reviewboard.org/r/6806/
– FileProvider WebApi integraton : https://reviews.reviewboard.org/r/6948/
– [WIP] FileProvider Framework UI : https://reviews.reviewboard.org/r/7009/

4) What you plan to do next week.
– Finish display metadata
– Make my file navigation for FileProvider modal compatibile with any provider
– Get to create accounts

5) What, if anything, is blocking you from making progress?
– Nothing I can think of yet

6) Any other questions
– Nothing I can think of yet


Chester Li

1) What project are you working on?
  • Post-commit review request support for GitLab


2) What you accomplished this week.
  • Refactored code for 2 review requests according to reviews.
  • One bug fix has been submitted
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Start a new project, do as much as I can
5) What, if anything, is blocking you from making progress?
  • I was basically waiting for the review and did some changes.
6) Any other questions
  • Not yet


Tien Vu

1) What project are you working on?
    – Diff Doctor
2) What you accomplished this week.
    – In summary, replaced failed patch traceback with inline Pygments, as collapsible links. I tried to figure out how to make it like the plus button for a review request change, but I lack the frontend knowledge, so I’m sticking with <a href>.
3) Links to anything you’ve done this week:
    – Learned how to use Pygments: http://pygments.org/docs/
4) What you plan to do next week.
    – Decide what to do when patch fails because of a non PatchError (like SCMError). Right now it just links to a template that displays the error like {{ error.msg }}.
    – After this, is there anything major left to do for my 2 projects? For Diff Doctor, Christian suggested me to skip “step 2″ of analyzing the source problem of failing the patch, but we agreed to skip over this because it’s too complicated for now. The other 2 parts of showing the .zip and showing the reject files instead of the traceback works. Should I pick a smaller project to work on?
5) What, if anything, is blocking you from making progress?
    – How can I land my changes to master? Should I at least push my branch(es) up?
6) Any other questions
    – No


Jessica Yuen

1. What project are you working on?
rb-gateway
2. What you accomplished this week.
Sorry I’ve been a super occupied with other work this week…
– Fixed outstanding issues on existing review requests (7053 & 7054)
– Added unit testing for configuration loading

3. Links to anything you’ve done week:
4. What you plan to do next week.
– Since Pencils Down is a week and half from now, I think I’ll just concentrate on adding any missing test cases, getting rb-gateway to a polished state. I think it’s already pretty complete for the features that have been requested so far, but let me know if I’m wrong.

5. What, if anything, is blocking you from making progress?
– N/A

6. Any other questions.
– Nope.


Chris Arnold

1) What project are you working on?
  • Mute and Archive Review Requests
2) What you accomplished this week.
  • handled automatic unarchiving
  • fixed URL query
  • split up project into smaller review requests
3) Links to anything you’ve done this week:
4) What you plan to do next week
  • attend to several reviews by David and Barret
  • getting used to the workflow of using several review requests that depend on each other
  • tests
5) What, if anything, is blocking you from making progress?
  • the splitting up of my project
6) Any other questions
  • I’ve split up my project, but it’s been trickier than I thought, especially when trying to decide which line of code belongs to which review request… Working on my project seems a lot more fragile now, and my pace has definitely slowed down. It seems like I need to rebase AND rbt post up to 3 branches whenever I want to make a change, since all my review requests rely on each other.
    • Any tips out there that I could use to make this process easier?
    • Is there a slick way to transfer changes from one review request to another?


Jason Tseng

1. What project are you working on?

Responsive UI

2. What you accomplished this week.

– Additional aesthetic update on part 1

– Changes applied to the rest

– half way on secondary menu button design

3. Links to anything you’ve done week:

– https://reviews.reviewboard.org/r/6796

4. What you plan to do next week.

– Finish secondary menu button

5. What, if anything, is blocking you from making progress?

– passing review on part 1

6. Any other questions.

– Nope.