Status Report for June 21st, 2014

Volodymyr

Project name: Reviewing attachments

  • What you accomplished this week.
    • Minor model change that we discussed during the meeting – separate field to denote display position, so that someone in the future might implement reordering.
    • Delete removes previous versions of the attachment as well. Right now I just modified the existing function, but we probably will have two kinds of delete (remove every revision, or just a specific one).
    • Explored codebase associated with ReviewUI. I had difficulties with following the instructions to enable image diffs, but instead I messed with js and managed to see how the image diff UI looks like (only side by side pictures, I didn’t try to get “Onion skin” and other modes working). Started exploring slider implementation.
  • What you plan to do next week.
    • Continue implementing review page for multiple revisions
    • Another iteration on current reviews
  • What, if anything, is blocking you from making progress?
    • So there are 3 different reviewUI classes (Images, text, markdown. I’m not sure about PDF, as reviews.reviewboard.org doesn’t allow reviewing PDF’s). The class that all of them extend is pretty simplistic, so it’s unlikely that I can stick anything useful there. Since I want to either get a slider that allows you to choose revision (or buttons “Next Revision / Previous Revision”, but buttons aren’t elegant), I might have to replicate the behaviour throughout all 3 classes, unless I find a good way to generalize it. I have thought about consequences this might have for existing ReviewUI classes, and don’t think there would be a problem. Review page will still have 1 item at a time, but I’ll also add a capability to specify which revision you want to look at. Once it’s decided to add ReviewUI capabilities, there probably will be a menu on review page, where you get to specify the item to diff against.
    • ^ That’s not really a description of what’s blocking me, but I spent quite a while just browsing through code versus writing it. It’s a bid hard to picture how everything would fit now.
  • Any other questions
    • David: Can you please take another look at https://reviews.reviewboard.org/r/5911/, since you were unlucky to do if before 🙂
    • Is anyone from Waterloo interested in getting together on Thursday / Friday to work on reviewboard, just like we did in Toronto?

Matthew

Project: Extending Review Bot to allow tools to run on the entire repository

  • What you accomplished this week.
    • I added extra information from the extension to the bot
      • base commit id
      • repository name
    • Tested previously written code and fixed bugs to ensure that the repositories were grabbed appropriately
    • Searched to see if I could get the branch information from code in the extension, but it looks like I just have the commit id to work with
  • What you plan to do next week.
    • Update code to code review comments
    • Get repository to specified base commit
  • What, if anything, is blocking you from making progress?
    • I need my code review and hack pad questions answered
  • Any other questions
    • No

Raheman Vaiya

  • What you accomplished this week.
    • Learned a little bit about Django models with an emphasis on the existing FileAttachment model.
    • Explored Djblets to get a better grasp of web resource API
    • Made some model changes (will have review request up soon)
  • What you plan to do next week.
    • Have the necessary changes to the models sorted out and reviewed by the
      end of the week.

     

  • What, if anything, is blocking you from making progress?
    • I am still trying to fully understand the relationship between
      Djblets/Reviewboard API Resources and Django Views. 

     

  • Any other questions
    • No

     

Peter Tran

  • What you accomplished this week.
    • Got the TogetherJS extension working and styled it in ReviewBoard fashion: hackpad here
    • Collected this status report
  • What you plan to do next week.
    • Repoint the default server to one the admin sets up

     

  • What, if anything, is blocking you from making progress?
    • No

     

  • Any other questions
    • No

     

Salam Alyahya

Project: Updating Checklist Extension

  • What you accomplished this week.
    • Iterated couple of times over the style of the extension (html/css), not using tables, to make the extension fit with RB style.
    • Changes the icon buttons on the header of extension to text buttons
    • Moved the textbox input to add a new item to the button of the layout, added a place holder text and button to clear the box
    • On hover each item in the list, the ‘remove’ item icon appears
      I created a hackpad for the project Links to anything you’ve done this week
  • What you plan to do next week.
    • Finish up the style changes
    • Start working on Templates feature for the extension

    What, if anything, is blocking you from making progress?

    • No

     

  • Any other questions
    • No
Advertisements

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s