Meeting Minutes (Sept. 28, 2014)



  • ChipX86 (Christian Hammond)
  • smacleod (Seven MacLeod)
  • heapify (Anselina Chia)
  • purple_cow (David Trowbridge)


  • rdone (Ryan Done)
  • andrewhong (Andrew Hong)
  • asalahli (Azad Salahli)
  • dkus_ (David Kus)
  • nicole_xin (Nicole Xin)
  • justy777 (Justin Maillet)
  • brennie (Barret Rennie)
  • mloyzer (Mark Loyzer)

No announcements

Round robin:


  • All good for now
  • Taking suggestions for visual / CSS changes.



  • Nothing new.


  • Currently working on backend general comment model; hopefully will set it up next week
  • No questions


  • – how do you apply for GSoC and what is the program like?
    • smacleod: Applications done through melange website. There are a number of ogranizations that get accepted and you may write them an applications. Applications are expected to be pretty well through out if you want to be accepted. Generally you should do your homework and get familiar with the project, and then write a proposal for what you’ll do over the summer that shows you know your stuff. Copying and pasting generic applications will get you immediately rejected. Organizations also get a limited number of slots for students they can accept. If you do get accepted, you’ll be assigned a mentor from the project and be expected to work on some substantial piece of code. Halfway through there is a midterm evaluation, and if you pass that you move on until the final, where you can still pass or fail. If you fail it, you’re out of the program. (The evaluations are not written tests.) Payment is $500 at start, rest of first half at the midterm (if passed), and the rest at final (if passed).
  • Planning to look into how to get extensinons to communicate with Review Board
    • smacleod: Extensions are basically Django apps with their own models, views, urls, etc. Requests and responses work pretty much like the rest of RB. Along with that, they are a Python class that gets instantiated when the extension is enabled, which can set things up and run code. These classes have a number of attributes which you can specify to hook into parts of the extension framework, as well as instantiate hooks to do verious things.
  • Figured out how how to install and enable extensions. Found documentation to add to admin panel.


  • Do I need to create a new API resource in RBTools for ValidateDiff endpoint?
    • smacleod: You shouldn’t have to create resource classes unless the API endpoint behaves differently or has something special.
  • Will be working on getting rbtools to validate diffs before uploading next.


  • Nothing new to report
  • Question: what view is the idff viewer in a review request reply (
    • ChipX86: review_detail (reviews/ sets up the page and creates placehoders for those. The JS then makes requests to the ReviewsDiffFragmentView for rendering those. It does it in per-file/revision batches to reduce fetches.
    • smacleod: It would be easier to tackle the backend API changes need first before working on the UI and frontend.

Meeting closed.


Leave a Reply

Fill in your details below or click an icon to log in: Logo

You are commenting using your account. Log Out /  Change )

Google+ photo

You are commenting using your Google+ account. Log Out /  Change )

Twitter picture

You are commenting using your Twitter account. Log Out /  Change )

Facebook photo

You are commenting using your Facebook account. Log Out /  Change )

Connecting to %s