Meeting Minutes for October 12, 2014


Mentors: m_conley (Mike Conley), smacleod (Steven MacLeod), and heapify (Anselina Chia)

Students: rdone (Ryan Done), andrewhong (Andrew Hong), asalahli (Azad Salahli), dkus_ (David Kus), nicole_xin (Nicole Xin), justy777 (Justin Maillet), brennie (Barret Rennie), and mloyzer (Mark Loyzer).


Just that ChipX86 and purple_cow won’t be able to attend today’s meeting.

Round Robin:

andrewhong (Andrew Hong):

  • figured out an approach to pull files locally when attachments are hosted externally
  • can see development log for additional details
  • signed up for Amazon AWS
  • fixed the small bug/impediment where Storage settings in the administrator panel doesn’t save the chosen storage option or your credentials
    • narrowed down the bug to a save function not being called on the form but it still investigating as to why the function is not being called.
  • came across a different issue that corrupted external files when retrieving them and zipping them into an archive
  • no questions.

nicole_xin (Nicole Xin)[tuning in from Oktoberfest]:

  • working on general comments, finished building the web-api and tests
  • testing is to be done the week starting October 13
  • Impediment regarding:
    Currently my dev server can be run as usual, but when i click on a review request, it gives error “no such table: reviews_review_general_comments” 
    So I try to update the database using syncdb, but I’m receiving an error says:

    • “File “/src/reviewboard/reviewboard/”, line 10, in <module> from reviewboard.extensions.base import get_extension_manager “
  • asahli mentioned using ./reviewboard/contrib/internals/ to try to solve this?
  • but smacleod disagreed because the issue was with the import command, not with the way the database was setup (he was right. the command did not resolve the issue)
  • m_conley and smacleod suggested pulling all changes for review board (and other repos) and to give that a try to see if it works, otherwise come back and try to resolve the issue then.
  • heapify (at end of meeting) suggested to try running “find . -name ‘*.pyc’ -delete” and do syncdb again

r_done (Ryan Done):

  • Added a selector for non-alphabetic names and completed error handling on incorrect URL arguments as discussed near the end of last week.
  • Added unit tests to test this above behaviour^
  • Reworked the logic of when to display the paginator—now always displays instead of hiding it for a query less than one page
  • Came across the bug The cause is unknown but besides this r_done is almost done his project
  • m_conley & smacleod: unsure/no immediate ideas of what the problem is and can discuss/investigate the error more after the meeting
  • m_conley: you never know how long it will take to fix a bug (especially when unsure of what the reason is) so better to be safe than sorry

dkus (David Kus)

  • added local site relation to file attachments
  • also added permissions for accessing the file attachments
  • performed some minor code refactoring to BaseFileAttachmentResource and BaseReviewRequestFileAttachmentResource (fewf)
  • plans to finish backend stuff the week of Oct 13.
  • question: “How do I check if a user is a superuser?”
  • smacleod: need to login with the username and password when setting up your development environment
  • smacleod: alternatively you can use
  • m_conley: when you’re logged in as an admin you can go to the admin dashboard and see which users are/are not

brennie (Barrett Rennie)

  • moved “comment diff fragment expansions” out of WIP…so free for people to review (
  • submitted a small bug fix for improving error messages (
  • wants to start working on the student project idea “Add support for aliases to RBTools”
  • smacleod: suggest to investigate how aliases are currently implemented before relying on (ba)sh for unix/cmd for windows
  • other than that not much else from status report.

mloyzer (Mark Loyzer)

  • so i was working on it a fair amount yesterday and when I overwrote my local repo I had to re-set up entire environment and I ended up fixing the error and I’m at the point where my environment is set up, I just have to re-implement the changes again.  is there a way to grab the changes on a review request or should i just copy-paste/re-type them out?  It’s not a big deal though now
    • (m_conley)rbi patch is your friend..that will grab the patch for a particular review request and apply it locally
  • (m_conley)I’m starting to think that a review request put into a CSV makes no sense.
  • (mloyzer)yes!! you see what i mean with the embdeded structure of a reviews and comments within a review_request not abiding by the natural structure of a csv
  • (m_conley)that really doesn’t work out for a complex model like a review request, with has_many relationships
  • (smacleod)XML could make sense
  • (m_conley)but then once you add these nested objects you can’t properly order the data
  • (smacleod)XML is one choice. JSON is another.Suggest XML because this is a feature that will mostly be used for industries
  • (m_conley)Agree.
  • (smacleod & m_conley):scrap CSV/CSV is out
  • (m_conley)JSON might be the simplest, because we have JSON serialization built right in – that’s how much of the WebAPI works.  And I hope you don’t feel like you’ve wasted all of your time
  • (mloyzer)no, i think it was good.  I’m glad I could convince you that it didn’t seem right.  and in that case especially i really didn’t lose any code at all (except for maybe a few lines)
  • (smacleod)Just wait to implement it so ChipX86 and purple_cow and choose another format
  • Concluding: Working on updating a mock PDF document (version 2) but will want that reviewed asap.  i will nag (maybe m_conley again because he’s been helping me out) and post it in the general IRC again as well

justy777 (Justin Maillet)

Finally got the hang of searching through the code and have started taking more notes, and has almost got my unit test running.

(m_conley)in your status report you mention you’ve almost got your test working
(smacleod)it’d be great if you could post your WIP ASAP that would be awesome

Will get the WIP up asap.
had one question since status report but prefer doing that after the meeting in a private chat
Wants to try to get 3 extensions sandboxed for next week

asalahi (Azad Salahi)

One thing to add to my status report. I managed to get subversion work, and tested base_dir (gratz)

  • Hasn’t tested various invalid diffs with subversion though. just git and mercurial using pysvn instead of subvertpy
    • that’s good. subvertpy seems finicky (smacleod)
  • Has removed [WIP] tag, so if I can have full blown reviews, that’d be great.
    • so it looks like this is wrapping up, have you thought about what project you’d like to work on next? (smacleod)
  • Interested in working on `rbt land`
    • Sounds like a good project to transition to given what you’ve learned on this one. Any questions regarding the project? (smacleod)
  • how do I do the design process of this project (all the command line options and stuff)
    • m_conley:
      • imo, the best way to start is to examine the pre-existing ecosystem
      • check out how the other commands are implemented because likely the patterns will be similar
      • and take notes. Come up with some implementation ideas, judge for yourself which the best one is, and post a WIP
    • smacleod:
      • I would start by looking at the options “rbt patch” takes and how it works as your functionality will be most of “rbt patch” plus extra stuff for pushing
  • Question: is that doc auto generated, or can I just edit .rst files?

Leave a Reply

Fill in your details below or click an icon to log in: Logo

You are commenting using your account. Log Out /  Change )

Google+ photo

You are commenting using your Google+ account. Log Out /  Change )

Twitter picture

You are commenting using your Twitter account. Log Out /  Change )

Facebook photo

You are commenting using your Facebook account. Log Out /  Change )

Connecting to %s