Status Reports for October 18, 2014

Barret Rennie

What project are you working on?
I’ve been working on expanding the comment diff UI.

What you accomplished this week?
This week I’ve mostly been working on fixing up the expanding comment
diff UI. The UI is now animated and defaults to a collapsed state so as not
to use a lot of screen real estate and the collapse button now hovers over
the diff fragment instead of being a fixed header on the table. I also
removed some dead code from the diffviewer’s DiffReviewableView. All it
needs is some reviews — its a big change.

Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6380/
https://reviews.reviewboard.org/r/6455/

What you plan to do next week?
I’ll be actually starting to work on the RBTools aliases functionality and I
think that they should function identically to git aliases for consistency’s
sake.

What, if anything, is blocking you from making progress?
Nothing.

Any other questions?
Nope.


Andrew Hong

What project are you working on?
Downloading review request attachments as zip.

What you accomplished this week?
Finally figured out the cause of why the zips were corrupt when downloaded!
Feature is now out of WIP. Trying to rebase…
Fixing suggestions given in review request for feature

Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6402/

What you plan to do next week?
Get started on a new project, haven’t decided on one yet; got a few on my mind though.

What, if anything, is blocking you from making progress?
Nothing

Any other questions?
Nope


David Kus

What project are your working on?
Drag ‘n Drop inline images in the markdown editor

What you accomplished this week?

  • Completed the view that redirects to the file url given a file attachment id.
  • Cleaned up some code, added some unit tests around the changes I made to FileAttachment model.
  • Split my review request into two review requests (one for the backend, one for the front-end) to make this a bit more manageable. There were only a couple of reviews on the old one, and no outstanding issues.

Links to anything you’ve done this week:
New review request for backend: https://reviews.reviewboard.org/r/6454/

What you plan to do next week?

  • Creating unit test for FileAttachment WebAPI resource. Do a bit more testing and then hopefully remove [WIP] tag for the backend and get some reviews on it.
  • Start working on wiring up the back-end to the front-end prototype

What, if anything, is blocking you from making progress?

  • I noticed that David T. (purple_cow) added some feature around file attachment history. How should user file attachments handle this? As it is right now, my code ignores this feature.
  • What should happen when using the view to try and view a file attachment before the file has been uploaded? e.g. View at /attachments/user-files// . This should redirect to the actual file for FileAttachment object with id (e.g. /uploads/etc/etc/). If there is no file associated with this FileAttachment object yet, what should it do?

Any other questions?
None at the moment!


Yanjia Xin

What project are your working on?
Same as last week, general comments

What you accomplished this week?

  • Implemented backend model test, all passed. I’m officially done on backend model.
  • Reorganized web api resource, merge a resource class
  • Add web api tests, still in progress

Links to anything you’ve done this week
Back-end model: https://reviews.reviewboard.org/r/6375/
Web-api: https://reviews.reviewboard.org/r/6431/

What you plan to do next week?

  • Refine web api and Pass all tests on web api
  • Start working on front end

What, if anything, is blocking you from making progress?

  • My database is crashed since last week, fixed just now! but it’s not blocking me from making progress since I have plenty of work to do regardless of the database.

Any other questions?
Nope.


Ryan Done

What project are you working on?
Finishing up the alphabetic paginator.
Started looking into next project.

What you accomplished this week?
Following meeting last Sunday I had some issues (Perforce and SSH) with my development environment that I had to sort out, all good now.
I addressed changes suggested in David Trowbridge’s review of my code: re-factored and simplified the template changes into two separate templates.
Decided to start on the spam filter extension as my next project, been mostly reading code for the last day or so looking into that so I don’t have much to show for it yet.

Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6369/
https://reviews.reviewboard.org/r/6368/
https://reviewboard.hackpad.com/rdone-development-log-LK0GSpfQxxN

What you plan to do next week?

  • Start writing code for the spam filter
  • Address any more reviews for the paginator
  • Do some more code reviews! (I’ve been reading a lot of the review requests but haven’t had much to say)

What, if anything, is blocking you from making progress?
Like I said I had some development environment issues that were causing unit tests to throw errors, but I’ve worked that out now.

Any other questions?
For the spam filter: should a newly registered user:

A) Not have any commenting privileges until their registration is approved by an admin? (A lot of discussion forums have implemented this behaviour)

or

B) Be shadowbanned or shadowmuted. Only they (and admins) can see comments and posts made to Reviewboard until an admin approves their registration. Of course we will still them know that their posts are not visible yet.

The latter option seems more difficult, but has its benefits.


Mark Andrew Loyzer

What project are you working on?
Adding an extension to Review Board that will allow people to export a review request as PDF or XML/JSON(pending).

What you accomplished this week?
Added a version 2 for a PDF mock up.
Began implementing the PDF report generation.

Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6393/
https://reviews.reviewboard.org/r/6413/
https://reviewboard.hackpad.com/mloyzers-Development-Log-3ERurrwGH78

What you plan to do next week?
Try to get everything at least up to the ‘Change Set’ summary implemented. This involves:
Adding headers to every page.
Finishing the Details section.
Adding Issue Summary section.
Adding File Summary section.

What, if anything, is blocking you from making progress?
I’m still waiting for a review on https://reviews.reviewboard.org/r/6413/

Any other questions?
What is the difference between a review’s body_top, body_bottom, and comments? In order to add a ‘body_top’ I had to click the ‘add comment’ link which I assumed would generate and save the contents as a comment…but it was apparently the review’s body_top. So, in short, what is the difference between these?


Justin Maillet

What project are you working on?
Still working on sandboxing extensions.

What you accomplished this week?
Very sorry, but due to getting sick and midterms I only got a bit of research done.

Links to anything you’ve done this week

What you plan to do next week?
This next week I plan to get some serious work done.
Hopefully putting all the sandboxing up for review along with most if not all the tests.

What, if anything, is blocking you from making progress?
Nothing is blocking my progress.

Any other questions?
No other questions.


Azad Salahli

What project are you working on?
Add ‘rbt land’ for landing changes

What you accomplished this week?
I have been looking at how `rbt patch` works, and how new changes are applied to repositories right now.

Links to anything you’ve done this week
Nothing I can point out, unfortunately.

What you plan to do next week?
Get a prototype working for Git repositories.

What, if anything, is blocking you from making progress?
My understanding of the process is that, a review request is first patched to the local repository of the user, and then pushed to the remote server.

If that is how it works, wouldn’t it be redundant to create a new command that does the same thing as `rbt patch` except pushing it to remote repository?

Or maybe `rbt land` should use `rbt patch` command itself and build on top of it?

I apologize for a kind of empty status report. I wanted to discuss this today with mentors interactively, and send a more useful report, and perhaps a [WIP] review request. But if I can get unblocked on this (and if my understanding is not entirely wrong), then I can probably create a prototype very soon.

Also, I am still waiting on reviews for https://reviews.reviewboard.org/r/6407/

Any other questions?
See above.

Advertisements

One thought on “Status Reports for October 18, 2014

  1. Pingback: Status Report for October 25, 2014 | Review Board Student Blog

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s