Status reports for October 31, 2014

Andrew Hong

What project are you working on?
Downloading Review Request Attachments as zip
Aggressive autocomplete in groups/people field.
Support for matching commits to review requests to more commands

What you accomplished this week? 
Been all over the place this week and had internet issues for the past few days… router is dead 😦 :
Downloading Review Request Attachments as zip: looking into how I can read chunks from files then write that chunk into the zip file. No obvious solution, probably need to write a wrapper for the zip file to make it work. Any direction this would be greatly appreciated! Googling didn’t turn up much for me.
Aggressive autocomplete in groups/people field: testing it again according to issues reported from users, it appears to working except in the case where the input matches in the middle of the string so it would not autocomplete. Looking into a solution that won’t break other cases.
Support for matching commits to review requests to more commands: got everything set up, like testing environment and how to test changes. Found appropriate section of code to change so looking into how to implement it best. Might be best to take the code that ‘guesses’ the review request into the Command class in RBTools.
Links to anything you’ve done this week
Sorry, it is mostly on scrap paper right now. Some things updated on my developement log: https://reviewboard.hackpad.com/Andrew-Hongs-Development-Log-cXtoZbAyag7What you plan to do next week? 

Focus on the zip feature and autocomplete; hopefully wrap them up, especially autocomplete.
What, if anything, is blocking you from making progress?
Anything regarding the zip feature that might help me would be great, or maybe an alternative approach that will also work?Any other questions?
Nope.


Ryan Done
What project are you working on? 
Alphabetic paginator
File upload diff slider

 
What you accomplished this week? 
When doing some initial research for the diff slider, I happened upon a bug where users were unable to update a file upload in their review request, blocking any work I could do. After a bit of research into the bug, David Trowbridge recognized the problem and fixed it. His fix is here: https://reviews.reviewboard.org/r/6511/
 
After submitting my review requests for the alphabetic paginator, Christian had some pretty helpful suggestions on how to improve the paginator . I spent most of my time this week addressing his review suggestions.
I created an AlphanumericDataGrid subclass that is now more generally usable by any other datagrid class that wants an alphanumeric datagrid. 
I also cleaned up the templates for the paginator a bit, and simplified the amount of context information being passed around from from the datagrid to paginator template tags (there is now just a simple, over-ridable render_paginator function, as opposed to custom template tags). 
Lastly, I moved this filtering of the queryset over to the AlphanumericDataGrid class in djblets to be performed dynamically. The “filter by” column is now a parameter passed in by the calling subclass.
Links to anything you’ve done this week 
 
What you plan to do next week?
If there is any more to do on the paginator update, I don’t foresee it being taking too much more time, so I’d like to really dig into the paginator stuff and get a proper review request up. 
 
What, if anything, is blocking you from making progress? 
Any other questions? 
All good for now. 

Barrett Rennie
What project are you working on?

This past week I’ve been working on the API caching and fixing up the alias support in rbtools.

What you accomplished this week?

I believe I’ve handled all the edge cases in rbtools alias support and API caching. Both are out of WIP now.

Links to anything you’ve done this week?
https://reviews.reviewboard.org/r/6491/
https://reviews.reviewboard.org/r/6504/

What you plan to do next week?

First off I want to get a issue with diff comment fragments fixed — they appear in the Edit This Review dialog but do not function. Then I’m going to be working on making ReviewBoard and rbtools support pushing/receiving DVCS history along with the patches.

What, if anything, is blocking you from making progress?

Nothing.

Any other questions?
Nope.


David Kus
What project are you working on?
Drag ‘n Drop inline images into the markdown editor
What you accomplished this week?
Worked on fixing the issues pointed out in the review request for the backend work I finished up last week.
Had to change quite a lot so I didn’t have time to work on the frontend.
Links to anything you’ve done this week.
What you plan to do next week?
Hopefully close off the backend work (once my changes are reviewed), and then get back to working on the frontend.
What, if anything, is blocking you from making progress?
Nothing.
Any other questions?
None.

Azad Salahli
What project are you working on?
`rbt land` for landing changes.
What you accomplished this week?
I haven’t been able to do much this week, I’m sorry. I had midterms and an assignment. However, I’ve discussed how `rbt land` should be designed with Christian. There is a hackpad page related to that discussion (link in next section).
Links to anything you’ve done this week

https://reviewboard.hackpad.com/rbt-land-YrgGuhTuseU

What you plan to do next week?

Getting a working version ready with at least Git support.
What, if anything, is blocking you from making progress?
Nothing

Any other questions?
None


Mark Loyzer
What project are you working on?
Adding an extension to Review Board that will allow people to export a review request as PDF and XML.
 
What you accomplished this week?
Figured out how to create ordered and unordered lists using reportlab which took too long (for ordered list) because of the lack of documentation.
Finished implementing most of the code for PDF (everything but inserting files, diff/change sets, and the full bodies of each review).
 
Links to anything you’ve done this week
 
What you plan to do next week?
Finish off PDF:
  Tidy up Header (still need to add the review request id to it).
  Get all files and change sets into the document.
Once this is done, I can start working on XML
 
What, if anything, is blocking you from making progress?
Do you have any tips on how to input the uploaded files or diff/change sets into the PDF?
What do the Mimetypes do?  Could I leverage that?
 
Any other questions?
Nope.

Yanjia Xin
What project are you working on?
Same as last week, general comments
What you accomplished this week?
1. Create a new review request about some documentation changes on other comments (already pushed)
2. Improve general comment backend model
3. Create a general comment review box view
Links to anything you’ve done this week.
1. Documentation changes: https://reviews.reviewboard.org/r/6528/
2. General comment backend model: https://reviews.reviewboard.org/r/6375/
3. General comment front-end: https://reviews.reviewboard.org/r/6506/
What you plan to do next week?
1. Improve general comment backend model and web-api (I already saw lots of comments on web-api)
2. Find a way to create a general comment (Currently my plan is using ReviewDialogView. If “open an issue”, we create a general comment; otherwise it’s a body-top.)
3. Modify the email content of the general comment (ChipX: I will put the email on the review request once I’ve done that)
4. Add tests, hopefully
What, if anything, is blocking you from making progress?
Not really, front-end is a little bit messy so I spend a lot of time poking around and play with that.
Any other questions?
I’d like to see if mentors have any ideas on how we let users to create a general comment. 🙂

Justin Maillet
What project are you working on?
I’m working on sandboxing extensions.
What you accomplished this week?
I’ve taken my patch for sandboxing Djblets Column subclasses out of WIP.
I Finished two more patches, one for sandboxing Reviewboard MimetypeHandler and the other for sandboxing Djblets TemplateHook applies_to() function.
I’ve started digging into the Djblets SignalHook class, Reviewboard ReviewUI class, and related files.
Additionally, I’ve made improvements to my patch sandboxing Reviewboard AuthBackend subclasses.
Links to anything you’ve done this week
What you plan to do next week?
This coming week, I plan to re-write the webapi tests for AuthBackend, finished the last two patches in the project, make improvements from comments in code reviews, and hopefully start on a new project.
What, if anything, is blocking you from making progress?
Nothing is blocking my progress.
Any other questions?
Is there documentation on the WebAPI testing framework in reviewboard? or can someone give me a small explanation to how a specific function gets called in WebAPI tests?
Advertisements

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s