Status Reports – November 8 2014

Ryan Done:

What project are you working on?
File attachment diff slider
 
What you accomplished this week?
I did a few quick changes on the paginator, and then unfortunately a family emergency came up so I really haven’t been able to get much code written this week. Terribly sorry about that.
 
Links to anything you’ve done this week
 
What you plan to do next week?
Get a review request up for the diff slider, and do some more code reviews.
I fully intend to get some stuff done in the next two-three days to catch up, its just these last few nights have been kinda hectic for me.
 
What, if anything, is blocking you from making progress?
Any other questions?
Nope all good.

Andrew Hong:

What project are you working on?
Download Review Request Attachments as ZIP
Aggressive Autocomplete field for People/Groups
 
What you accomplished this week?
More background research into feasibility of packaging files into tar.gz instead. Clearer understanding now after discussions with ChipX86.
Tested ChipX86’s implementation of file chunking and understanding the code to implement it into ReviewBoard. The snippet seems to not work with “larger” files, works good for smaller ones so going to move forward and deal with larger files later.
Trying to fix autocomplete again, brainstorming/testing ways to better handle user input. Posted a question on IRC and waiting to hear back before moving forward.
 
Links to anything you’ve done this week
 
What you plan to do next week?
Start integrating ChipX86’s snippet into ReviewBoard and deal with the large file bug afterwards. I think it is because of the compression flag.
(finally) finish off the autocomplete?
 
What, if anything, is blocking you from making progress?
Nothing.
Any other questions?
Might have to put off the RBTools project that I somewhat started on 2 weeks ago.

Mark Loyzer:

What project are you working on?
Adding an extension to Review Board that will allow people to export a review request as PDF and XML.
 
What you accomplished this week?
Figured out how to add the body tops, bottoms, and comments to the PDF.
Implemented the printing Review objects and updated the format of the PDF.
Started implementing the printing of Change Description objects.
 
Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6393/ & uploaded a new sample PDF document.
 
What you plan to do next week?
Finish implementing how the Change Descriptions should be displayed in the PDF.
 
What, if anything, is blocking you from making progress?
None.
 
Any other questions?
For Change Descriptions, is there anyway to properly display the changes made?  Right now I’m using a dictionary to map that maps ‘plus’ to the attribute that represents what was added (either ‘added’ or new’).  But even then sometimes the value is an array or an array of arrays.
I know that is extremely vague, so, in summary, I am trying to display the changes made to the Review Request through the ChangeDescription’s ‘fields_changed’ attribute,  Do you suggest any way to properly print the information in this dictionary?

Justin Maillet:

What project are you working on?
I’m working on making New Extensions.
What you accomplished this week?
I’ve finished up sandboxing the extensions. All but two of the patches have been shipped, but the last ones will be soon.I found a bug in reviewboard/webapi/resources/review_request_draft.py, under certain conditions it was trying to pass None into the database, which prevents more database queries. The patch for that is currently in review.
Started doing research for the new extensions, and have some basic code written.
Links to anything you’ve done this week

What you plan to do next week?
This coming week, I plan to get the last few patches and the bug fix shipped. I also plan on completing at least two units of work from the new extensions; maybe more.
What, if anything, is blocking you from making progress?
Nothing is currently blocking me.
Any other questions?
What happens after this term is over and we want to continue working on reviewboard?


Nicole Xin:

What project are you working on? 
same as last week, general comments
 
What you accomplished this week? 
1. Improve general comments backend model and web-api
2. ‘Add comment’ button on review request page, green box pop up when click on it, but unfortunately so far general comments can’t be saved 😦
3. There is a bug in the reviewDialogView, where a comment must have a Thumbnail Template. This is solved by bypassing this step for general comments.
 
Links to anything you’ve done this week 
 
What you plan to do next week? 
1. Fix all the js-tests. (Before pulling from origin master, i passed all the test. But after pulling from origin master, there is a lot of merging conflicts in my front-end branch and I’m failing 7 tests, so i need to look into that next week)
2. Enable ’saving’ general comments
3. Improve and testing email
 
What, if anything, is blocking you from making progress? 
I think I might did the wrong way to create a commentDialogBox. (reviewboard/static/rb/js/pages/views/reviewablePageView.js line 264-270 in review request)
I’m getting error: ‘A “url” property or function must be specified’(Say, ERROR1) when I click on ‘Add comment’ on review request page, and now I won’t be able to type anything in the editor.
(Before pulling from master, I can type my comments in the editor. However, I’m getting the same error: ‘A “url” property or function must be specified’ if i click the ‘save’ button on the commentDialogView, but they have different traceback.(Say, ERROR2))
Now since I can’t type in any comment, I won’t be able to save. But if I click on ‘Add comment’ button again, it will actually give ERROR2 instead of ERROR1, as many as I want.
 
Any other questions? 
What do those txt files in the reviewboard/templates/notifications for?
I can see that they are different from those html emails, but how are they different and why?

 Azad Salahli:

 What project are you working on?
`rbt land` for landing changes
 
What you accomplished this week?
Implemented what was discussed in https://reviewboard.hackpad.com/rbt-land-YrgGuhTuseU
 
Links to anything you’ve done this week
 
What you plan to do next week? 
To add support for patching others’ review requests before landing
 
What, if anything, is blocking you from making progress? 
I am having trouble using `rbt patch` inside `rbt land`. Calling other command’s main function doesn’t work because of command line arguments being missing. There is Patch.run_from_argv()` but it requires argv list, which is not present inside `Land.main()`.
The second option would be to execute `rbt patch` as an external command. But the same issue of having to provide argv list is there too.
 
Any other questions?
How can I programmatically verify that git commands executed successfully?

David Kus:

What project are you working on?
Drag ‘n Drop inline images into the markdown editor.
 
What you accomplished this week?
Connected front-end to backend. Dragging and dropping images into the markdown editor is now working, but some things still need to be considered. (see below).
Links to anything you’ve done this week.
Backend rr (still need reviews on this) https://reviews.reviewboard.org/r/6454/
 
What you plan to do next week?
Working on adding a way to attach files to a rr when a markdown editor is open. Right now I’m disabling the current dnd overlay when you open a markdown editor (otherwise the overlay blocks the editor and you can’t drop a file into it). Not too sure how to go about doing this though.
 
What, if anything, is blocking you from making progress?
Should we keep track of the file upload progress (have a progress bar underneath the markdown editor when you drop in a file)? This was mentioned in the prototype, just not sure if it’s something that we need?
If we are tracking progress, should you be able to cancel an upload in progress (is this possible)?
Any other questions?
No other questions.

Barret Rennie:

What project are you working on?
I just finished up a bug where the diff fragment controls showed up in the review dialog. They no longer do and they won’t show up in emails either.

What you accomplished this week?
The above as well as doing a bit of tweaking on rbtools aliases.

Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6491/
https://reviews.reviewboard.org/r/6567/

What you plan to do next week?
Start working on getting commit history to be pushed with rbi post.

What, if anything, is blocking you from making progress?
https://reviews.reviewboard.org/r/6504/ needs a review

Any questions?
Nope

Advertisements

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s