Status Reports – November 22, 2014

Barret Rennie

What project are you working on?
Multiple commits per review request

What did you accomplish this week?
Got the initial schema done for multi-commit RRs and started looking into API endpoints.  I also cleaned up

Links to anything done this week?
https://reviews.reviewboard.org/r/6504/
https://reviews.reviewboard.org/r/6618/

What do you plan to do next week?
I plan to get modify the review-requests/ api endpoint to allow creating/updating a RR draft with multiple commits and appending a commit to the current draft. I also want to start working on the RBTools end of things.

What, if anything, is blocking you from making progress?
Technically its not blocking me but a bug in django-evolution is preventing my evolution from applying cleanly.
My API caching RR — https://reviews.reviewboard.org/r/6504/ — could use a review.

Any other questions?
When it comes time to add support for rbtools should it require a flag (e.g. –with-history or -h or similar) to create the review? What should the flag be?


David Kus

What project are you working on?
Drag ’n Drop Images into the  Markdown editor.

What you accomplished this week?
Split my backend review request into 4 smaller ones.
Updated the API documentation for the end-point that I’m adding, as per ChipX86’s comments on my review request.
Finished up the bulk of the front-end work.
Added quite a few tests for the front-end changes.

Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6510/ (front-end)
https://reviews.reviewboard.org/r/6616/ (backend view)
https://reviews.reviewboard.org/r/6617/ (backend WebAPI)
https://reviewboard.hackpad.com/dkus-Development-Log-LpIrKtA6wfI (Hackpad)

What you plan to do next week?
Final touches and any changes from code review suggestions. Possibly some more testing (I’d like to test it in Internet Explorer at least)

What, if anything, is blocking you from making progress?
Reviews and feedback on how the Drag ’n Drop overlays look (images on the rr).

Any other questions?
None


Mark Loyzer

Project:
Working on exporting Review Request as PDF and XML.

Accomplished:
I finished adding a Data Extraction object for Reviews, tidied up some of the code then started the XML stuff.
I wasn’t able to get the URLs working (I’m not sure how to create unique urls for Action Hooks) otherwise I would have removed the WIP tags.

Links:
https://reviews.reviewboard.org/r/6393/
https://reviewboard.hackpad.com/mloyzers-Development-Log-3ERurrwGH78
(there should be another one but I can’t get rbt post to work properly)

Next week:
Sunday I want to resolve the URL issue and then remove the [WIP] tags from 6393.
Early in the week I should be able to finish XML export and submit that.

Questions:
 I tried posting to review board and got the error:
“Warning your working directory is not clean. Any changes which have not been commited to a branch will not be included in your review request.”
Then no diffs were uploaded.
I have since cleaned my branch and when I try to post it doesn’t upload the correct diffs.
Secondly, how do you create unique urls for Action Hooks?  ChipX86 recommended overriding get_actions but I didn’t see anything in the documentation of how it is used/when it is called.


Nicole Xin

What project are you working on?
‘rbt stamp’: Adding the review request url to the commit message.

What you accomplished this week?
1. Fix general comment reply.
2. Fix some issues about front-end of general comments.
3. Move ‘guessing ability’ of ‘rbt post -u’ into utility functions. (rbt post -u works correctly)
4. Start working on ‘rbt stamp’.

Links to anything you’ve done this week
General comments front-end: https://reviews.reviewboard.org/r/6506/
‘rbt stamp’: https://reviews.reviewboard.org/r/6623/ (Sorry it ooks a little bit messy, still a WIP)

What you plan to do next week?
Try my best to get ‘rbt stamp’ work for git.

What, if anything, is blocking you from making progress?
Nope, all good.

Any other questions?
Nope.


Ryan Done

What project are you working on?
File Attachment revision slider

What you accomplished this week?
Addressed some initial style and clean up from Chip’s review.
I’ve got a rendering slider for both image and text attachments; (although any aesthetics may not be ideal by pencils down).
I’ve gotten all the callbacks to respond to slider interaction, and they get the correct values back (revision selected value that I can use) (_revisionSelected)
I understand how to do side by side display within the text file template (templates/reviews/ui/text.html) using the table/column/row setup
Then I’ve got a bunch of questions to clarify and then I should be able to move ahead with everything.

Links to anything you’ve done this week
https://reviewboard.hackpad.com/rdone-development-log-LK0GSpfQxxN
https://reviews.reviewboard.org/r/6591

What you plan to do next week?
Finish up the and the image diff and text attachment diff, may not get to all the aesthetic stuff like dynamic labels and positioning .

What, if anything, is blocking you from making progress?
Questions

Any other questions?
1. How should I communicate back to the server when the slider is moved?
I noticed the diff viewer slider adjusts the URL arguments using using the Router, forcing the page element to request new diff content to be passed back in response.
This is at least a little tricky right now with the text attachments: the html template actually places the lines of the file into the page on the server end. (IE the text from the file is there on the page even before the JS does any of its rendering work), so it would require a completely new response.
I think all that will get stripped and the file contents will get sent to the JS model, which will push the contents onto the page?
This is a little less of a problem for images because you can always just request the resource again.

2. How should image diffs be handled?
There appears to be stuff in place to select a variety of different image diffing modes that are enabled when a diffAgainstFileAttachmentID is provided by the server. Presumably once 1) is worked out, the slider will get moved and the server will provide back a new JS model with that value set and the diffing modes will be turned on.
Or do I need to do a side by side UI setup similar to a text review? (I think this is actually the ImageTwoUpDiffView option anyways).

3. How might the user opt to turn off a file diff and just look at 1 instance of a file?
By default there is 2 handles that can choose 2 revisions of the file, but unlike a Review Request Diff slider there should be an option to switch back to a 1 file view (or even a 1 handled slider?) ? Perhaps the label click events?


Azad Salahli

What project are you working on?
`rbt land` for landing changes in upstream

What you accomplished this week?
Fixed issues pointed out by Christian.
Refactored duplicate code into utility functions

Links to anything you’ve done this week
RR: https://reviews.reviewboard.org/r/6509/
Meeting minutes: https://reviewboardstudents.wordpress.com/2014/11/23/meeting-minutes-november-16-2014/

What you plan to do next week?
Get my RR ready for landing. Maybe attempt another SCM support

What, if anything, is blocking you from making progress?
Nothing

Any other questions?
None


Andrew Hong

What project are you working on?
Download review request attachments as tarball
Aggressive autcomplete bug

What you accomplished this week?
Implemented “contains” for users/groups/search resource query but ChipX86 pointed out that it will need a full rewrite for this feature to be implemented properly.
Tested autocomplete again to be sure it’s working as expected with “contains” feature removed.
Wrapped up downloading review request attachments as tarball; tested and all, seems to be working great 🙂
Awaiting reviews on both features.

Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6402/
https://reviews.reviewboard.org/r/6333/

What you plan to do next week?
Go over both features to see if there are any other improvements to make.
Implement suggestions as they come from reviews.

What, if anything, is blocking you from making progress?
Nothing

Any other questions?
I’m wondering how I can pull in file attributes like last modified, date created, etc. from externally (S3) stored files?


Justin Maillet

What project are you working on?
I’m currently working on creating new extension hooks.

What you accomplished this week?
I’ve finished work on two of the three new hooks and their documentation.

Links to anything you’ve done this week
https://reviews.reviewboard.org/r/6573/
https://reviews.reviewboard.org/r/6597/
https://reviews.reviewboard.org/r/6572/
https://reviews.reviewboard.org/r/6600/
https://reviews.reviewboard.org/r/6613/

What you plan to do next week?
This coming week I plan to finish the last extension hook and it’s documentation, then get started on sandboxing those new extension hooks.
At some point I’ll also be fixing formatting errors that pep8 picks up in the different modules.

What, if anything, is blocking you from making progress?
Nothing is blocking my progress.

Any other questions?
None for now.

Advertisements

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s