- Mute and Archive Review Requests
- fixed archive query
- POST request for archiving works (yay!)
- discovered the magic of PDB!
- hid “Hide” button when review request is already hidden (archived/muted)
- added “show archived/hide archived” button on dashboard and hooked it up to a URL query
- hackpad: https://reviewboard.hackpad.com/Chriss-Notes-aOjnNWbg014
- review request: https://reviews.reviewboard.org/r/6830/
- complete banner for unarchiving
- implement unarchiving
- write tests
- my “show-archived=1” URL query seems to work fine except when I want to combine it with other queries, such as “?view=outgoing”. I am able to append my own query with a “&” but my problem is when the query is already combined “?view=outgoing&show-archived=1” and I want to change the 1 to a 0. I am trying to figure out how to index strings or either rethink the logic and am currently stuck here
- unarchiving should happen automatically when the submitter rbt posts again, any other scenarios to be considered? I was thinking maybe when the submitter responds to a comment or marks something as “fixed” or other actions?
- should my “show archived/hide archived” button be changed to “show hidden/hide hidden” when I add muting, or should I add a separate “show muted/hide muted” button?
- difference between archiving and muting: review request should unarchive itself when there’s new activity, while muted should stay muted until manually unmated… any other things?
– I am working on the file provider framework
– Addressed to the rest of Barret’s and Christian’s issues
– added get_queryset to both file_provider.py and file_provider_file.py, and made any necessary changes to get and get_list
– cleaned up the test cases and the two files above
– did some manual testing with uploads from DropBox and http requests
– added file upload logic to base_file_attachment.py
– added test cases for the above
– added unique account check
– fixed initialization of fileproviders/fileproviderfile.py
– removed WIP from two of my review requests
– FileProvider module implementation with Django: https://reviews.reviewboard.org/r/6806/
– FileProvider WebApi integration: https://reviews.reviewboard.org/r/6948/
– New Error for Djblets WebApi – DUPLICATE_ITEM: https://reviews.reviewboard.org/r/6968/ – Examples of uploading files: https://reviewboard.hackpad.com/Extra-Log-for-Vinces-Reports-38dBJnwv9IW
– Design the UI for the upload
– Start looking into backbone and how the file uploads are done with files from local machine
– Start working on the UI, at least get the base ui looks done without any api calls.
– Nothing yet
6) Any other questions
1) I wasn’t sure about the error I added for the file provider api (DUPLICATE_ITEM), whether it should be part of djblets, reviewboard or not included at all. What should I do?
2) When are the mid-term reports coming out? I would like to know how I’m doing and what improvements I can make.
- Refactored rb-gateway into a state suitable for submission based on feedback
- Reorganized my hackpad
- Landed initial rb-gateway patch.
- Implement APIs for post commit UI (get branches, get changes, get commits)
- Nothing, sorry I’ve been a bit busier this week and didn’t accomplish as much as I hoped.
- Responsive UI
- Learning on Backbone.js
- Moved previous banner menu toggle logic into new backbone view
- Fixed tab display/align issue in user page
- Properly setting up the backbone view file/insertion
- Confirm side menu toggle design
- rebase changes through all branches
- Lack of input on the design side (previously posted on google dev)
Almost landed r/6797
review request: https://reviews.reviewboard.org/r/6797/
Get a new project
1) What project are you working on?
- Post-commit review request support for GitLab
2) What you accomplished this week.
- Fixed the issue in the unit test for review #6786.
- Roughly implemented all needed functions and classes for the GitLab project.
- Read GitLab API.
- Helped peers.
3) Links to anything you’ve done this week:
- hackpad: https://reviewboard.hackpad.com/Chesters-Code-Sprint-Logs-Keep-updating-t6UxLoMfjmD
- ‘Download diff’ issue review request: https://reviews.reviewboard.org/r/6786/
- project review request: https://reviews.reviewboard.org/r/6872/
4) What you plan to do next week.
- Write unit tests.
- Debug the code.
5) What, if anything, is blocking you from making progress?
- The GitLab API document.
- Haven’t built up very good understanding on Git.
- Not very useful GitLab community / IRC channel.
- Network connection.
- Bad time management because of traveling
6) Any other questions
- For the `get_change()` function in `GitHub` class in review board.hostingsvce.github, I want to confirm if I understand it in the right way:
- All we want is to get `author_name`, `revision`, `parent_revision`, `date`, `message`, `diff` to return a Commit object.
- The goal of getting `tree` and `blobs` is to build up diff.
- Could you please explain the cache in `get_change()` function, I don’t quite understand how the cache is generated and how it works.
- Could you please explain the term `revision` in here? Is it sha? Or id of the project or branch?
- Is `parent_revision` necessary? Because it is default as an empty string in the definition. In GitLab API, I haven’t seen any description about `revision` (maybe I missed something).
- Any tips to test the GitLab project on virtual environment? Say, Bitnami.
- In GitLab class, when we call self.client.http_get(), are we calling the function from HostingService from service.py or GitHubClient in the same file? Because in GitLab class, we are calling http_get() function from HostingService, but if so, what is the purpose of http_get() in GitHubClient / GitLabClient classes and how to call this function?