Author Archives: Anthony

Status Reports – April 7, 2012

Anthony

Status:

  • Tried to address issue 2551.
  • Updated the code of my existing review requests to reflect changes have been made since.

Next Steps:

  • Address conflict issues between r/2964 and r/2859 depending on which gets committed first.

Roadblocks:

Dave

Status:

  • Fixed a bug: update notification popping up when it shouldn’t. (r/3043)
  • Iterated capabilities for RBTools. (r/2918)
  • Looked into inline editor. (r/2991)

Next Steps:

  • Make sure projects are complete before end of term.

Roadblocks:
None

Steven

Status:

  • Restructured the Review Bot architecture, added features and a little more polish. (r/3042)
  • Updated Web Hooks extension. (r/2855)
  • Updated extension documentation. (r/2950)

Next Steps:

  • Hopefully have code committed.

Roadblocks:

  • Reviews.

Wilson

Status:

  • Looking for ship it status on r/2828

Next Steps:

  • Figure out data grids.

Roadblocks:

  • Having trouble understanding datagrids, hoping to get help.

Jim

Status:

  • Shipped r/3000 r/3001.
  • Need a ship-it on r/3033, unless there are further reviews.
  • Need someone to take a look at r/2966 and figure out what went wrong… I refactored the code but it is currently broken, not sure why.
  • Looking into a bug with typeahead reviewers, a bug that I opened in the beginning of term and never really get a chance to fix. (issue 2459)

Next Steps:

  • Hopefully finish r/2966.
  • Fix the bug that I discovered.

Roadblocks:

Yazan

Status:

  • Need review on r/2964.
  • Working on update issue status of deleted screenshot/file attachment bug.
  • Working on incremental expansion.

Next Steps:

  • Submit bug-fix/incremental-expansion patch.

Roadblocks:
None.

Wei Lu

Status:

  • Not too much done last week, finally finished other course projects.

Next Steps:

  • Concentrate working on Review Board.

Roadblocks:
None.

Meeting Minutes – March 10, 2012

Administrative Concerns

  • Wilson is unable to attend this weekend, but everybody else is in attendance.
  • Django upgrade: if you’re still having problems, talk to one m_conley/ChipX86/purple_cow or send a general request to the IRC channel.

Meeting Proper

Curtis

  • request for feedback on comment on the open issue (r/2810)
  • brief discussion on the proper placement of select_related, i.e., near the construction of the query, and before the query will be instantiated/executed
  • tips for fighting coding burnout
    • break up the larger tasks with non-coding tasks or smaller side-tasks with more immediate results
    • deconstruct the large task into smaller chunks/milestones with their own immediate/tangible results. nurture a sense of accomplishment and definite progress.
  • hopes to bring Javascript experience into extension frontend

Dave

  • issues with naive timezone warnings when passing in __range (snippet)
  • python issue (snippet)

New Student Project Idea: reviewable pasting service

Jim

  • Busy week, but no roadblocks moving forward

Willer

  • discussed proper location of admin command. examples provided using find `reviewboard/ -name management -type d`
  • question about blog post: high-level idea of the semester so far for an audience that has a passing knowledge of Review Board, refer to other blog posts for examples.

Yazan

  • issue regarding reintroducing a fork from github into a local branch

Anthony

Steven

  • discussed action log for admin site, selected course of action is to remove the link

Wrap-Up

  • reminder that there may be some reviewed requests that haven’t been updated yet, so check in on any pending requests.

Status Reports – Mar 3, 2012

Anthony

Status:

  • Chose full-file review for next project.

Next Steps:

  • Work on full-file review when time permits.

Roadblocks:

  • Midterms and assignments.

Curtis

Status:

  • Posted changes for r/2810.
  • Made some progress on my extension.

Next Steps:

  • Spend more quality time with review-extension.

Roadblocks:

  • Need more hours in the day.

Dave

Status:

  • Researched all SCM diff generators for moved files.
  • Posted a review request for post-review with moved file capabilities.
  • Working on post-review “capabilities” feature which will work in unison with diff moved files. Christian completed the server side component (see RB commit 1fa7eb3).

Next Steps:

  • Finish client-side “capabilities”.

Roadblocks:

  • None.

Jim

Status:

  • Still struggling to get rendering working.

Next Steps:

  • Find time to work on it more, pretty busy week for me.

Roadblocks:

  • Possibly need Christian’s help.

Steven

Status:

  • Busy, Minimal progress.

Next Steps:

  • Close off extension system upgrades.
  • Update WebHooks and post a “final” review request.
  • Put ReviewBot up for review.

Roadblocks:

  • Fine for now.

Wei Lu

Status:

  • Researched “send email” and “django-admin command” for project “weekly headlines”.

Next Steps:

  • Ask for expertise and start coding.

Roadblocks:

  • For project “Tracking user changes” (r/2891), no comments since last meeting.

Wilson

Status:

  • Getting better.

Next Steps:

Roadblocks:

  • None.

Yazan

Status:

  • Busy week, not much was done.
  • Updated environment.

Next Steps:

  • Submit moved summary table for feedback.
  • Submit incremental expansion for review.

Roadblocks:

  • Lack of time this week.

Development Status Post – Code Sprint

At the code sprint, I fiddled around with github and set up backup forks of reviewboard and rbtools. I addressed issue 495, submitted a code review and it was accepted into master.

Additionally, I filed issues 2457 and 2460, and worked on some code reviews for other team members.

I picked the Extension Scaffold Generator student project from the wiki, and delved into the sample extensions here (RBBugTracker), and here (toy extensions). After creating a simplified example extension, I modelled the script after postreview.py. The file generation code uses Jinja2 templates, and wrote up a version of the script that could generate extensions that could be installed; after some tweaking, I have submitted a code review.

My next steps are to:

  1. Figure out what other options might be useful for extensions
  2. Flesh out the documentation on the wiki article for building extensions


Anthony Mok

UCOSP Blog Post – January 22, 2012

I am Anthony Mok, and I am in my last term of the Computer Science program at the University of Waterloo. I picked the Review Board project for UCOSP due to favourable past experiences with the software and a desire to want to contribute to the community; it also felt like a good opportunity to learn new skills and technologies. I met the other students and Mike from the Review Board UCOSP team for the first time this weekend at the Code Sprint at UBC.

The sprint began with a short group session, and shortly afterwards we split up into our individual teams and began what would be a solid weekend of productivity. We set up our development environments and workflows, and although it wasn’t without hardware and software issues, we more or less got straight to work fixing bugs, picking up long-term projects, and doing peer code reviews using Review Board itself. The code sprint had many good lessons, both explicitly in the form of a git tutorial (a version control system that is crucial in sharing and backing up work between distributed team members), and implicitly as we got comfortable working with the other members of our group and got our code reviewed.

I have picked up a long-term project in the form of a helper script that will generate the scaffolding for Review Board extensions. Essentially, this will fill out a bare-bones skeleton for a working extension based on a simplified configuration scheme that will be provided by a user. Currently, documentation on extensions is scarce, but I hope to be able to flesh out documentation on the wiki page with fellow team member Steven.

I am posting this as I wait for my flight home from an exciting and productive code sprint. I am confident that working on the project will continue to be as enjoyable and enlightening as this code sprint has been.


Anthony Mok