Author Archives: chesterl1

[UCOSP] Status Report For Week Feb 9 – Feb 15


Jessica Yuen

1. What project are you working on?

– rb-gateway

2. What you accomplished this week:

– Added test cases for checking whether ReviewBoardGateway hosting service subclass can find the repository on rb-gateway, whether authorization sends the expected data, for checking service support capabilities, and checking repository field values.

– Added get_file and get_file_exists implementations to hosting service subclass.

– Added APIs to rb-gateway for getting file blob and checking file existence based on commit id, file path pairing. 

– Made demo video to demonstrate rb-gateway

3. Links to anything you’ve done this week:

https://reviews.reviewboard.org/r/6831/

https://reviews.reviewboard.org/r/6850/

4. What you plan to do next week:

– clean up rb-gateway a bit and hopefully get initial patch submitted

– clean up my Hackpad

– Either add Hg support, or add more APIs to rb-gateway to support more advanced functionalities that RB needs (I don’t know which yet – I want to talk to a mentor about this)

5. What, if anything, is blocking you from making progress?

– Nothing

6. Any other questions?

– Nope!

Tien Vu

1) What project are you working on?

 Diff Doctor

2) What you accomplished this week?

– A lot of investigating code. Stepped through most of the stack to display a diff (reviewboard/diffviewer)

– Read Django docs about models and databases to make sense of the DiffSet and FileDiff models

– Rewrote some of the template code for Jinja2

– Made demo video

 

3) Links to anything you’ve done this week

 

https://reviews.reviewboard.org/r/6833/

https://reviewboard.hackpad.com/Tien-Feb-8-o3XQYinbxcc

 

4) What you plan to do next week

Look for specific cases where APIs to return original files fail (therefore failing the patch). I’ll decide what to do from there, as of right now I’m still not 100% clear of my tasks ahead. I might take a look at the diff validator code as well.

 

5) Any blockers for your project?

Not really. 

 

6) Other questions?

No.

Vincent Le

1) What project are you working on?

    – File provider framework

2) What you accomplished this week.

    – Made test cases for reviewboard/fileproviders

    – Redid the file_provider_file to use get_list and get_item, had to take a look into url regex

    – Learned that Django or some component of the framework decodes url automatically, i.e. %7E into ~

    – Addressed most of the issues addressed by Barret and Christian

    – Filmed my demo video

3) Links to anything you’ve done this week:

    – FileProvider module: https://reviews.reviewboard.org/r/6806/

    – FileProvider webapi: https://reviews.reviewboard.org/r/6948/

    – My hackpad: https://reviewboard.hackpad.com/Vincents-File-Upload-Log-sh2QycRO45Z

    – My demo video: https://www.dropbox.com/s/relu15xppvykcjj/VID_20150213_223907.mp4?dl=0

4) What you plan to do next week.

    – Address to issues raised by Barret and Christian

    – move any neccessary parts to get_queryset for both webapi

    – clean up file_provider_file.py

    – get the file upload integrated into file_attachments.py

5) What, if anything, is blocking you from making progress?

    – None yet

6) Any other questions

    – None yet

Chester Li

1) What project are you working on?

  • The post-commit review request support with GitLab

2) What you accomplished this week?

  • Read and built up better understanding on GitLab API
  • Changed some functions in GitLabClient class.
  • Finished unit test for review 6787

3) Links to anything you’ve done this week

4) What you plan to do next week

  • Finish the rest of functions in GitLab and GitLabClient classes.

5) Any blockers for your project?

  • The GitLab API document.
  • The poor internet connection in my current area.

6) Other questions?

  • Nope


Christopher Arnold

1. What project are you working on?

Mute and Archive Review Requests

2. What you accomplished this week.

  • midterm demo!
  • scrapped review_request_visit API and decided on two separate archived_request_visit and muted_request_visit APIs to prevent visits from being exposed
  • added archive/unarchive/mute/unmute functions in reviewRequestVisit model
  • began archive banner
  • webAPI url for archived review requests

3. Links to anything you’ve done week:

Hackpad: https://reviewboard.hackpad.com/Chriss-Notes-aOjnNWbg014

Review Request: https://reviews.reviewboard.org/r/6830/

4. What you plan to do next week.

  • make full connection between button click to database change for archiving and unarchiving
  • complete banner
  • write some tests

5. What, if anything, is blocking you from making progress?

  • getting a 405 error when I make a POST request in my archived_review_request.py, what might be wrong?

6. Any other questions.

  • so far, I’ve went in a couple of wrong directions and had to backtrack a bit. I’d really like it if someone could look at what I’ve done this week to tell me if I’m on the right track and any pointers I should keep in mind going forward
  • when would we want to use `user = resources.user.get_object(request, *args, **kwargs)` as opposed to `user = request.user`?
  • what’s the best way to test webAPI?
  • what does the @property decorator do?

Jason Tseng

1) What project are you working on?

Responsive UI

2) What you accomplished this week?

  • Demo
  • Some advancement on the progress with admin/user page
  • posting design discussions on google dev discussion board

3) Links to anything you’ve done this week

4) What you plan to do next week

  • wrap up admin/user page
  • revisit previous feedbacks

5) Any blockers for your project?

  • Been testing with adding responsive ui for tabs under user’s page, but having issues displaying properly under smaller screen width. In current best attempt, under certain width, the first tab would stuck with two lines while the second and third using only one line, causing different height between the three and thus unaligned display of buttons.

6) Other questions?

n/a

Theo Belaire

1) What project are you working on?

RB Tools, better parent_base

2) What you accomplished this week?

  • Demo
  • I’m ready to land, I feel, at least the first part.

3) Links to anything you’ve done this week

4) What you plan to do next week

  • Populate the Branch field if possible.
  • I’m planning on showing up for office hours and asking a lot of questions, since I’m feeling a bit lost.

5) Any blockers for your project?

  • I would like more feedback about my patch, and I don’t feel super comfortable with `upstream_branch` and how I interact with it.

6) Other questions?

N/A
Advertisements