Author Archives: 咳嗽di小鱼

About 咳嗽di小鱼

Talk is cheap, show me the code...

Meeting Minutes March 17, 2013

Opening Announcements

We’re entering the final stretch. Make sure you get your status reports in on time, and make sure they’re posted to the reviewboard-students mailing list as well so we can see when they’re sent out. zz_nh2, ayrus12, Katkat and gregwym’s terms are up in few weeks. So it’s probably best to start shifting yourself to getting your patches out of WIP as soon as possible, to give us time to review them, to give you time to alter them, while not cramming everything into the last week.

fsung

Q: Where would I place the link for people to add checklist items? There are different kinds, should we use permissions?

A: Directly on the Checklist will be fine. Let’s start with individuals. There are companies with thousands of people using RB, and have their own breakdown of teams.

ayrus12

He would like to be reviewed, so he can make sure his first time hacking with backbone is on the right track.

Q: Should the new patch be over the previous patch that I had submitted?

A: If it’s a replacement for the old patch but working to the same milestone, use the existing one.

Q: There’s the new installation function within djblet’s /extensions/base.py. This should be within a new request right?

A: Yes, that’s a good example of a standalone patch that can broken out.

katkat

She is going to focus on having the datagrid display without hijacking the review request list.

Q: Not completely sure what “continuation line under-indented for visual indent” means.

A: The “continuation line …”, that’s something pep8 likes to complain about, but in general, make sure it’s just looking like how the rest of the codebase does things.

Q: Should the dashboard reply list just display the non-comment reviews and maybe also indicate if the review has comments?

A: Filter reviews by doing base_reply_to__isnull=True. Replies, under the hood, are a “review” as well, but we don’t expose that.

gregwym

Had a tough week. Got a bit time to work on Saturday.

Q: Adding markdown to comments breaks the banners. Why?

A: Should always use <pre> instand of <div>. <pre> allow html display. Moving away from pre is going to be a headache all around. Requires djblets changes, RB changes.. css..

Closing

Just a reminder that we’re coming up on the end of the term soon, and we typically get inundated with code reviews. If you want prompt feedback, get things up sooner rather than later. Let us know when you need a review and make sure things are out of WIP when they’re ready.

Advertisements

Status Report — February 2nd, 2013

Greg Wang

Currently

  • I went back to resolve the problem within my first review request.
  • Discovered about how Django and Python Unit Test works.
  • Tried to write a unit test for SSH Deletion through admin page.

Roadblocks

  • The unit test always fail because it fails to pass the Django authentication system.
  • Cannot find a way to run only single unit test case (trick from StackOverflow for nose didn’t work).

Next

  • Going to finish the unit test and resolve the review request first.
  • Dig into markdown afterwards.

Questions

  • Had ask Chip about Unit test a lot, but still need more help on the Unit Test authentication.
  • (FYI, I tried to login as ‘admin’ like other tests did, but got same result.)

Jon Demelo

Currently

  • I mapped out a few future decisions for the project
  • I set up an initial version of the admin panel representation of dependencies
  • Researched Django’s view structure and how it works with ReviewBoard
  • Began contributing to the resources API file

Roadblocks

  • Getting the time to sit down and get things done.
  • Django knowledge (it’s always getting better!)
  • Dealing with drafts becoming published (and how it affects my task)
  • Infusing feature into front end with full functionality

Next

  • Work more on the API
  • Fully map out required changes.
  • Begin finalizing implementation ideas

Questions

  • None for now. 🙂

Miguel Flores

Currently

  • I have not started on a project but have decided that I would like to take on the Extensions Sandboxing project.
  • This Tuesday, my classes start so I will be starting on the project as well.

Felix

Currently

  • Reading up on Django and exploring the structure.

Roadblocks

  • Have not used Django before.

Next

  • Pick off one of the “easy bugs”

Questions

  • None

Katherine Schramm

Currently

  • Updated email repo bug (review request #3768)
  • Read more Django documentation and some code

Roadblocks

  • I haven’t set aside sufficient time for working on this project this week.

Next

  • Read more documentation/code and start trying to put something together for reviews list
  • Set-up a better work schedule for myself. The plan for this week is to set aside 3 hours for this project alone on each of Monday, Wednesday, and Friday.

Questions

  • None

Gabriel L

Currently

  • Cleaned up the CSS of the widgets in the admin in preparation of using the drag and drop from jQuery UI (for some reason the widgets on the right were using masonry, but only for one column, so replaced it with floats) And researched the ways to do the drag and drop and checked how the different widgets are built.

Roadblocks

  • Time!

Next

  • I still need to make resizable the charts in the widgets which are now with fixed width. Then when all the widgets are free from their fixed sizes, will do the drag and drop.

Questions

  • Nope

Hiroki Gohara

Currently

  • I don’t know mush what I should do.

Roadblocks

  • I don’t understand how to advance development.
  • Is there any tasks as bug fixes or should I make tasks in my own?

Next

  • not decided (I don’t understand).

Questions

  • None

Yuri Honami

Currently

  • Read jQuery documentation and practice building web service using jQuery.

Roadblocks

  • Gohara and I are in a same project(trophy), but we don’t know how to divide our tasks into two parts.

Next

  • Decide Trophy Requirements
  • Devide our tasks
  • Practice Django

Questions

  • none

Surya Nallu

Currently

  • Fixed open issues on the review request for last week’s work, ported the code to a new module.
  • Started on the Extension Browser module after discussions with Christian.
  • For now, dbjlets sends a request to a remote server seeking a list of extensions (with search parameters), expects a JSON response. This response is parsed and presented as a list of extensions (that the user searched for) available to install with it’s name, description and other relevant information.
  • Backend for processing the above and integrated this with previous week’s work; so that users can install.

Roadblocks

  • None

Next

  • Make a UI for the extension browser. This will involve the search form, presentation of results and appropriate UI to install an extension.
  • Integrate the UI with the above backend fully.

Questions

  • none

Niklas Hambüchen

Currently

  • Worked on file comments not being shown on page load, found a place to fix it, but could not reproduce on further review request, so left in a branch until I see it again.
  • Working on allowing to close the issues you’ve created, not only the person who should fix them. Control flow is clear, now looking for good implementation.

Roadblocks

  • I mostly work on RB on weekends so far

Next

  • Either look into adding a “all users from this group” or “everyone can close issues” setting (off by default)
  • or into rbtools, adding an easy way to post a “sha1..sha2 range” review, simpler than –parent

Questions

  • none