Author Archives: petahhh

TL;DR RB Workflow

Assuming you’ve set up your VM following Steven MacLeod‘s environment setup guide: https://github.com/smacleod/rb-vm-dev, this is a high level workflow for review board students.
git checkout -b your-well-described-branch // Create a branch for your task
/* Code code code */
 
git status // Identify all the files you’ve edited
pep8 python-files.py // Style check your python files
jshint javascript-files.js // Style check your python files
git add files-to-commit // Add the files you want to commit.
git status // Verify you have added everything you intend to, this is an important step to keeping clean commits
git commit -m “Your detailed commit message” // Commit your files
rbt post // Submit your commit for review
reviews.reviewboard.com (Dashboard -> OutGoing -> Open) // Your review request is in draft mode by default. Select reviewers, fill out the fields and “Publish”
/* Wait for reviews – You will be notified via email when you get one */
reviews.reviewboard.com // See all your corrections
/* Code / Make corrections */
Repeat steps inclusively between the first git status to git commit (i.e. Code, check styles, commit)
rbt post -u // This updates your review request with your corrections. 
/* Wait for review and repeat the above steps until your code gets Shipped */

Status Reports August 2nd

Peter

Project: TogetherJS Extension

Hackpad: https://reviewboard.hackpad.com/TogetherJS-Stuff-XkauVIgVsF5

  • What you accomplished this week
    • Created hub documentation
    • Created scroll update: As peer scrolls you see their position in an translucent horizontal bar.
    • Reviewed some code here and there.
    • Published blog post
    • Collected this status report
  • What you plan to do next week.
    • Restyle some extra windows I’ve discovered from testing
  • What, if anything, is blocking you from making progress?
    • No
  • Any other questions
    • No
  • Any fun weekend plans?
    • Caribana / “Festival of the Caribbean”

Raheman

Project name: Per User File Storage/DnD file attachments

HackPad: https://reviewboard.hackpad.com/DnD-functionality-for-commentreview-images.-GkNpfAx8O2k

  • What you accomplished this week.
    • To be updated
    • Unfortunately I was bedridden for much of week, having been affected
      by some bad food poisoning. As this was the portion of the week I had
      alloted to working on my project (being otherwise engaged in preparing
      for two finals that I had on Tuesday) I was unable to get any work
      done. However I have mostly recovered and intend on doing as much work
      as possible tonight.
  • What you plan to do next week.
    • To be updated
  • What, if anything, is blocking you from making progress?
    • Nothing
  • Any other questions
    •  No
  • Any fun weekend plans?
    • Ain’t nobody got time for that!

 

Salam

Project name: Updating Checklist Extension

HackPad: https://reviewboard.hackpad.com/Updating-Checklist-Extension-rx6nO0sfA1z

  • What you accomplished this week.
    • Fixed URL hook pattern to match [server]/checklist/manager/
    • Created an html page for checklist templates options.
    • Connected .less file styling through TemplateHook.
    • Created basic structure for the page using divs and css
    • Added styling for the page including colouring and padding.
  • What you plan to do next week.
    • Make the view functional, in terms of adding a new template list with name and items.

     

  • What, if anything, is blocking you from making progress?
  • Any other questions
    • How should I connect the view?
      should I extend on view.py
      or connect it with backbone and the web api?
  • Any fun weekend plans?

Matthew

Project: Extending Review Bot to allow tools to run on the entire repository

HackPad: https://reviewboard.hackpad.com/Review-Bot-access-to-entire-repository-QUHGKxc3M3R

  • What you accomplished this week.
    • Added per node repository configuration.
    • Added documentation on how I tested all my work and moved test code out of the commit.
    • Added comments and fixed small formatting things with my code.
    • Took off the WIP marker on my review request.
  • What you plan to do next week.
    • I’ll update my code as per the code review(s).
  • What, if anything, is blocking you from making progress?
    • Code review
  • Any other questions
  • Any fun weekend plans?

Volodymyr

Project name: Reviewing attachments

HackPad: https://reviewboard.hackpad.com/Reviewing-attachments-tbfh4oiwTHB

  • What you accomplished this week.
    • Iterated on existing reviews (will be updated before 10am Sunday). Unfortunately, I can’t add comments as of now.
  • What you plan to do next week.
    • Get the reviews into a better state. One landed, three ready for project branch.

     

  • What, if anything, is blocking you from making progress?
    • Nothing
  • Any other questions
    • No
  •  Any fun weekend plans?

Meeting Minutes for June 29th

Attendees

  • Mike
  • Volodymyr
  • Steve
  • Christian
  • David
  • Salam
  • Peter

Announcements

  • Midterm evaluations being sent out
  • Midterm evaluations are grades even if the courses ended now, there is still a chance to improve – direct feedback requests from mentors welcome
  • Email mentors regarding any concerns about progress

Round Robin

Volodymyr Lyubinets

  • I’m missing: serializedCommentBlocks, numRevisions, revision and attachmentHistoryId. Should I extend the existing API with these fields, or would we like to use a separate one?

    • David: makes sense to link to the relevant history object, and include the revision  but especially given serializedCommentBlocks, it makes sense to introduce something like the diff context API
  • Where is “Diff Context Resource” currently used?

    • It’s used by the diff viewer when dynamically reloading parts of the page after selecting a new revision

    • For now, makes more sense to reload the page when switching revisions
  • Priorities (in order) for rest of semester:
    • 1) Get the current code into good shape

    • 2) Add an option of choosing a revision for text, pdf and binary attachments. (With reloading for now).
    • 3) Perhaps change a UI of attachment thumbnails a bit, so that the Update button doesn’t take too much space
    •  4) Look into RBtools, and add possibility to specify which file you’re updating

Peter Tran

  • Need to add screen shots to review request – mandatory for CSS/HTML posts
  • Get user input via extension config

Salam Alyahya

  •  create the model now as per https://www.reviewboard.org/docs/manual/dev/extending/extensions/models/

Status Report for June 21st, 2014

Volodymyr

Project name: Reviewing attachments

  • What you accomplished this week.
    • Minor model change that we discussed during the meeting – separate field to denote display position, so that someone in the future might implement reordering.
    • Delete removes previous versions of the attachment as well. Right now I just modified the existing function, but we probably will have two kinds of delete (remove every revision, or just a specific one).
    • Explored codebase associated with ReviewUI. I had difficulties with following the instructions to enable image diffs, but instead I messed with js and managed to see how the image diff UI looks like (only side by side pictures, I didn’t try to get “Onion skin” and other modes working). Started exploring slider implementation.
  • What you plan to do next week.
    • Continue implementing review page for multiple revisions
    • Another iteration on current reviews
  • What, if anything, is blocking you from making progress?
    • So there are 3 different reviewUI classes (Images, text, markdown. I’m not sure about PDF, as reviews.reviewboard.org doesn’t allow reviewing PDF’s). The class that all of them extend is pretty simplistic, so it’s unlikely that I can stick anything useful there. Since I want to either get a slider that allows you to choose revision (or buttons “Next Revision / Previous Revision”, but buttons aren’t elegant), I might have to replicate the behaviour throughout all 3 classes, unless I find a good way to generalize it. I have thought about consequences this might have for existing ReviewUI classes, and don’t think there would be a problem. Review page will still have 1 item at a time, but I’ll also add a capability to specify which revision you want to look at. Once it’s decided to add ReviewUI capabilities, there probably will be a menu on review page, where you get to specify the item to diff against.
    • ^ That’s not really a description of what’s blocking me, but I spent quite a while just browsing through code versus writing it. It’s a bid hard to picture how everything would fit now.
  • Any other questions
    • David: Can you please take another look at https://reviews.reviewboard.org/r/5911/, since you were unlucky to do if before 🙂
    • Is anyone from Waterloo interested in getting together on Thursday / Friday to work on reviewboard, just like we did in Toronto?

Matthew

Project: Extending Review Bot to allow tools to run on the entire repository

  • What you accomplished this week.
    • I added extra information from the extension to the bot
      • base commit id
      • repository name
    • Tested previously written code and fixed bugs to ensure that the repositories were grabbed appropriately
    • Searched to see if I could get the branch information from code in the extension, but it looks like I just have the commit id to work with
  • What you plan to do next week.
    • Update code to code review comments
    • Get repository to specified base commit
  • What, if anything, is blocking you from making progress?
    • I need my code review and hack pad questions answered
  • Any other questions
    • No

Raheman Vaiya

  • What you accomplished this week.
    • Learned a little bit about Django models with an emphasis on the existing FileAttachment model.
    • Explored Djblets to get a better grasp of web resource API
    • Made some model changes (will have review request up soon)
  • What you plan to do next week.
    • Have the necessary changes to the models sorted out and reviewed by the
      end of the week.

     

  • What, if anything, is blocking you from making progress?
    • I am still trying to fully understand the relationship between
      Djblets/Reviewboard API Resources and Django Views. 

     

  • Any other questions
    • No

     

Peter Tran

  • What you accomplished this week.
    • Got the TogetherJS extension working and styled it in ReviewBoard fashion: hackpad here
    • Collected this status report
  • What you plan to do next week.
    • Repoint the default server to one the admin sets up

     

  • What, if anything, is blocking you from making progress?
    • No

     

  • Any other questions
    • No

     

Salam Alyahya

Project: Updating Checklist Extension

  • What you accomplished this week.
    • Iterated couple of times over the style of the extension (html/css), not using tables, to make the extension fit with RB style.
    • Changes the icon buttons on the header of extension to text buttons
    • Moved the textbox input to add a new item to the button of the layout, added a place holder text and button to clear the box
    • On hover each item in the list, the ‘remove’ item icon appears
      I created a hackpad for the project Links to anything you’ve done this week
  • What you plan to do next week.
    • Finish up the style changes
    • Start working on Templates feature for the extension

    What, if anything, is blocking you from making progress?

    • No

     

  • Any other questions
    • No

Meeting Minutes: June 1st, 2014

Attendees

Mentors: Christian, Steven, Anselina, David

Students: Peter,  Volodymyr, Raheman, Salam, Matthew

Announcements

  • Get access to the RB Students blog via David
  • Hop onto IRC with questions – Don’t wait more than a day!
  • Multiple tasking? Make a branch for each review request. Also, be very explicit with review request summaries making it easier to review form the dashboard.
  • CSS changes – include screen shots of before and after

Round Robin

Peter

  • Pseudo code drafted for notifications.
  • Need to create hackpad with design docs, UI and architecture
  • Focus on a higher level, more time spent planning is less work and mistakes later
  • Read through Django models docs

Volodymyr

  • backbone views – create vs init:
    • tutorials/singletons have a create method but most classes don’t need one
  • backbone views – $(‘body’) allowed?
    • Generally no. When constructing code in the view, create an element that can be passed in by the caller.
  • backbone views – How to make template smaller
    • Replace modalbox with what you can find in $.fn.modalBox(), you don’t need to create modalbox-bg, modalbox-inner etc from scratch.
  • attachment_id = models.IntegerField();attachment_revision = models.IntegerField(); is considered to be bad?
    • fileAttachments will have an id of a ForeignKey to the FileAttachmentHistory (allowing null values, so null=True. See DiffSet/DiffSetHistory)

Raheman

  • Updated his hackpad (including awesome video)

Salam

  • Work on the .less file instead of the .css, .css shouldn’t be committed.
  • Break up reviewable changes into separate commits

Matthew

  • passing a file path to the tools
    • put the path behind a method/property, generate it at start and can do it lazily later on.