Author Archives: rvaiya

July 19th Status Reports

Peter Tran

Project Name: TogetherJS

What you accomplished this week.

  • Fixed styling corrections from Mike
  • Fixed corrections from David
  • Bundled the JS and used the JSExtension to specify a hub instead of TogetherJS’s default hub.
  • Got a review board blog article published on the UCOSP website

Links to anything you’ve done this week

What you plan to do next week.

  • Detect Scroll position of another user

What, if anything, is blocking you from making progress?

  • No

Any other questions

  • No

Volodymyr Lyubinets

Project Name: Attachments revision

What you accomplished this week.

  • Dropdown button for attachment thumbnail, review selector for text
    (binary ones still in progress).
  • Split the diff into logical parts, collected meeting minutes last week.

Links to anything you’ve done this week

  • r/5911: might be landed soon
  • r/5824: main diff with mostly python
  • r/6119: attachment thumbnail look
  • r/6120: revision selectors

What you plan to do next week.

  • Keep iterating as usual
  • Get the attachment thumbnail change to work
  • Make a review page for binary files, which will only have revision
    selector + thumbnails.

What, if anything, is blocking you from making progress?

  • When making a dropdown button I broke the code that assigned actions to
    them, because backbone view needs them to be direct children to use
    “.element-name click function-to-call-name” syntax. I’m not sure what is a
    good solution to this.
  • I just realized that the simple review page for binary files that I was
    going to make will likely reuse the existing thumbnails … which will have
    a review link to itself. Doesn’t sound very smart. Does anyone have better
    ideas of what can the review page for binary files have apart from revision
    selector?

Any other questions

  • No

Salam Alyahya

Project Name: Checklist Extension

What you accomplished this week.

  • Fixed code from past review request
  • Implemented web api for template
  • Creates new template
  • Update content of template, including adding new template items,
    editing an item, and deleting an item

Links to anything you’ve done this week

What you plan to do next week.

  • Start implementing the setting page
  • or do testing on model and web api

What, if anything, is blocking you from making progress?

  • No

Any other questions

  • No

Raheman Vaiya

Project Name: Per User File Storage/DnD file attachments

What you accomplished this week.

  • Added accessors/mutators to prevent inappropriate manipulation
    of storage information
  • Added custom exceptions for storage violations
  • Wrote some tests for the model changes

Links to anything you’ve done this week

What you plan to do next week.

  • Have back end changes cleared by mentors
  • Start working on API changes

What, if anything, is blocking you from making progress?

  • Nothing

Any other questions

  • No

Matthew Maclean

Project Name: Extending Review Bot to allow tools to run on the entire repository

What you accomplished this week.

  • Can now patch a directory using the rbt patch functions
  • Integrated RepositoryClone into Review object, to start making the path
    accessible with the tool and allow commenting

Links to anything you’ve done this week

What you plan to do next week.

  • Finish commenting on a file based on path
  • Add to tool model so that the entire repository is optional

What, if anything, is blocking you from making progress?

  • Which version of ReviewBot and reviewboard should I be on. I rebased
    onto remotes/origin/release-0.2.x for ReviewBot and release-2.0.x for
    reviewboard but I am still getting the run_automatically field issue which
    prevents me from running the bot.

Any other questions

  • I have general questions on my hackpad

Meeting Minutes for July 6

Attendees

  • Volodymyr
  • Raheman
  • Salam
  • Mike
  • David

Announcements

  • Six weeks left until the end of the term
  • Midterm evaluations should be done soon
  • Email mentors regarding any concerns about progress

Round Robin

Volodymyr Lyubinets

  • Demo video here
  • *Vlad: * A lot of code in the existing views assumes that there are two selectors, so recycling code is difficult
  • Mike: Try extending the existing view and only overriding the necessary parts
  • Vlad: I can either preload everything or make AJAX calls when the selector state changes, the latter approach seems
    favorable since it does not require everything to be pre-loaded in advance
  • David/Vlad: The existing FileAttachment web API should be
    used, the best way to do this is to create a revision/fileattachmentid map
    from the existing data.

Raheman Vaiya

  • Raheman: I focused more on the front-end component of my project this week,
    specifically I made some changes to the way DnDUploader works to
    prevent it from stealing focus when needed by an editor view.
    (r/5954)
  • Raheman: I plan to focus on model changes next, I am unfamiliar with jasmine
    and unit testing in general so I will also spend some time familiarizing
    myself with the relevant technologies
  • David: What about the API changes?
  • Raheman: I will get to those the week after
  • David: You should be able to use the existing FileAttachment API
  • Raheman: Won’t I need to extend it so it contains ownership data in the payload?
  • David: This should already be included since the user is authenticated with the server

Salam Alyahya

(regarding Salam’s style changes)

  • Mike: The textual x should be replaced by an icon
  • Mike: The stricture of the changes is fine but some of the colors look weird, it might be a good idea to
    re-use some of the colors from top row of the review-request box
  • Salam: A prototype for the extension’s template feature can be found here here
  • David: Simplify the templating system. Instead of allowing the user to cherry pick the desired items from the template, just
    import everything and leave it to the user to edit the result in the checklist.

Meeting Minutes for June 15, 2014

Announcements

  • There are 8 more meetings remaining until the end of the term.
  • Status reports should come in as soon as possible.
  • Include a title or link to your project description in your status reports

Round Robin

Salam

  • Cleared up confusion surrounding project switch/goals (Still assigned to the
    Checklist extension project)
  • Rework current stuff so it is consistent with Reviewboard’s styling.
  • Original spec for the Checklist Extension can be found
    here

Volodymyr

  • To maintain ordering of file’s in a review request it was resolved that a
    field indicating order should be added to the FileAttachmentHistory model.
  • Attachment diffs should work like regular diffs in that it should be
    possible to compare two arbitrary revisions using some kind of slider
  • Use existing ReviewUI classes for diffing different kinds of Attachments
  • Further feedback will be given on review request this week

Matthew

  • Matthew wasn’t sure where to find the commit id
  • smacleod mentioned that the base commit id should be part of the diffset
    model and won’t be found in the request object.
  • See handlers.py for an example
  • Additional questions on Matthew’s hackpad.

Raheman

  • DnD file editor code ready for review.
  • Intend to start to start working on back-end stuff this week.

Peter

  • Having trouble getting reviewboard to recognize extensions
  • heapify suggested changing django.conf.urls.defaults to
    django.conf.urls since the former is now deprecated in Django
  • m_conley answered some of Peter’s hackpad questions

Status Reports: June 1, 2014

Peter Tran

1. What you accomplished this week

2. What you plan to do next week

  • Adapt changes from the mentors to the architecture if there are any.
  • Create test cases for the basic functionality of the system at the object level.  (Creation, replying, completing).

3. What, if anything, is blocking you from making progress?

  • I just need approval of the architecture to proceed.

4. Any other questions?

  • Is my proposed architecture flexible enough to be extended for feature  purposes?
  • When a user does stuff on RB, do all the requests get handled through the  webapi? If so, is my next step (after testing the basic architecture) be to  create post handlers for creating/responding and completing requests?

Volodymyr Lyubinets

1. What you accomplished this week

  • Started writing a backbone view for attachment uploads. I have the basic version, but it’s very poorly written. I need to ask some basic questions about this. This view can pass sequence id to the server, which is what I needed for
    my project.
  • Implemented handling of sequence data, and verified that it works correctly.
  • Reviews: https://reviews.reviewboard.org/r/5911/ and https://reviews.reviewboard.org/r/5824/

2. What you plan to do next week

  • Iterate on existing reviews
  • Modify the logic behind displaying thumbnails to show only fresh version of each file
  • Start playing with the new review interface for attachment – we would like users to be able to view/compare revisions of their files. I already store sequence_id and position_in_sequence data, which is what I need.

3. What, if anything, is blocking you from making progress

  • I haven’t heard back regarding my model change. I still assume it’s the right way to go, because of it’s simplicity (Just 2 new fields added to the FileAttachment table. This seems to be a better approach than creating new tables or sticking something into M2M tables).

4. Any other questions?

  • To be asked during the meeting.

Raheman Vaiya

1. What you accomplished this week

  • Wrote a basic mockup of the frontend component of my project (hackpad to be updated with details shortly.)

2. What you plan to do next week

  • Polish mock-up and structure code appropriately.
  • Possibly start implementing components which will ultimately interact with the webapi code on the backend (start thinking about API requirements for user file storage).

3. What, if anything, is blocking you from making progress

  • Nothing

4. Any other questions?

  • No

Salam Alyahya

1. What you accomplished this week

  • Switched projects to Checklist extension.
  • Fixed issue where the extension was not accepted by python.
  • Fixed the issue where the extension didn’t show up because it was not registered to the pages right in ‘apply_to’ (https://reviews.reviewboard.org/r/5890/).
  • I worked on the styles and colours of the extension. I changed the colours, and changed the format to be encapsulated in a table for better styling. Icon files were not included, so I added mine, and made the necessary changes. Also, I encapsulated the extension template with ‘<div>’ so that it gives it enough padding to let the minimize button show. The buttons to delete items in the list were taking the shape of a ladder rather then being vertically aligned, the issue was fixed by adjusting margin (https://reviews.reviewboard.org/r/5904/).

2. What you plan to do next week

  • TBD

3. What, if anything, is blocking you from making progress

  • I need to discuss what specifically needs to be done for the checklist extension.

4. Any other questions?

  • I was thinking of implementing the ability to drag the list around the page by
    holding click on the top header bar.

Matthew Maclean

1. What you accomplished this week

  • Rewrote my hackpad to relfect the architecture design decisions and
    questions I have.
  • Played around with git in python a bit more while I wait to talk about the
    hackpad.

2. What you plan to do next week

  • Chat with Steven about my architecture stuff, then get the bot side of the feature working.
  • I also plan to try to work on stuff earlier in the week this time around.

3. What, if anything, is blocking you from making progress

  • Chat about the architecture.

4. Any other questions?

  • No