Author Archives: tbelaire

[UCOSP] Status Reports for week March 1st to March 7th

Theo Belaire
1. What project are you working on?
-review board tool.
2. What you accomplished this week.
-Thought about the speeding up rbt post -u via caching the review id.
3. Links to stuff you’ve done.
Faster rbt post -u
4. What you plan to do next week.
Write tests, land the old parent base code.
5. Any blockers?
Homework of doom.
6. Other questions
N/a

Chester Li
1) What project are you working on?
  • Post-commit review request support for GitLab
 
2) What you accomplished this week.
  • Made post-commit support for GitLab work on my local server.
  • Wrote unit tests for review request #6786 and #6872
  • Did some code reviews.
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Finish up unit tests and land the whole project.
  • If the project will be done next week, I would like to start a new one.
5) What, if anything, is blocking you from making progress?
  • GitLab API string format.
6) Any other questions
  • N/A

Jessica Yuen
1. What project are you working on?
rb-gateway
2. What you accomplished this week.
– Finished fixing issues surrounding post-commit APIs on rb-gateway; landed
– Refactored rb-gateway URLs to use path parameters over query parameters; landed
– Implemented all post commit APIs on RB’s side, tested that they work
– Did a couple code reviews
 
3. Links to anything you’ve done week:
4. What you plan to do next week.
This week will all be about testing. 😦
– Implement post commit UI unit tests on RB’s side
– Implement a testing suite / framework for rb-gateway
– Hopefully get #6850 landed (after adding more tests and fixing future issues)
– Discuss what’s next for this project
 
5. What, if anything, is blocking you from making progress?
– N/A
 
6. Any other questions.
– Where should I be taking rb-gateway (in terms of new APIs / other features) after I complete ‘What you plan to do next week.’?

Tien Vu
1. What project are you working on?
DiffDoctor
2. What you accomplished this week.
Copy pasted from my commit messages
commit 81d9a173ca1e287a91790b5bc81307bc91395dda
Author: Tien <tienv@sfu.ca>
Date:   Sat Mar 7 18:09:13 2015 -0800
Move location of diff file rejection download
Summary of changes:
– Deleted PatchErrorView, instead rendering content in ReviewsDiffFragmentView
– Simplified get() function in PatchErrorDownloadView
– Add exception handling for SCMErrors (which are in turn thrown when HTTPErrors are thr
– Added a wrapper in DiffFragmentView to let subclasses insert extra context variables w
– Change template code in diff_fragment_error.html to display Diff Doctor information
commit daceec0d39a53f0fe6daefe832ea345ce48f6d46
Author: Tien <tienv@sfu.ca>
Date:   Tue Mar 3 21:01:12 2015 -0800
WIP: introductory phase for Diff Doctor
Summary of changes:
– Created a view for viewing patch results
– Created a view for downloading patch files (does not work yet)
– Created a PatchError class, which is now caught by ReviewDiffFragmentView
3. Links to anything you’ve done week:
Diagram depicting my idea of the DiffDoctor project + steps to do
Also read up on Django templates, and the custom template tags defined in djblets. I will need this knowledge
4. What you plan to do next week
– Attend to my old project @ https://reviews.reviewboard.org/r/6833/, do any necessary clean-ups
– Improve code based on feedback for DiffDoctor, to land “Introductory step of project”. I am pretty sure the code works (views, exception handling, and the zip download), however there could be other side problems.
– Start looking at “phase 2”: diagnosing the “real” problem behind patch() failure and display useful content in diff_fragment_error.html.
5. What, if anything, is blocking you from making progress?
– Nothing too special, I guess I am used to getting stuck by now 😀
6. Any other questions.
– This project is somewhat weakly defined. It’s supposed to be, I understand, and want to move in the right direction. I would like to know if Christian’s description of tasks fits with my diagram of the project
Also, whether I’ve implemented the “introductory step” correctly, with description in
– I feel like I should do some code reviews, but also feel that I don’t know enough about the code architecture or Python (yet) to do so. Investigating unknown code takes time, going through it will be inefficient (time is limited). Is there a project that is somewhat related to what I’m doing (like stuff in reviews/views, diff fragments…) that I can take a shot at?


Vincent Le

1) What project are you working on?

– File Provider Framework

2) What you accomplished this week.

– Drew up one mock image
– Refactored File_Provider_File to File_Provider_Node
– Changed the initialization of Node/File/Dir in reviewboard.fileproviders.tree
– Started working on the UI, with mock data
– Added some functionality to the upload dialog view
– Started working a bit on the models for the webapi (backbone side)

3) Links to anything you’ve done this week:

– FileProvider UI Mockup: https://reviewboard.hackpad.com/File-Provider-UI-mockup-hlsI7BmPjzq
– FileProvider module implementation with Django: https://reviews.reviewboard.org/r/6806/
– FileProvider WebApi integraton: https://reviews.reviewboard.org/r/6948/
– [WIP] FileProvider Framework UI: https://reviews.reviewboard.org/r/7009/

4) What you plan to do next week.

– Add some more functionality to the view
– Have the models work with the json payload from webapi
– integrate model into the view

5) What, if anything, is blocking you from making progress?

– BackBone.JS, don’t fully understand it

6) Any other questions

– None


 Christopher Arnold

1) What project are you working on?
  • Mute and Archive Review Requests
2) What you accomplished this week.
  • finished banners
  • implemented automatic refreshing
  • finished unarchiving
  • finished all of muting and unmuting
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • implement automatic unarchiving (on new activity)
  • rename the show/hide archived button to show/hide hidden
    • is “hide hidden” okay for wording??
  • write tests
5) What, if anything, is blocking you from making progress?
  • (from two weeks ago) my “show-archived=1” URL query seems to work fine except when I want to combine it with other queries, such as “?view=outgoing”. I am able to append my own query with a “&” but my problem is when the query is already combined “?view=outgoing&show-archived=1” and I want to change the 1 to a 0. I am trying to figure out how to index strings or either rethink the logic and am currently stuck here
6) Any other questions
  • how should I approach simultaneously removing all archived states for one review request? currently the webAPI can only unarchive one review request per user
  • will the issues we bring up in “5) what is blocking you” be answered in these status reports or should they be more for Slack?
  • is there a way to add/edit a previous diff’s Change Summary?
  • is “hide hidden” okay for wording??
  • what other things should I consider for this project besides what I mentioned in “4) What do you plan to do next week?”


 Jason Tseng

1) What project are you working on?
  • Responsive UI
2) What you accomplished this week.
  • Updated some code styling according to feedbacks. Didn’t get to have much done this week due to travel.
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Code cleaning for Responsive UI
5) What, if anything, is blocking you from making progress?
  • N/A
6) Any other questions
  • How long do we have till end of the program? Possibility in starting new project?