Author Archives: vinle

[UCOSP] Status Reports: March 15th to 21st


Vincent Le

1) What project are you working on?
– FileProvider framework

2) What you accomplished this week.
– Made changes as suggested by Christian and Barret in my reviews
– Added search logic to show search results on the options for selection. Search result is displayed after 500ms after the last key up in the search field, or display the current path when search field is empty.
– Started implementing display metadata for selected files
– Did some small refactoring for my JS file
– Fixed a bug regarding metadata in my test cases and testing class for FileProviders

3) Links to anything you’ve done this week:
– FileProvider module implementation with Django : https://reviews.reviewboard.org/r/6806/
– FileProvider WebApi integraton : https://reviews.reviewboard.org/r/6948/
– [WIP] FileProvider Framework UI : https://reviews.reviewboard.org/r/7009/

4) What you plan to do next week.
– Finish display metadata
– Make my file navigation for FileProvider modal compatibile with any provider
– Get to create accounts

5) What, if anything, is blocking you from making progress?
– Nothing I can think of yet

6) Any other questions
– Nothing I can think of yet


Chester Li

1) What project are you working on?
  • Post-commit review request support for GitLab


2) What you accomplished this week.
  • Refactored code for 2 review requests according to reviews.
  • One bug fix has been submitted
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Start a new project, do as much as I can
5) What, if anything, is blocking you from making progress?
  • I was basically waiting for the review and did some changes.
6) Any other questions
  • Not yet


Tien Vu

1) What project are you working on?
    – Diff Doctor
2) What you accomplished this week.
    – In summary, replaced failed patch traceback with inline Pygments, as collapsible links. I tried to figure out how to make it like the plus button for a review request change, but I lack the frontend knowledge, so I’m sticking with <a href>.
3) Links to anything you’ve done this week:
    – Learned how to use Pygments: http://pygments.org/docs/
4) What you plan to do next week.
    – Decide what to do when patch fails because of a non PatchError (like SCMError). Right now it just links to a template that displays the error like {{ error.msg }}.
    – After this, is there anything major left to do for my 2 projects? For Diff Doctor, Christian suggested me to skip “step 2” of analyzing the source problem of failing the patch, but we agreed to skip over this because it’s too complicated for now. The other 2 parts of showing the .zip and showing the reject files instead of the traceback works. Should I pick a smaller project to work on?
5) What, if anything, is blocking you from making progress?
    – How can I land my changes to master? Should I at least push my branch(es) up?
6) Any other questions
    – No


Jessica Yuen

1. What project are you working on?
rb-gateway
2. What you accomplished this week.
Sorry I’ve been a super occupied with other work this week…
– Fixed outstanding issues on existing review requests (7053 & 7054)
– Added unit testing for configuration loading

3. Links to anything you’ve done week:
4. What you plan to do next week.
– Since Pencils Down is a week and half from now, I think I’ll just concentrate on adding any missing test cases, getting rb-gateway to a polished state. I think it’s already pretty complete for the features that have been requested so far, but let me know if I’m wrong.

5. What, if anything, is blocking you from making progress?
– N/A

6. Any other questions.
– Nope.


Chris Arnold

1) What project are you working on?
  • Mute and Archive Review Requests
2) What you accomplished this week.
  • handled automatic unarchiving
  • fixed URL query
  • split up project into smaller review requests
3) Links to anything you’ve done this week:
4) What you plan to do next week
  • attend to several reviews by David and Barret
  • getting used to the workflow of using several review requests that depend on each other
  • tests
5) What, if anything, is blocking you from making progress?
  • the splitting up of my project
6) Any other questions
  • I’ve split up my project, but it’s been trickier than I thought, especially when trying to decide which line of code belongs to which review request… Working on my project seems a lot more fragile now, and my pace has definitely slowed down. It seems like I need to rebase AND rbt post up to 3 branches whenever I want to make a change, since all my review requests rely on each other.
    • Any tips out there that I could use to make this process easier?
    • Is there a slick way to transfer changes from one review request to another?


Jason Tseng

1. What project are you working on?

Responsive UI

2. What you accomplished this week.

– Additional aesthetic update on part 1

– Changes applied to the rest

– half way on secondary menu button design

3. Links to anything you’ve done week:

– https://reviews.reviewboard.org/r/6796

4. What you plan to do next week.

– Finish secondary menu button

5. What, if anything, is blocking you from making progress?

– passing review on part 1

6. Any other questions.

– Nope.

[UCOSP] Status Reports: Jan 31, 2015


Chester Li

1. What project are you working on?

  • I am working on post-commit review requests for GitLab, will continue fixing issue 3704 after the project.

2. What you accomplished this week.

  • get_branches() function (not tested).
  • get_commits() function (not tested).
  • get_change() function (not tested).
  • Partially GitLabClient class (WIP).
  • Read some GitLab documents.
  • Get better understanding on the server side the project.

3. Links to anything you’ve done week:

4. What you plan to do next week.

  • Keep working on GitLab post-commits, figure out how some functions and variable work. Hopefully I will finish them and get some time to write unit test from new functions.

5. What, if anything, is blocking you from making progress?

  • Lack of knowledge on Django and GitLab, no one if group has strong background about GitLab. The project needs more work to be done than it was planned.

6. Any other questions.

  • Not yet


Chris Arnold

1) What project are you working on?

  • Mute and Archive Review Requests

2) What you accomplished this week.

  • added visibility field to ReviewRequestVisit with visible (V) and archived (A) states
  • added show_archived attribute to DashboardDataGrid
  • added a query that filters archived requests to ReviewRequestManager
  • wrote and applied a evolution for visibility in the ReviewRequestVisit table
  • decided not to go ahead with creating a new ReviewRequestVisitManager
  • learned more about sqlite dbshell
  • major re-organization of hack pad

3) Links to anything you’ve done this week:

4) What you plan to do next week.

  • add a button that toggles visibility
  • if there’s time, start writing tests
5) What, if anything, is blocking you from making progress?
  • not at the moment
6) Any other questions
  • how many review requests should we be making? one per project? one per milestone?
  • when is a review request no longer a WIP?
  • what’s the different between a username and a user_or_username?
  • when/where will these questions be answered in these status reports?? 😛
    • should we ask all of this in Slack?


Jason Tseng

1) What project are you working on?
  • Responsive UI
2) What you accomplished this week.
  • Added relating css/js changes to “Dashboard”, “New Review Request”, “My Account”
  • Researching on em vs px
  • Designing Responsive UI look
  • [WIP] User page
3) Links to anything you’ve done this week:
4) What you plan to do next week.
  • Obtain suggestions/discussion on sub-menu display
  • finish admin & user/individual page
5) What, if anything, is blocking you from making progress?
  • n/a
6) Any other questions
  • Anyone with interest on front-end ui discussion? 


Jessica Yuen

1) What project are you working on?

  • rb-gateway, a service for managing your repositories.

2) What you accomplished this week.

  • git2go integration for executing git commands on a repository
  • added a README to detail installation
  • Code refactoring
  • Added a sample config json
  • HTTP access logging
  • Added and registered a hosting service to Review Board called ReviewBoardGateway in a new rbgateway.py file (still super basic)

3) Links to anything you’ve done this week:

4) What you plan to do next week.

  • Complete the HostingService implementation

5) What, if anything, is blocking you from making progress?

  • Not really any, but answers to the questions below will really help.

6) Any other questions

  • I’m still a bit confused about my project. If they can already directly point to a local repository path, by choosing Custom Repository (None) when adding a new repository, wouldn’t it defeat the purpose to have them use rb-gateway instead? Maybe I am misunderstanding something. If rb-gateway is hosted on another url anyway, how is it better than github or their own custom hosting service? Sorry, I’m really confused… If someone could answer in terms of comparing it to GitHub and directly pointing it to a local repository, it would really help.
  • What url will rb-gateway be hosted at so that I can make http requests to it? (right now I’m using localhost:8888). I probably need a optional configuration for it in .reviewboardrc?


Theo Belaire

1) What project are you working on?

  • RBtools

2) What you accomplished this week.

  • Found out about `git name-rev`, to find out which branch a commit is on.
  • Made more tests pass, and started working on factoring out the hard coded ‘origin’ remote.
  • Small enhancement to rbtool, aborting if the editor returns a non-zero exit code, had an initial patch thrown together. Still needs testing, and some feedback.
  • Learned about nosetests –failed

3) Links to anything you’ve done this week:

4) What you plan to do next week.

  • Finish configuration propagation. I might make a dummy command to understand how this all works.

5) What, if anything, is blocking you from making progress?

  • I know this was explained to me in slack, but I can’t search for it.
  • I need to know more about the configuration process and lifecycle.

6) Any other questions?

  • Not as of yet.

Tien Vu

1. What project are you working on?

  • I am working on adding user-defined templates to rbt commands that generate an auto commit-message.

2. What you accomplished this week.

  • add a default template for the commit message (with the exact same format as it was before)
  • add command line options (–template) to rbt patch for users to specify their own templates
  • add similar options to the config file .reviewboardrc (i also found out how this file was read, pretty interesting :D)

3. Links to anything you’ve done week:

4. What you plan to do next week.

  • read PEP8 and clean up the review bot complaints in my review request.
  • add unit test(s) to my feature
  • do any final work to get this feature merged
  • select a new project idea and get going from there
  • Also, if time allows, I would like to take a peek and have more of an idea of what other students are doing in their projects.

5. What, if anything, is blocking you from making progress?

  • Nothing I can’t handle for now.

6. Any other questions.

  • No questions.


Vincent Le

1) What project are you working on?

  • Working on the “File Provider framework”

2) What you accomplished this week.

  • Made adjustments suggested on my Review Request
  • Worked on GET, POST, DELETE and PUT calls and their respective test cases for the webapi
  • Did some analysis into djablets/webapi/resources.py
  • Planning out on how to approach the search, get files, get folder content, etc

3) Links to anything you’ve done this week:

4) What you plan to do next week.

  • Continue the planning above
  • Try to implement the webapi calls for those mentioned
  • Implement the test file providers further for testing webapi calls (reviewboard/testing/fileprovider.py)

5) What, if anything, is blocking you from making progress?

  • None yet

6) Any other questions

  • None yet