Author Archives: vlyubin

Status reports for July 26

Matthew

Project: Extending Review Bot to allow tools to run on the entire repository

HackPad: https://reviewboard.hackpad.com/Review-Bot-access-to-entire-repository-QUHGKxc3M3R

  • What you accomplished this week.
    • I added a field to the ReviewBot tools for if the working_directory is required. This is configurable depending on the Tool base class used. The admin panel of the extension displays the new field.
    • Added a cached_property decorator to the project.
    • No longer copy the .git folder for a project. As a result, I changed how I apply a patch to a repository.
    • Added the Repository_Clone object into Review object and instantiate it if the tool requires the entire repository.
    • Added support to comment on a file based on it’s path. Only changed files can be commented on.
    • Created Tool to test working with the entire repository.
    • I reviewed Salam’s code: https://reviews.reviewboard.org/r/6106/
  • What you plan to do next week.
    • I will make changes according to review comments.
    • I also need to talk with Steven about steps moving forward, as this is the MVP.
  • What, if anything, is blocking you from making progress?
    • Review request for my new code.
  • Any other questions
    • No

Raheman

Project name: Per User File Storage/DnD file attachments

HackPad: https://reviewboard.hackpad.com/DnD-functionality-for-commentreview-images.-GkNpfAx8O2k

  • What you accomplished this week.
    • Started to reconsider the necessity of model/api changes.
    •  Developed a better understanding of how file attachments interact with the
      existing webapi resource.
  • What you plan to do next week.
    •  Modify my front end code to interact with the existing FileAttachment resource.
      Have a finished (but untested product) by the end of the week.
  • What, if anything, is blocking you from making progress?
    • Nothing
  • Any other questions
    •  Upon dropping should the final link be displayed or is it
      ok to use a placeholder instead?

     

Peter

Project: TogetherJS Extension

HackPadhttps://reviewboard.hackpad.com/TogetherJS-Stuff-XkauVIgVsF5

  • What you plan to do next week.
    • Whatever is left from three items above
  • What, if anything, is blocking you from making progress?
    • I’m having issues with pep8. I’m trying to fix this: https://reviews.reviewboard.org/r/6102/#comment16064 but every time I indent or unindent ReviewBot switches between being over indented and under indented.
    • When I run pep8 locally, it does not return the above correction.
  • Any other questions
    • No

Salam

Project name: Updating Checklist Extension

HackPad: https://reviewboard.hackpad.com/Updating-Checklist-Extension-rx6nO0sfA1z

  • What you accomplished this week.
    • Defined URLHook, to attache a view for the template feature
    • Connected the templates resource api to the model
    • Defined a view.py that returned the default template.
    • Worked on html and css of the options page
  • What you plan to do next week.
    • finish implementing view.py

     

  • What, if anything, is blocking you from making progress?
    • Nothing
  • Any other questions
    • No

Volodymyr

Project name: Reviewing attachments

HackPad: https://reviewboard.hackpad.com/Reviewing-attachments-tbfh4oiwTHB

  • What you accomplished this week.
    • Fixed the new thumbnail look and functionality – it works now (review to be updated)
    • A generic review for files without a tyoe-specific handler
    • Iteration on https://reviews.reviewboard.org/r/5911/
  • What you plan to do next week.

     

  • What, if anything, is blocking you from making progress?
    • Nothing
  • Any other questions
    • No
Advertisements

Meeting minutes for July 13

Attendees

  • Matt
  • Volodymyr
  • Raheman
  • Salam
  • Peter
  • Mike
  • Steven
  • David
  • Christian
  • Anselina

Announcements

  • Five weeks left until the end of the term
  • Midterm evaluations are out
  • Germany won the World Cup

Round Robin

Volodymyr Lyubinets

  • Current UI for review of attachments is OK, work on thumbnail UI
  • Keep iterating

Matt Maclean

  • SMC tools: How to get request id form review request? Answer: Client code works by dynamically creating attrs on the Python object based on what comes back from the WebAPI. Also see https://www.reviewboard.org/docs/rbtools/dev/api/overview/
  • Synced up with smacleod on architecture questions

Peter Tran

  • Received guidance from Christian regarding how to interact with extension settings using JSExtensions
  • Needs more time to look into JSextensions examples
  • Line 164 of https://github.com/reviewboard/rb-extension-pack/blob/master/rbseverity/rbseverity/static/js/severity.js – what’s happening there? Answer: That line is just subclassing Extension. There’s a template tag used on every page that iterates through all registered JSExtensions in Python. Those point to the name of your RB.Extension subclass (here, RBSeverity.Extension)

Raheman Vaiya

  • Working on understanding the concept of form (in Django)
  • Is binary data is a separate part of the http request? Answer: it’s part of the POST data, stored as request.FILES
  • Running individual unit tests – see https://reviewboardstudents.wordpress.com/2011/09/24/running-subsets-of-review-board-tests/
  • Specifically, UploadFileForm, because it doesn’t appear to have rendering there. Answer: we render it in a template to a javascript payload, which we then turn into a formDlg

Salam Alyahya

  • Will be working on making a new web API for his project. See https://github.com/djblets/djblets/blob/master/djblets/webapi/resources.py and https://www.reviewboard.org/docs/manual/dev/extending/extensions/webapi/ for directions
  • Landed a couple of changes during the last week

Status Reports for June 28, 2014

Volodymyr

Project name: Reviewing attachments

HackPad: https://reviewboard.hackpad.com/Reviewing-attachments-tbfh4oiwTHB

  • What you accomplished this week.
    • I built a prototype for attachment revision selection. Only works for images right now, but it’s easy to extend. Check out a video at https://www.youtube.com/watch?v=e4-b9SiWwiQ
  • What you plan to do next week.
    • Iterate on feedback from reviews
    • Keep building the attachment revision panel
  • What, if anything, is blocking you from making progress?
    • Nothing
  • Any other questions
    • I looked into extending existing view to change the revision, but I wasn’t very successful. Essentially, to make it work, I would have to add lots of ‘if’s’ to handle things differently depending on which scenario I need. This is not a very good practice, so it might be better to have a separate component. I’ll reuse as much code as I can. I won’t need any new styles, just a small backbone view.

Matthew

Project: Extending Review Bot to allow tools to run on the entire repository

HackPad: https://reviewboard.hackpad.com/Review-Bot-access-to-entire-repository-QUHGKxc3M3R

  • What you accomplished this week.
    • Updated code to review comments and hackpad questions
    • Create temp folders for copied repositories
    • Switch commit id based on base commit
  • What you plan to do next week.
    • Test edge cases on commit id
    • Apply changes to commit
  • What, if anything, is blocking you from making progress?
    • Nothing
  • Any other questions
    • No

Raheman Vaiya

Project name: Per User File Storage/DnD file attachments

HackPad: https://reviewboard.hackpad.com/DnD-functionality-for-commentreview-images.-GkNpfAx8O2k

  • What you accomplished this week.
    • Fixed some issues with DnD editor as per Mike’s suggestions as well as some drag event related issues (/r/5954)
  • What you plan to do next week.
    • Finalize/test model changes
  • What, if anything, is blocking you from making progress?
    • Nothing
  • Any other questions
    • No

     

Peter Tran

Project: TogetherJS Extension

  • What you accomplished this week.
    • Overrode the default togetherjs hub with a fake one
  • What you plan to do next week.
    • Collect input from RB Admin with specified hub and pass it over to TogetherJS config options
  • What, if anything, is blocking you from making progress?
    • How do I pass input stored in the db to say a javascript file?
  • Any other questions
    • No

Salam Alyahya

Project name: Updating Checklist Extension

HackPad: https://reviewboard.hackpad.com/Updating-Checklist-Extension-rx6nO0sfA1z

  • What you accomplished this week.
    • Migrated the prototype I made in fiddle to Checklist extension and pushed a review request
    • Created prototype for template feature on fiddle.
  • What you plan to do next week.
    • Dive in deeper with the template feature, and figure out what exactly needs to be modified to implement the feature.

     

  • What, if anything, is blocking you from making progress?
    • Nothing
  • Any other questions
    • No

Meeting Minutes: June 8, 2014

Attendees

Mentors: Christian, Steven, Anselina, David

Students: Peter,  Volodymyr, Raheman, Salam (partially), Matthew

Announcements

Round Robin

Peter

Volodymyr

  • Worked on existing review requests; still exploring the codebase.

Raheman

  • Working on markdownEditorView and API structure; posted WIP review.

Salam

  • See the status report.

Matthew

  • Needs review of current code plus some hackpad answers.