Category Archives: Uncategorized

[Open Academy] Status Reports, April 25, 2015

Wen Jifei
1. What project are you working on?
pep257 && shellcheck
2. What you accomplished this week.
fix bug in pep257 && fix bug in shellcheck
3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7101/
https://reviews.reviewboard.org/r/7197/
4. What you plan to do next week.
continue doing pep257 and spellcheck
5. What, if anything, is blocking you from making progress?
none
6. Any other questions.
none

Chen Sihang
1. What project are you working on?
Add an unreviewed section to my Dashboard
2. What you accomplished this week.
Have some tests done and fix some previous issues.
3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7193/
4. What you plan to do next week.
Continue working on that project and have more tests done.
5. What, if anything, is blocking you from making progress?
No.
6. Any other questions.
No.

Teresa Fan
1. What project are you working on?
Better Linking in the UI
2. What you accomplished this week.
Got a better understanding of the project (like where the links should go), added a working link icon for each comment.
3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7254/
https://reviewboard.hackpad.com/Teresas-Notes-gI6ljBKu7ra
4. What you plan to do next week.
Moving the link icon to be inline with the comment text, as per Christian’s suggestion. Adding link icons for replies.
5. What, if anything, is blocking you from making progress?
It’s the end of the semester so I have a lot of final projects and assignments all due around the same time, so I haven’t gotten much time to work on this yet.
6. Any other questions.
No

Chen Feng
1. What project are you working on?
Create a new plugin.
2. What you accomplished this week.
Post my project and fixed the bug I have posted.
3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7191/
https://reviews.reviewboard.org/r/7231/
4. What you plan to do next week.
Continue working on my project
5. What, if anything, is blocking you from making progress?
Something myself.

Tran Nguyen
1. What project are you working on?
Extension testing framework
2. What you accomplished this week.
Tracing the execution path of one of the extension.
Fixed some new comments from Barret for old issues.
3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7066/
https://reviews.reviewboard.org/r/6879/
4. What you plan to do next week.
Continue my work on extension testing.
5. What, if anything, is blocking you from making progress?
The time of the semester when everything is due.
6. Any other questions.
No

Chenxi Ni
1) What project are you working on?
OAuth2 provider support
2) What you accomplished this week.
Finished the tutorial and understand how it works
3) Links to anything you’ve done this week (hackpads, review requests,
blog posts, etc)
My RR for my first project: https://reviews.reviewboard.org/r/6990/
My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP
4) What you plan to do next week.
Find the way to apply a simple function to ReviewBoard
5) What, if anything, is blocking you from making progress?
I did find something about API token validate, but where did we validate the local site, ie /s/<sitename>/?
6) Any other questions
See the 5th question,plz.

Chen Mingyi
1. What project are you working on?
Add infinite scrolling to the diff viewer
Read-only site mode
2. What you accomplished this week.
Click the button and will have a notice.
3. Links to anything you’ve done week
No for this week.
4. What you plan to do next week.
Continue to add a notice bar to the whole website.
5. What, if anything, is blocking you from making progress?
There is other things to do, so have little done. No blocked. Thanks Mike 🙂
6. Any other questions.
Not now. 🙂

Stanley Yeo
1. What project are you working on?
Auto-add users to groups
2. What you accomplished this week.
Wrote unit tests and comments
3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Stanleys-Note-y91i8NygfSk
https://reviews.reviewboard.org/r/7165/
4. What you plan to do next week.
Don’t know yet. Need to ask.
5. What, if anything, is blocking you from making progress?
No.
6. Any other questions.
Chris, please review 7165.

Rohan Meringenti
1. What project are you working on?
Revokable Ship its
2. What you accomplished this week.
Refactored code to address issues on review request
Updated all review requests (Finishing up in like an hour)
Added tests to revokable ship its.
3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7170
4. What you plan to do next week.
Code Review, and add extra features to highlighting active discussion if time allows
5. What, if anything, is blocking you from making progress?
No.
6. Any other questions.
Chris, please review 7165.

[Open Academy] Status Reports, April 18, 2015

Mingyi Chen

1. What project are you working on?

  • Add infinite scrolling to the diff viewer
  • Read-only site mode

2. What you accomplished this week

  • Read the code, find how many should be stopped.
  • Add a button to stop admin settings.

3. Links to anything you’ve done this week
https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY

4. What you plan to do next week

Add a notice bar to the whole website.

5. What, if anything, is blocking you from making progress?

How many functions do review board have, and how many should be stopped.

6. Any other questions?

The previous project is still waiting for review!


Sihang Chen

1. What project are you working on?

Add the unreviewed section to my dashboard.

2. What you accomplished this week

Finish the counting function of the incoming unreviewed review requests.

3. Links to anything you’ve done this week
https://reviews.reviewboard.org/r/7193/

4. What you plan to do next week

Done some tests and change the codes.

5. What, if anything, is blocking you from making progress?

No.

6. Any other questions?

Nope, will ask on Slack if I have.


Teresa Fan

1. What project are you working on?

Interactive Issue Summaries

2. What you accomplished this week

Fixed up my code based on review comments (and solved some git issues).

3. Links to anything you’ve done this week

4. What you plan to do next week

Continue working on that review request until it’s ready to be shipped.

5. What, if anything, is blocking you from making progress?

More reviews are welcome! Also, see below

6. Any other questions?

What would be best for me to do next, considering I only have a couple weeks left in my semester?


Sun Wang Jun

1. What project are you working on?

Checklist extension

2. What you accomplished this week

Fixed trivial issues raised in my review requests

3. Links to anything you’ve done this week

4. What you plan to do next week

Clear the remaining issues raised

5. What, if anything, is blocking you from making progress?

Projects and exams

6. Any other questions?


Wu Di

1. What project are you working on?

  • Better diff comment bubbles
  • Allow replying to reviews from the diffviewer

2. What you accomplished this week

Relooked at jQuery’s draggable and resizable following Christian’s comments in my review, but still found it unsuitable for moving and resizing the comment bubbles.

3. Links to anything you’ve done this week
https://reviewboard.hackpad.com/Wu-Dis-Notes-sULvWjtXN56

4. What you plan to do next week

Fix outstanding issues in my review request.

5. What, if anything, is blocking you from making progress?

Projects and exams.

6. Any other questions?


Xuanyi Lin

1. What project are you working on?

Framework and UI for integrating with third-party services

2. What you accomplished this week

  • Fixed issues in my reviews
  • Add Config template to integration forms
  • Implement Rbslack with integration framework

3. Links to anything you’ve done this week

4. What you plan to do next week

Fix issues for my reviews.

5. What, if anything, is blocking you from making progress?

6. Any other questions?


Feng Chen

1. What project are you working on?

Create a new plugin

2. What you accomplished this week

Download Review Bot and find the direction to write the plugin.

3. Links to anything you’ve done this week

4. What you plan to do next week

Complete the project.

5. What, if anything, is blocking you from making progress?

Basketball Competition and my course.

6. Any other questions?


Chenxi Ni

1. What project are you working on?

OAuth2 provider support

2. What you accomplished this week

Set the environment of OAuth2

3. Links to anything you’ve done this week
https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP

4. What you plan to do next week

Try to submit a WIP review for my project. Write basic code such as adding models to Django.

5. What, if anything, is blocking you from making progress?

No

6. Any other questions?

Not yet


Stanley Yeo

1. What project are you working on?

Auto-add users to groups

2. What you accomplished this week

  • Implement signal handlers to add newly registered user to global default groups
  • Fix issues in previous RR
  • Write test codes
  • Update RR (soon)

3. Links to anything you’ve done this week
https://reviews.reviewboard.org/r/7165/

4. What you plan to do next week

  • Update RR
  • Write tests
  • Finish previous RRs

5. What, if anything, is blocking you from making progress?

6. Any other questions?


Rohan Meringenti

1. What project are you working on?

Revokable Ship its / Looking for new quick project

2. What you accomplished this week

  • Updating RR soon
  • Written tests
  • Made changes in accordance to reviews

3. Links to anything you’ve done this week

I’ll update the https://reviews.reviewboard.org/r/7170/ today or tomorrow.

4. What you plan to do next week

Pick up a new quick project and start it

5. What, if anything, is blocking you from making progress?

No. Just some tests right now, so i’ll be a day or too late in updating my RR

6. Any other questions?


Jifei Wen

1. What project are you working on?

pep257 && shellcheck

2. What you accomplished this week

fix bug in pep257 && shellcheck

3. Links to anything you’ve done this week

4. What you plan to do next week

there is someting wrong at shellcheck and i will try again

5. What, if anything, is blocking you from making progress?

6. Any other questions?

Jessica Qian

1. What project are you working on?

Trivial reviews

2. What you accomplished this week

Responded to RR for trivial review requests.

3. Links to anything you’ve done this week

https://reviews.reviewboard.org/r/7022/
https://reviews.reviewboard.org/r/7125/
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem

4. What you plan to do next week

Work on fixing a bug where the trivial is True even if emails are turned off.

5. What, if anything, is blocking you from making progress?

None

6. Any other questions?

[Open Academy] Status reports – March 28th, 2015


Sihang Chen

1. What project are you working on?
Add the unreviewed section to the dashboard.
2. What you accomplished this week:
Actually, I’ve been busy preparing some documents for a competition, so I’ve got little time to do the reviewboard thing, and all I’ve done was to try to figure out how to automatically add the two additional columns in the database when building the project automatically.
3. Links to anything you’ve done this week:
No update to my hacked, the links to last week:
https://reviewboard.hackpad.com/Chen-Sihangs-Notes-1t6Ki8onOzy
4. What you plan to do next week:
Next week I’ll have more time and try to work out the database thing.
5. What, if anything, is blocking you from making progress?
I still have the school work to do and another project to work on, but I’ll accomplish what I’m supposed to finish for review board, that’s for sure.
6. Any other questions?
No, if any, I’ll ask on Slack.


Teresa Fan

1. What project are you working on?
Interactive Issue Summaries

2. What you accomplished this week.
Fixed a minor bug where the button divs where rendering in two places (although one was left empty).
Investigated why buttons are disabled when an issue is reopened (see #4).

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/6997/
https://reviewboard.hackpad.com/Teresas-Notes-gI6ljBKu7ra

4. What you plan to do next week.
Still working on the bug where when an issue is reopened after it was dropped/fixed in-table, the button bar doesn’t reappear correctly in the table (they appear disabled).

5. What, if anything, is blocking you from making progress?
The bug mentioned above, but I’ll put a little more time into it before I really say I’m stuck.

6. Any other questions.
I think the problem is that I have 2 separate commentIssueBars, one that I made for the table and the other that was existing for the place in the actual review. How do I get my new bar to “listen” to the other bar so that it properly updates the in-table status to “open” when it’s reopened from outside the table?


Jessica Qian

1. What project are you working on?
“Trivial” publishes

2. What you accomplished this week.
Recorded the demo.
Finished backend for trivial reviews.

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7022/
https://reviews.reviewboard.org/r/7125/
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem

4. What you plan to do next week.
I will work on frontend for trivial reviews.

5. What, if anything, is blocking you from making progress?
None.

6. Any other questions.
None.


Mingyi

1. What project are you working on?
Add infinite scrolling to the diff viewer

2. What you accomplished this week.
Record the video
Push release on the review board.

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7047/
https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY

4. What you plan to do next week.
Waiting for evaluation. And try to make it better.

5. What, if anything, is blocking you from making progress?
No.

6. Any other questions.
Waiting now ~:)


Chenxi

1) What project are you working on?
Changing Review Request Ownership

2) What you accomplished this week.
add all tests.
now correcting code by comments

3) Links to anything you’ve done this week (hackpads, review requests,
blog posts, etc)
My WIP RR for my feature: https://reviews.reviewboard.org/r/6990/
My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP

4) What you plan to do next week.
Finish the project and find another.

5) What, if anything, is blocking you from making progress?
No.

6) Any other questions
Not yet.


Sun Wang Jun

1. What project are you working on?
Checklist extension (integrating templates)

2. What you accomplished this week.
Video demo.
Fixed a bug and improved UI for stuff in current review requests.

3. Links to anything you’ve done week
https://reviewboard.hackpad.com/2015-Checklist-Extension-oLIpxP1SzyX#:h=Integration
https://drive.google.com/file/d/0ByHWCSTdXEMLMkFHUUlWbWxqeWs/view

4. What you plan to do next week.
Most probably re-working the checklist from ground up to support templates

5. What, if anything, is blocking you from making progress?
Contemplating whether to just modify the existing code or to re-design checklists

6. Any other questions.
What are the things we should look out for before pressing Ship It for others’ review requests, assuming we are allowed to do so?


Jifei

1. What project are you working on?

PEP257 ReviewBot tool
2. What you accomplished this week:

PEP257 ReviewBot tool
3. Links to anything you’ve done this week:

https://reviews.reviewboard.org/r/7101/
4. What you plan to do next week:

complete the docstring and perfect the PEP257
5. What, if anything, is blocking you from making progress?

None

6. Any other questions?

i can not find the entry point at `reviewbot.tool`


Rohan Meringenti

1. What project are you working on?
Revokable Ship its

2. What you accomplished this week.
Finished Backend of removable ship its
Working on unit tests

3. Links to anything you’ve done week
Nothing right now, Updating with demo video later today.

4. What you plan to do next week.
Update ship it counter and republish the page after the ship it model changes

5. What, if anything, is blocking you from making progress?
I posted this in #students last night, but I was confused as to what .publish() method does. I need the page to refresh
after the model is loaded. I was looking at how the ship it button worked here,(this calls the publish method), but im not sure how
to replicate the reload.

6. Any other questions.
nope.


xuanyi

1. What project are you working on?
Framework and UI for integrating with third-party services

2. What you accomplished this week.
Added Webapi Resource test
Implemented integration form
Updated Integration class

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/6918/
https://reviews.reviewboard.org/r/7105/
https://reviews.reviewboard.org/r/7106/
https://reviews.reviewboard.org/r/7136/ [WIP]

4. What you plan to do next week.
Continue to work on integration form and config template

5. What, if anything, is blocking you from making progress?
Will be great to have some feedback for my previous RR so that I could improve on it.

6. Any other questions.
Currently, I am trying to make use of the IntegrationForm(a subclass of SiteSettingsForm) to provide the form field for changing the description of an ConfiguredIntegration in the configure page. However, the description field exist as a model field rather than within the json field of the model, so I will need to update them differently. Is there any better way of doing this?


wudi

1. What project are you working on?
Allow replying to reviews from the diffviewer

2. What you accomplished this week:
Haven’t made much progress this week, I was reading up the codebase on how the components talk together to create a review reply.
Got the reviews panel in the comment editor dialog to display the rendered comment and reply hierarchy.
Fixed a bug in my review request after updating with the changes in master.

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/7032/
https://reviewboard.hackpad.com/Wu-Dis-Notes-sULvWjtXN56

4. What you plan to do next week:
I have a rough idea of how to simplify the current UI design based on Christian’s reply, will proceed with it for now and see how it turns out. I’ll try to get a working prototype of the review reply editor by end of the week.

5. What, if anything, is blocking you from making progress?
None.

6. Any other questions?
No.


Viet-Tran Nguyen

1. What project are you working on?
– uncommitted flag and pre-post hook
2. What you accomplished this week?
– just come back from spring break, so minor bugs fix from the above features.
3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/6879/
https://reviews.reviewboard.org/r/7066/

4. What you plan to do next week:
Finishing up the left over comments for these two features and move on to something new.

5. What, if anything, is blocking you from making progress?
None.

6. Any other questions?
No.


Zhiyu

1. What project are you working on?
Add per-user Default reviewer setting.

2. What you accomplished this week:
//Read the code of the api-token function ui and web-api.
Add a simple list (ui) for my new feature.
Try to provide a web api for it.

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/Zhiyus-Notes-WLFl1aHM4fE
It will be updated tomorrow.
The diff which has not uploaded yet will be uploaded to reviewboard after my finishing it in general。

4. What you plan to do next week:
To finish it.

5. What, if anything, is blocking you from making progress?
No

6. Any other questions?
No‍


Stanley Yeo

1. What project are you working on?
Auto-add users to groups

2. What you accomplished this week:
update RRs
understand local_site
understand signal

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/6999/
https://reviewboard.hackpad.com/Stanleys-Note-y91i8NygfSk

4. What you plan to do next week:
Implement signal handlers, and test.

5. What, if anything, is blocking you from making progress?
I’ve been busy due to midterm exams 😦

6. Any other questions?
No

[Open Academy] Status Reports, March 21st


Rohan Meringenti

1. What project are you working on?
Highlighting Active Issues

2. What you accomplished this week:
Finished up front end and made changes as suggested by David for style

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/7008/ Highlighting active issues review request

4. What you plan to do next week:
Work on revokable ship-it labels, have both frontend and backend completed as well as webapi updated

5. What, if anything, is blocking you from making progress?
Nothing

6. Any other questions?
Nope


Sun Wang Jun

1. What project are you working on?
Checklist extension (templates)

2. What you accomplished this week:
Finished up initial part of checklist templates for account pages
Fixed an issue that caused the extension to be hidden after it reloads
Minor code reviews here and there

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/7099/ initial checklist templates implementation
https://reviews.reviewboard.org/r/7103/ review request for extension account page issue

4. What you plan to do next week:
Integrate templates into the existing checklist
Improve on the API related code for the existing checklist

5. What, if anything, is blocking you from making progress?
https://reviews.reviewboard.org/r/6969/ needs reviews so as to facilitate what I plan to do next week

6. Any other questions?
How would extensions use translations?


Zhiyu Xia

1. What project are you working on?
Add per-user Default reviewer setting

2. What you accomplished this week:
Change the setting page of global dafualt reviewers and
Do something about per-user setting

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/Zhiyus-Notes-WLFl1aHM4fE
The diff may be uploaded to reviewboard next week

4. What you plan to do next week:
Finished the per-user setting page about default reviewers.

5. What, if anything, is blocking you from making progress?
to design the per-user setting view.

6. Any other questions?
No


Teresa Fan

1. What project are you working on?
Interactive Issue Summaries

2. What you accomplished this week.
Got the fix/drop buttons in the issue summary table to successfully change the status of issues!

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/6997/
https://reviewboard.hackpad.com/Teresas-Notes-gI6ljBKu7ra

4. What you plan to do next week.
Figure out why when an issue is reopened, the button bar doesn’t reappear correctly in the table.

5. What, if anything, is blocking you from making progress?
Nothing for now, I haven’t gotten the chance to investigate what the reason might be yet.

6. Any other questions.
When creating a CommentIssueBarView, why are the reviewID and commentID fields supposed to be the same? The names are misleading–I had thought the reviewID field should be the actual ID of the review instead of just the same as the comment ID, which was the source of my bug from last week. Or am I mistaken about what the review/comment IDs mean?


Mingyi Chen

1. What project are you working on?
Add infinite scrolling to the diff viewer

2. What you accomplished this week.
Accomplish the infinite scroll and fix all the bugs it appears.
Upload to the rb.

3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7047/
https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY

4. What you plan to do next week.
Learn about the the javascript memory management. And try to reduce the memory usage.

5. What, if anything, is blocking you from making progress?
Current loading framework is not easy to do the memory management.

6. Any other questions.
How to test what I’ve done(infinite scroll) is correct.


Wu Di

1. What project are you working on?
Better Diff Comment Bubbles
I’m currently extending the project to allow replying to reviews from the diffviewer page.

2. What you accomplished this week:
Fixed issues in current review requests.
Did some code reviews.
Came up with specification and mockup for the replying to reviews project

3. Links to anything you’ve done this week:
Mockup and specification: https://reviewboard.hackpad.com/Wu-Dis-Notes-sULvWjtXN56#:h=Allow-replying-to-reviews-from

4. What you plan to do next week:
If there are no problems with the specification, I’ll proceed with this project and get the comment dialog to display the fully rendered reviews properly.

5. What, if anything, is blocking you from making progress?
I picked this project from the Ideas without sufficient definition section of the student project ideas page. Before I proceed, can the mentors have a look to make sure that the specification that I came up with are correct?

6. Any other questions?
None for now.


Chen Sihang

1. What project are you working on?
Add Unreviewed section in the Dashboard.

2. What you accomplished this week.
Accomplish the front-end view part which is to add the two unreviewed section in the dashboard sidebar.

3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Chen-Sihangs-Notes-1t6Ki8onOzy

4. What you plan to do next week.
Continue working on the function of the unreviewed thing.

5. What, if anything, is blocking you from making progress?
Understand the structure of the project.

6. Any other questions.
No.


Jessica Qian

1. What project are you working on?
“Trivial” publishes

2. What you accomplished this week:
I did not do much this week because of midterms.

3. Links to anything you’ve done this week:
https://reviews.reviewboard.org/r/7022
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem

4. What you plan to do next week:
I will make final edits to backend methods for trivial reviews, and start frontend edits.

5. What, if anything, is blocking you from making progress?
​None​


Stanley Yeo

1. What project are you working on?
Add OAuth2 provider support

2. What you accomplished this week:
Updated RRs.
Studied OAuth2.
Researched OAuth2-django libraries.

3. Links to anything you’ve done this week:
https://reviewboard.hackpad.com/Stanleys-Note-y91i8NygfSk
https://reviews.reviewboard.org/r/6999/

4. What you plan to do next week:
Understand studying OAuth
Pick on or two libraries to try with reviewboard
Start Implementing

5. What, if anything, is blocking you from making progress?
None

6. Any other questions?
None


Ni Chenxi

1) What project are you working on?
Changing Review Request Ownership

2) What you accomplished this week.
[WIP] adding tests. I’ve add some tests about the front end and try to add some about backend.

3) Links to anything you’ve done this week (hackpads, review requests,
blog posts, etc)
My WIP RR for my feature: https://reviews.reviewboard.org/r/6990/
My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP

4) What you plan to do next week.
Finish the tests.

5) What, if anything, is blocking you from making progress?
How can I test whether a user that is not the current submitter change the submitter?

6) Any other questions
Not yet.


Lin Xuanyi

1. What project are you working on?
Framework and UI for integrating with third-party services

2. What you accomplished this week:
Iterate on the design for the UI admin page.
Added permissions to both model and admin page.
Integrate the backbone model with the WebApi resource.
Writing test for the webapi resource.
Split the review for part 2.

3. Links to anything you’ve done this week:
Integration model: https://reviews.reviewboard.org/r/6918/
WebApi resource for Integration: https://reviews.reviewboard.org/r/7105/
Integration admin page(Backbone): https://reviews.reviewboard.org/r/7106/

4. What you plan to do next week:
Complete the test for part 2.
Write integration form.

5. What, if anything, is blocking you from making progress?
None.

6. Any other questions?
None.


Chen Feng

1) What project are you working on?
Create a new tool plugin.

2) What you accomplished this week.
Nothing. I am working on a project for our trainning lesson. I’ll continue my work this weekend.

3) Links to anything you’ve done this week (hackpads, review requests, blog posts, etc)
Hackpad notes:
https://reviewboard.hackpad.com/Fengs-Note-lHTmrx16YQd

4) What you plan to do next week.
Fixed the bug.

5) What, if anything, is blocking you from making progress?
Not yet.

[Open Academy] Status Reports March 2-8

Tran Nguyen

1. What project are you working on?
Adding pre_post_hook
2. What you accomplished this week.
Added the pre_post_hook in .reviewboardrc of rbtools with command
“pyflakes .”, and check self.config for the string
rbtools/commands/post.py to see if the string exists. Able to execute
the command using subshell.
STILL making fixed based on mentors’ comments on uncommitted flag.
3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/6879/
4. What you plan to do next week.
Pushed up my initial draft for pre_post_hook.
5. What, if anything, is blocking you from making progress?
So I think for my uncommitted flag, there are some mix comments between
mentors on how I should specify the uncommitted flag option. I think
either way works fine for me, and I find myself going back and forth
editing cosmetic issues. I know it’s for maintenance purposes but it
doesn’t help me learn a whole lot by fixing those issues.
6. Any other questions.
Nope.


Jessica Qian

1. What project are you working on?
‘Trivial’ publishes
2. What you accomplished this week.
I posted my WIP on RR for trivial review requests.
I finished fixing backend methods for trivial reviews.
3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Jessicas-Hackpad-LOYsF3tQwem
https://reviews.reviewboard.org/r/7022/
4. What you plan to do next week.
I am currently stuck on sending the value of “trivial” from the checkbox to the update method for trivial review requests, so I will work on that.
5. What, if anything, is blocking you from making progress?
A lot of operations happens when you click the Publish button. I’ve been trying to understand how I can pass the trivial parameter for a couple weeks now, but it’s very complicated…
6. Any other questions.
None


Xuanyi Lin

1. What project are you working on?
Framework and UI for integrating with third-party services
2. What you accomplished this week.
Learn about Backbone
Implemented the basic structure for integrations admin page.
3. Links to anything you’ve done week
Part 1: https://reviews.reviewboard.org/r/6918/
[WIP] Part 2 integrations admin page: https://reviews.reviewboard.org/r/7034/
https://reviewboard.hackpad.com/Xuanyis-notes-R9JtPE1o279
4. What you plan to do next week.
Implement the views for managing all integrations and individual configured integrations.
5. What, if anything, is blocking you from making progress?
Nothing.
6. Any other questions.
Nope.


Wu Di

1. What project are you working on?
Better Diff Comment Bubbles
2. What you accomplished this week.
Studied Stanley’s project on making the image comments movable and resizable, currently still attempting to get the diff bubbles to be resizable.
Added css vulnerabilities testing to part 1 of the project.
Updated part 2 of the project based on Barret’s comments on hover behaviour.
3. Links to anything you’ve done week
Part 1: https://reviews.reviewboard.org/r/6932/
Part 2: https://reviews.reviewboard.org/r/6970/
Part 3 [WIP]: https://reviews.reviewboard.org/r/7032/
4. What you plan to do next week.
Continue working on the resizing of the diff comment bubbles.
5. What, if anything, is blocking you from making progress?
Nothing.
6. Any other questions.
Currently i’m modifying the textBasedCommentBlockView to handle the mousedown and mouseup events in order to perform the resizing, I’m able to detect the new $beginRow and $endRow but I’m not sure of how to get the view to update them.


Rohan Meringenti

1. What project are you working on?
Highlight Active Issues
2. What you accomplished this week.
Got the backend working properly, which is modeled in the front end as well!
3. Links to anything you’ve done week
https://reviews.reviewboard.org/r/7008/
4. What you plan to do next week.
Make the front end changes pretty, so user’s have an easier time noticing changes
5. What, if anything, is blocking you from making progress?
Nothing for now, I’ll be done with this project this week most likely, so I’ll likely start tackling something new.
6. Any other questions.
nope.


Teresa Fan

1. What project are you working on?
Interactive Issue Summaries
2. What you accomplished this week.
Got the fix/drop buttons to display properly!
3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Teresas-Notes-gI6ljBKu7ra
https://reviews.reviewboard.org/r/6997/
4. What you plan to do next week.
Get the buttons to actually work, I haven’t properly hooked them up with the commentManagerModel.
5. What, if anything, is blocking you from making progress?
Nothing for now, although if anyone has time to look over my review request and give me feedback on what I have so far, that’d be great (I just want to make sure I’m going in the right direction and don’t waste more time on something that I should actually be going about a different way).
6. Any other questions.
I second Stanley’s question, I also have spring break this week so I wasn’t sure if I still have to work or not (I might still work a little anyway, but perhaps not devote as much time as usual).


Sun Wang Jun

1. What project are you working on?
Checklist extension
2. What you accomplished this week.
Submitted first part of project for review, and updated the review after comments
3. Links to anything you’ve done week
https://reviewboard.hackpad.com/2015-Checklist-Extension-oLIpxP1SzyX
https://reviews.reviewboard.org/r/6969
4. What you plan to do next week.
Split current review request into two
Begin work on templates
5. What, if anything, is blocking you from making progress?
Nothing
6. Any other questions
Nope


Chenxi Ni

1) What project are you working on?
Changing Review Request Ownership
2) What you accomplished this week.
Fix the bug I encounted when echo the ‘submitter’ on the UI
Add submitter information when the information in a ReviewRequestDraft is dumped into the ReviewRequest model
Make changed field shows correctly after publish.
3) Links to anything you’ve done this week (hackpads, review requests, blog posts, etc)
My WIP RR for my feature: https://reviews.reviewboard.org/r/6990/
My hackpad:https://reviewboard.hackpad.com/Chenxis-Notes-hRtQP9sWSrP
4) What you plan to do next week.
Add tests and maybe fix some details of my project.
5) What, if anything, is blocking you from making progress?
Not yet.
6) Any other questions
I have accomplish the main functions of my project(That is, I can modify submitter now). I guess there some more I should do.
1.Should I add some notifications to users before they publish with different submitter?
2.What kind of tests should I add?


Stanley Yeo

1. What project are you working on?
Improve Review Bot’s admin interface
2. What you accomplished this week.
Updated RRs
Wrote comments
3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Stanleys-Note-y91i8NygfSk
https://reviews.reviewboard.org/r/6999/
4. What you plan to do next week.
Fix bugs, if nay.
Update RRs, based on feedback.
5. What, if anything, is blocking you from making progress?
anselina and smacleod seemed pretty busy this week. So, I couldn’t get any feedback/review for my RR.
6. Any other questions.
Wonder what to do while waiting for review.
CMU has spring break this week, and I wonder if I can skip working this week.


Mingyi Chen

1. What project are you working on?
Add infinite scrolling to the diff viewer
2. What you accomplished this week.
Infinite Scrolling but have sth wrong
3. Links to anything you’ve done week
https://reviewboard.hackpad.com/Mingyis-Notes-gvT8udhK8GY
4. What you plan to do next week.
Fix the bugs. Add post it!
5. What, if anything, is blocking you from making progress?
Is it better to get the diff data once or several times from pages.
6. Any other questions.
N/A

The relationship between ReviewRequest and ReviewRequestDraft

Despite having worked on various parts of Review Board for several years, the distinction between a ReviewRequest and ReviewRequestDraft has often been a bit blurry for me. I’ve had the occasion recently to explore the relationship between these two models, and I wanted to write it down for future code-spelunkers.

The way I want to explain this is by exploring the lifetime of a ReviewRequest, from cradle to grave. So, let’s get started.

When a ReviewRequest is first created, it has barely information in any of its fields, and the public attribute is set to false. When the user starts making modifications to a Review Request though, a Review Request Draft is then created. The changes that the user makes after creating the initial Review Request actually update the Review Request Draft instead. Even if the Description and Testing Done fields have been populated, that information is not in the ReviewRequest: all fields are set on the ReviewRequestDraft.

When the user clicks “Publish” on a review request page, the information in a ReviewRequestDraft is dumped into the ReviewRequest model. The ReviewRequestDraft model is deleted, and the state on the ReviewRequest is set to public. Congratulations, your review request is now visible!

Suppose now you want to make a change to a review request. Perhaps you’ve updated the Testing Done field, or you’re adding a new reviewer to it, or you’re changing the summary. What happens is that a new ReviewRequestDraft is created for the ReviewRequest, with a copy of all of the current fields in the ReviewRequest, and any changes you make go into that ReviewRequestDraft.

So when you, or anybody who has mutation-privledges for a ReviewRequest sees the review request page, and a ReviewRequestDraft exists, you see the information in the ReviewRequestDraft. For anybody without mutation-privledges looking at the page, they see the unchanged ReviewRequest data.

When it comes time to publish the draft, the changes in the ReviewRequestDraft get, again, dumped into the ReviewRequest (a ChangeDescription is also created in order to document the changes being made to the ReviewRequest) and the ReviewRequestDraft is destroyed.

When a ReviewRequest is marked submitted or discarded, that state change occurs on the ReviewRequest, and ReviewRequestDraft does not need to be created.

So that’s how changes occur on ReviewRequests.

[UCOSP] Status Report For Week Feb 9 – Feb 15


Jessica Yuen

1. What project are you working on?

– rb-gateway

2. What you accomplished this week:

– Added test cases for checking whether ReviewBoardGateway hosting service subclass can find the repository on rb-gateway, whether authorization sends the expected data, for checking service support capabilities, and checking repository field values.

– Added get_file and get_file_exists implementations to hosting service subclass.

– Added APIs to rb-gateway for getting file blob and checking file existence based on commit id, file path pairing. 

– Made demo video to demonstrate rb-gateway

3. Links to anything you’ve done this week:

https://reviews.reviewboard.org/r/6831/

https://reviews.reviewboard.org/r/6850/

4. What you plan to do next week:

– clean up rb-gateway a bit and hopefully get initial patch submitted

– clean up my Hackpad

– Either add Hg support, or add more APIs to rb-gateway to support more advanced functionalities that RB needs (I don’t know which yet – I want to talk to a mentor about this)

5. What, if anything, is blocking you from making progress?

– Nothing

6. Any other questions?

– Nope!

Tien Vu

1) What project are you working on?

 Diff Doctor

2) What you accomplished this week?

– A lot of investigating code. Stepped through most of the stack to display a diff (reviewboard/diffviewer)

– Read Django docs about models and databases to make sense of the DiffSet and FileDiff models

– Rewrote some of the template code for Jinja2

– Made demo video

 

3) Links to anything you’ve done this week

 

https://reviews.reviewboard.org/r/6833/

https://reviewboard.hackpad.com/Tien-Feb-8-o3XQYinbxcc

 

4) What you plan to do next week

Look for specific cases where APIs to return original files fail (therefore failing the patch). I’ll decide what to do from there, as of right now I’m still not 100% clear of my tasks ahead. I might take a look at the diff validator code as well.

 

5) Any blockers for your project?

Not really. 

 

6) Other questions?

No.

Vincent Le

1) What project are you working on?

    – File provider framework

2) What you accomplished this week.

    – Made test cases for reviewboard/fileproviders

    – Redid the file_provider_file to use get_list and get_item, had to take a look into url regex

    – Learned that Django or some component of the framework decodes url automatically, i.e. %7E into ~

    – Addressed most of the issues addressed by Barret and Christian

    – Filmed my demo video

3) Links to anything you’ve done this week:

    – FileProvider module: https://reviews.reviewboard.org/r/6806/

    – FileProvider webapi: https://reviews.reviewboard.org/r/6948/

    – My hackpad: https://reviewboard.hackpad.com/Vincents-File-Upload-Log-sh2QycRO45Z

    – My demo video: https://www.dropbox.com/s/relu15xppvykcjj/VID_20150213_223907.mp4?dl=0

4) What you plan to do next week.

    – Address to issues raised by Barret and Christian

    – move any neccessary parts to get_queryset for both webapi

    – clean up file_provider_file.py

    – get the file upload integrated into file_attachments.py

5) What, if anything, is blocking you from making progress?

    – None yet

6) Any other questions

    – None yet

Chester Li

1) What project are you working on?

  • The post-commit review request support with GitLab

2) What you accomplished this week?

  • Read and built up better understanding on GitLab API
  • Changed some functions in GitLabClient class.
  • Finished unit test for review 6787

3) Links to anything you’ve done this week

4) What you plan to do next week

  • Finish the rest of functions in GitLab and GitLabClient classes.

5) Any blockers for your project?

  • The GitLab API document.
  • The poor internet connection in my current area.

6) Other questions?

  • Nope


Christopher Arnold

1. What project are you working on?

Mute and Archive Review Requests

2. What you accomplished this week.

  • midterm demo!
  • scrapped review_request_visit API and decided on two separate archived_request_visit and muted_request_visit APIs to prevent visits from being exposed
  • added archive/unarchive/mute/unmute functions in reviewRequestVisit model
  • began archive banner
  • webAPI url for archived review requests

3. Links to anything you’ve done week:

Hackpad: https://reviewboard.hackpad.com/Chriss-Notes-aOjnNWbg014

Review Request: https://reviews.reviewboard.org/r/6830/

4. What you plan to do next week.

  • make full connection between button click to database change for archiving and unarchiving
  • complete banner
  • write some tests

5. What, if anything, is blocking you from making progress?

  • getting a 405 error when I make a POST request in my archived_review_request.py, what might be wrong?

6. Any other questions.

  • so far, I’ve went in a couple of wrong directions and had to backtrack a bit. I’d really like it if someone could look at what I’ve done this week to tell me if I’m on the right track and any pointers I should keep in mind going forward
  • when would we want to use `user = resources.user.get_object(request, *args, **kwargs)` as opposed to `user = request.user`?
  • what’s the best way to test webAPI?
  • what does the @property decorator do?

Jason Tseng

1) What project are you working on?

Responsive UI

2) What you accomplished this week?

  • Demo
  • Some advancement on the progress with admin/user page
  • posting design discussions on google dev discussion board

3) Links to anything you’ve done this week

4) What you plan to do next week

  • wrap up admin/user page
  • revisit previous feedbacks

5) Any blockers for your project?

  • Been testing with adding responsive ui for tabs under user’s page, but having issues displaying properly under smaller screen width. In current best attempt, under certain width, the first tab would stuck with two lines while the second and third using only one line, causing different height between the three and thus unaligned display of buttons.

6) Other questions?

n/a

Theo Belaire

1) What project are you working on?

RB Tools, better parent_base

2) What you accomplished this week?

  • Demo
  • I’m ready to land, I feel, at least the first part.

3) Links to anything you’ve done this week

4) What you plan to do next week

  • Populate the Branch field if possible.
  • I’m planning on showing up for office hours and asking a lot of questions, since I’m feeling a bit lost.

5) Any blockers for your project?

  • I would like more feedback about my patch, and I don’t feel super comfortable with `upstream_branch` and how I interact with it.

6) Other questions?

N/A