Author Archives: JasonT

[UCOSP] Status Report Mar 28

Leave a reply

Vincent Le

1) What project are you working on?

    – FileProvider framework

2) What you accomplished this week.

    – Made changes as suggested by reviews

    – Added a `api/file-providers/` end-point to make API calls to know what file providers are supported

    – Added backbone.js model for file-providers from api calls to `api/file-providers/`. Integrated with the upload modal to use information needed for progression

    – Re-did the design for display of metadata, moving logic to files where needed and display path only for search results.

    – Added search logic to show search results on the options for selection. Search result is displayed after 500ms after the last key up in the search field, or display the current path when search field is white space

    – more variable refactoring as names were missed

    – made some reviews

3) Links to anything you’ve done this week:

    – FileProvider WebApi interaction with file provider account: https://reviews.reviewboard.org/r/6948/

    – [WIP] FileProvider Modal UI for uploads: https://reviews.reviewboard.org/r/7009/

    – FileProvider resource web API for providers: https://reviews.reviewboard.org/r/7124/

    – Reviews: https://reviews.reviewboard.org/users/VTL-Developer/reviews/

4) What you plan to do next week.

    – Clean up and finish r/7009 (test cases, making changes as response to reviews, etc.)

    – Demo Video

5) What, if anything, is blocking you from making progress?

    – N/A

6) Any other questions

    – N/A

Tien Vu

1. What project are you working on?

Diff Doctor

2. What you accomplished this week.

– Not sure what else to do for my 2 projects, so I went around for code reviews and bug fixing instead

3. Links to anything you’ve done:

– https://reviews.reviewboard.org/r/6833/

– https://reviews.reviewboard.org/r/6993/

Code reviews:

– https://reviews.reviewboard.org/r/6879/

– https://reviews.reviewboard.org/r/7066/

Learned about git hooks: http://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks

and fixed the bug at https://code.google.com/p/reviewboard/issues/detail?id=3824. Review request link:

– https://reviews.reviewboard.org/r/7129/

4. What you plan to do next week.

– I need some direction here. What should I do?

5. What, if anything, is blocking you from making progress?

– What should I do if patching fails to something outside the patch() function (that throws a PatchError)? Like an SCMError.

– What else do I have to do to land my projects?

No luck with reproducing these bugs:

– https://code.google.com/p/reviewboard/issues/detail?id=3108

– https://code.google.com/p/reviewboard/issues/detail?id=3421

– https://code.google.com/p/reviewboard/issues/detail?id=3687

6. Any other questions.

– No

Jessica Yuen

1. What project are you working on?

  • rb-gateway

2. What you accomplished this week.

  • Unit testing for all rb-gateway API’s, testing:
    • /repos/{repo}/file{id}, GET, HEAD
    • /repos/{repo}/commits/{id}/path/{path}, GET, HEAD
    • /repos/{repo}/path, GET
    • /repos/{repo}/branches, GET
    • /repos/{repo}/branches/{name}/commits, GET
    • /repos/{repo}/commits/{id}, GET
    • /session, GET
  • Minor fix to return 30 commits vs 20, to align with GitHub API, landed.
  • Addressed issues with 7053, landed

3. Links to anything you’ve done week:

4. What you plan to do next week.

  • Demo video
  • Reviews
  • Address any reviews on outstanding review request, 7134, get it landed.

5. What, if anything, is blocking you from making progress?

  • N/A

6. Any other questions.

  • Nope


Chester Li

1) What project are you working on?

  • Bug fixing and code reviewing

2) What you accomplished this week.

  • Landed the main project.
  • Reviewed code changes.
  • [WIP] bug fixing.

3) Links to anything you’ve done this week:

4) What you plan to do next week.

  • Recorded the demo and hopefully fixed issue 3811

5) What, if anything, is blocking you from making progress?

  • Was overwhelmed by other projects and homework

6) Any other questions

  • N / A


Christopher Arnold

1) What project are you working on?

  • Mute and Archive Review Requests

2) What you accomplished this week.

  • split up project into smaller review requests
  • finished automatic unarchiving
  • fixed URL query
  • finished ReviewRequestVisitTests in accounts.models
  • finished test_show_archived in datagrids.grids
  • wrote most of test_archived_review_request for the webapi
  • wrote most of reviewRequestEditorViewTests in static.rb.js.views

3) Links to anything you’ve done this week:

4) What you plan to do next week.

  • fix the last two tests mentioned above
  • video demo
  • polish documentation
  • do some reviews

5) What, if anything, is blocking you from making progress?

  • test_archived_review_request for the webapi: https://reviews.reviewboard.org/r/7087/diff/7/#6
    • I’m getting the same error for 3 of the DELETE tests: AssertionError: u’A’ != u’V’
    • When I print the visibility in the actual delete function, it is as expected (‘V’), but for some reason doesn’t show up like that in the test
  • I actually break 4 of the original tests (all similar) with my patch, can’t figure out how to fix my code
    • error is with setStarred: Expected spy success to have been called
      • on lines 46 and 65 of reviewGroupModelTests
      • and on lines 167 and 187 of reviewRequestModelTests
    • I think it has to do with how I implement addImmediately and removeImmediately when adding the trigger.

6) Any other questions

  • How complete is my project looking? Any more tests I should do?
  • Super stuck for a while now on the things I mentioned above, so I would appreciate any help 🙂 Thank you!


Jason Tseng

1. What project are you working on?

Responsive UI

2. What you accomplished this week.

– Updates on part 1 and rebased through the rest

– secondary menu button design

3. Links to anything you’ve done week:

– https://reviews.reviewboard.org/r/6796

– https://reviews.reviewboard.org/r/6923/

4. What you plan to do next week.

– Demo

– Minor bug fixes

5. What, if anything, is blocking you from making progress?

– n/a

6. Any other questions.

– Nope.

[UCOSP] Status Reports: Feb 07, 2015

Leave a reply


Theo Blaire
1) What project are you working on?
• rbtools, better parent-base

2) What you accomplished this week?
• Got sick.
• Fixed this, and remembered to publish my diff this time.
• Editor exiting with non-zero status aborting

3) Links to anything you’ve done this week
• https://reviews.reviewboard.org/r/6797/
• https://reviews.reviewboard.org/r/6843/

4) What you plan to do next week
• Think of a way to demo nicely, pass midterms, finish that editor patch.

5) Any blockers for your project?
• I have no idea how to properly test that editor thing. It pops up with rbt merge, but I don’t know how to use that.


Jessica Yuen
1) What project are you working on?
• rb-gateway

2) What you accomplished this week?
• Implemented Basic Auth for rb-gateway
• Adding Port to config file for rb-gateway
• Added authorization and fixed the form on the Review Board Gateway hosting service side
• Hooked up rb-gateway to Review Board (i.e. you can add an rb-gateway repository now and rbt post to it)

3) Links to anything you’ve done this week
• https://reviews.reviewboard.org/r/6831/
• https://reviews.reviewboard.org/r/6850/

4) What you plan to do next week
• Implement test cases for the hosting service
• Implement get_file and get_file_exists on the hosting service side
• Make the video for the ucosp student demo due soon
• More rb-gateway work if time allows

5) Any blockers for your project?
• No, just midterm season soon so will be busier.

6) Other questions?
• Can I get a review of my WIPs?


Christopher Arnold
1) What project are you working on?
• Mute and Archive Review Requests

2) What you accomplished this week.
• revised how the archive query filters the query set
• uses ._query rather than another method that passes an extra_query
• learning more about templates
made plans to add button to the review detail template

3) Links to anything you’ve done this week:
• hackpad: https://reviewboard.hackpad.com/Chriss-Notes-aOjnNWbg014
• review request: https://reviews.reviewboard.org/r/6830/

4) What you plan to do next week.
• add the button that toggles visibility
• finish fixing filtering archived query

5) What, if anything, is blocking you from making progress?
• would like feedback on my review request: https://reviews.reviewboard.org/r/6830/

6) Any other questions
• none right now


Tien Vu
1) What project are you working on?
• Was working on generating auto-commit messages based on Jinja2 templates, now investigating “Diff Doctor”

2) What you accomplished this week?
• Read up PEP8, might take some actual coding to remember all the conventions.
• Cleaned up code for templates.
• Made some draft “unit tests” that needs feedback.
• Managed to reproduce the “Broken Diff” bug.
• Understand and getting more comfortable with diffs and patches (formats of diffs and how the linux commands -diff and -patch work).

3) Links to anything you’ve done this week
• https://reviews.reviewboard.org/r/6833/
• https://reviews.reviewboard.org/r/6906/
• random notes: https://reviewboard.hackpad.com/Tien-Feb-2-7vacG0AzY7F

4) What you plan to do next week
• I’m not sure about this, because I’m flying to Vietnam for a 5 day “vacation”. I haven’t been back for a long time and probably won’t be for another while, so I intend to spend my time here with friends and relatives. However, I’m planning to do these next:
• Clean up templates/unit tests
• Investigate the Diff Doctor further. I know that there needs to be adequate error handling for the server side command “patch -o “, and this needs to be on the webUI. I need to figure out where the diffs are coming from and sources of broken diffs that occur “naturally” (when I reproduced the bug, I played with the diff file, normally this doesn’t happen).
• Then I want to talk to a mentor to further divide up my work into pieces for the rest of the semester.

5) Any blockers for your project?
• Sort of, I need feedback on my 2 review requests.

6) Other questions?
• Not for now.


Vincent Le
1) What project are you working on?
• Working on the “File Provider framework”

2) What you accomplished this week?
• Worked on search, list and meta for test derived objects
• Worked on the test cases for those
• Worked on the docstring for file_provider webapi
• Was messing around with uploading and saving images on the server

3) Links to anything you’ve done this week
• My WIP progress for the backend: https://reviews.reviewboard.org/r/6806/
• My hack pad: https://reviewboard.hackpad.com/Vincents-File-Upload-Log-sh2QycRO45Z
• Code review for : https://reviews.reviewboard.org/r/6830/
• Code review for : https://reviews.reviewboard.org/r/6833/
• Image of changes I did for when I was messing around: https://reviewboard.hackpad.com/Extra-Log-for-Vinces-Reports-38dBJnwv9IW

4) What you plan to do next week
• Add test cases for uploading files
• Finish uploading files POST request
• Add test cases for `reviewboard/fileproviders/test.py` for the functions found in `./fileprovider.py`
• Add documentation for `file_provider_content`

5) Any blockers for your project?
• Not yet

6) Other questions?
• When I make changes and post to ReviewBoard. I get these errors for `reviewboard/settings.py` (from ReviewBot) with changes I haven’t made. Should I drop them or mark them as fixed?
• Is there any difference between dropping them and marking them as fixed?


Chester Li
1. What project are you working on?
• I am working on issue 3704 (WIP) and post-commit review requests for GitLab.

2. What you accomplished this week.
• Modified api_get_commits(), but not 100% completed because I am not too sure I fully understand GitLab API
• maybe need to change number parameter, possibly remove ‘start’
• need to test the url format
• Implemented api_get_tree(), same progress as the api_get_commits().
• Implemented api_get_heads(), same progress as the api_get_commits().
• Implemented _build_api_url().
• Implemented _check_api_errors().
• Got better understanding on GitLab API.

3. Links to anything you’ve done week:
• https://reviews.reviewboard.org/r/6782/
• https://reviewboard.hackpad.com/Chesters-Code-Sprint-Logs-Keep-updating-t6UxLoMfjmD

4. What you plan to do next week.
• Keep working on that GitLab project, harder.

5. What, if anything, is blocking you from making progress?
• The ambiguous GitLab API document and it is a little bit hard to seek for online help with the specific GitLab topic.

6. Any other questions.
• One technic question:
• In GitLab class, when we call self.client.http_get(), are we calling the function from HostingService from service.py or GitHubClient in the same file? Because in GitLab class, we are calling http_get() function from HostingService, but if so, what is the purpose of http_get() in GitHubClient / GitLabClient classes and how to call this function?

Jason Tseng
1) What project are you working on?
• Responsive UI
2) What you accomplished this week?
• Split previous review request into smaller chunks
• WIP – admin & user page
3) Links to anything you’ve done this week
• https://reviews.reviewboard.org/r/6796
• https://reviews.reviewboard.org/r/6922/
• https://reviews.reviewboard.org/r/6923/
• https://reviews.reviewboard.org/r/6893/
• https://reviewboard.hackpad.com/Jasons-Pad-k2QPr3KBxDc

4) What you plan to do next week
• Gather input on UI design and finish admin/user page

5) Any blockers for your project?
• N/A

6) Other questions?
• N/A