Author Archives: Yazan Medanat

Status Reports for March 31st, 2012

Leave a reply

Yazan Medanat

Status:
Next Steps:
  • Finish incremental expansion of diffs (after block is resolved)
  • Update r2964 based on feedback
Road Blocks:

Dave Druska

Status:
  • Iterated reviews, need feedback on 2991 (look at my reply to Christian)
  • Sent out a bunch of reviews
Next Steps:
  • Finish my 2 things, tackle some bugs next
Road Blocks:
  • None

Steven MacLeod

Status:
Next Steps:
  • Finish extension documentation
  • Finish WebAPI updates
  • Try and get ReviewBot to a usable state (no more hard-coding etc.)
Road Blocks:

Jim

Status:
Next Steps:
  • Kepp building out the github-like diff rendering
Road Blocks:

Anthony Mok

Status:
  • Addressed the concerns in the review for the mimetype handler
Next Steps:
  • Work on feedback for the mimetype handler
  • Figure out how to only use handlers from enabled extensions.
Road Blocks:
  • None

Curtis Muller

Status:
  • N/A
Next Steps:
  • N/A
Road Blocks:
  • N/A

Willer

Status:
  • Fixed a few issue and thought more about the weekly headlines project
  • Being busy last week too
Next Steps:
  • Finish and close the two projects with whatever they cost
Road Blocks:
  • Have an presentation assignment this afternoon, so not sure if can attend the meeting on time or not.

Wilson Yeung

Status:
  • Using a new wireframe software (invisionapp.com )
Next Steps:
  • complete wireframe
  • finish 2282 bug
Road Blocks:
  • None

Out of Sync Commits

1 Reply

Sometimes, when doing a post-review, other people’s commits show up in your diff, this is due to out-of-sync branches.

This is a common issue but the fix is fairly simple.

From the terminal inside your review board root directory, type the following commands: 

$ git checkout master
$ git fetch origin
$ git fetch origin master
$ git pull origin master
$ git checkout "feature branch"
$ git merge master
$ post-review -r "review id"

 
Where “feature branch” is the name of your out-of-sync branch, and “review id” is the id of your posted review.

That’s it, your branches should now be in-sync.

Yazan Medanat

Meeting Minutes for March 17th, 2012

Leave a reply

Reminders:

  • We have 3 more meetings before wrapping up, depending on the size/scope of your project, you may want to reserve the last week to polish and document your project
  • If you don’t think you’re going to be able to finish your projects, it’s critical that you inform one of the mentors
  • Status reports should posted at least one hour before the meeting, so please send them ASAP

Anthony

  • Framework should be able to handle additional mimetypes through extensions
  • Thumbnails will be rendered as HTML allowing the author to decide on the looks
  • Generate a new comment class for full-file review comments

Steven

  • Requested reviews on extension documentation
  • ReviewBot next top priority

Jim

  • Requested review on r2966
  • Will be knocking off bugs till the end of the semester or picking up one of Christian’s suggested projects

Yazan

  • Static media should be placed in “/reviewboard/static”, htdocs is off-limits now
  • Need to attach “–tracking-branch=origin/master” flag to post-review github branch
  • Use imgur.com to post screenshots, get an account to group images

Dave

  • Waiting on review request for r2918
  • Next project is possibly “better binary files”
  • Possibly select one of the projects suggested by Christian along with jimrrchen

Curtis

  • Having trouble placing “select_related()” within the code
  • “review_request = review_request.select_related(‘diffset_history__diffsets’)” is the gist of the idea,  Christian will provide code in the review

Wilson

  • Merge conflict occurred, instructed on how to resolve it
  • Some files may have changed locations and may need to re-apply changes
  • Mockup “new submitters page” using wireframe to a layout similar to the dashboard’s

Willer

  • Requirements for “weekly headlines project” are not clear, approach explained here: ” groups.google.com/group/reviewboard-dev/browse_frm/thread/7efca0ae1e6173fc”
  • Had trouble running unit tests, will contact dev mailing list for support

Christian’s suggested projects:

  • “if you select text in, say, the description box, it opens, which it shouldn’t do”
  • “if you have the box open, and yo udidn’t modify it, you’ll still be asked if you’re sure you want to leave the page, which is painful when trying to close a review request”
  • “when someone closes a review request, the update bubble that appears later is that the review request is “updated.” It should be smarter and say it was closed”

Status Reports for March 10th, 2012

Leave a reply

Yazan Medanat

Status:
  • Updated environment
  • Working on summary table/incremental expansion
Next Steps:
  • post-review work
Road Blocks:
  • None

Dave Druska

Status:
  • Submitted patch for client-side capabilities
  • Submitted patches for bugs caused by the timezone merge
Next Steps:
  • Complete capabilities
Road Blocks:
  • None

Steven MacLeod

Status:
Next Steps:
  • Finish Documentation.
Road Blocks:
  • None.

Jim

Status:
  • Just finished a crazily-working, sleep-deprived week, finally some free time
  • Template tags are still not working for me. Really not sure why. Going to read the Django doc
Next Steps:
  • Continues working on description rendering
Road Blocks:
  • None

Anthony Mok

Status:
  • Unfortunately, I’ve been busy this week too, but that is going to end early next week.
Next Steps:
  • Get these school projects out of the way
  • Work on full-file review
Road Blocks:
  • None

Curtis Muller

Status:
  • Read about select_related(), and trying to implement it.
Next Steps:
  • Resolve the last issue on r2810
  • Continue working on rating-extension
Road Blocks:
  • Could use a comment on my comment on the open issue in r2810.
  • I had to come into work today, so I will do my best to be attentive during the meeting.

Willer

Status:
  • Followed up with comments on r2891; added “multiple draft owned by
  • separate users” support
Next Steps:
  • Unit test r2891
Road Blocks:
  • A small question about admin command

Wilson Yeung

Status:
  • Out of town this weekend
Next Steps:
  • N/A
Road Blocks:
  • N/A

Yazan: Winter 2011-2012 Plans

Leave a reply

What was accomplished:

  • r2808: Add a collapse all button to reviews
  • r2816: Maximize issue summary width
  • Assist new students during sprint

What I plan on doing:

  • Fix the counters found on the dashboard
  • Add a javascript observer to auto-update dashboard counters without a need for a refresh
  • Introduce localization for javascript strings using babel or javascript_catalog
  • Enhance the visuals on the issue summary table
  • Add buttons to the issue summary table
  • Add “required” flags to review fields
  • Help mentors with tasks
  • Provide students with help and provide code reviews throughout the term

More ideas:

  • Add “types” to reviews (e.g.: bug fix/feature/enhancement/maintenance)
  • Add testing templates that speed up filling out the testing done field in a review as an extension

If  any compelling features or bug fixes are required or come up, they can supersede my project choices.

IRC Who’s Who Guide (UCOSP Winter 2011-2012)

Leave a reply

UCOSP Mentors:

  • ChipX86: Christian Hammond
  • purple_cow: David Trowbridge
  • m_conley: Mike Conley

UCOSP Students:

  • happyface: Dave Druska
  • medanat: Yazan Medanat
  • smacleod: Steven MacLeod
  • jimrrchen: Ruirong Chen (aka Jim)
  • ammok: Anthony Mok
  • CurtisM: Curtis Muller
  • weilul: Wei Lu Liu (aka Willer)
  • H20_: Wilson Yeung

Cool Guys (non-UCOSP Winter 2011-2012):

  • mbait
  • matthiaskrgr
  • vladikoff

Bots:

  • CIA-71: cia.vc bot

Status Reports for December 4th, 2011

Leave a reply

Dave

Status:
  • Almost completed time zone and UTC feature and posted two reviews. One for RB and one for Djblets.
  • Iterated feature with review feedback
Next Steps:
  • Complete feature
  • Testing
Road Blocks:
  • None

Yazan

Status:
  • Enhanced summary timetable submitted
  • Refactoring auto-update by registering callback
Next Steps:
  • Refactoring auto-update by registering callback
  • Discuss/implement “toggle issue/comment” check-box
Road Blocks:
  • None

Jacob

Status:
  • Continuing working on the WebAPI
Next Steps:
  • Test and post changes
Road Blocks:
  • None

Minutes for the 20th of November, 2011

Leave a reply

Attendees

  • Mentors: Mike, David,  and Christian
  • Students: Jacob, Dave, and Yazan

Points

  • Everyone seems to be doing well this week
  • Jacob asked how do requests map to the classes/actions in resources
  • Jacob was pointed to the documentation in djblets/webapi/resource.py
  • Dave asked about middleware
  • David pointed him to https://docs.djangoproject.com/en/1.3/topics/http/middleware/
  • Jacob is waiting on a review for r2651
  • Jacob was advised to use a different field to sore uploaded file attachments
  • Meeting ran short, not much to discuss
  • Next week will be Thanksgiving in the states, so some mentors may not be available at all times

Links

  • Middleware: https://docs.djangoproject.com/en/1.3/topics/http/middleware/

Minutes for the 13th of November, 2011

Leave a reply

Attendees

  • Mentors: Mike, David,  and Christian
  • Students: Jacob, Dave, and Yazan
Points
  • reviews.reviewboard.org was relocated to Amazon EC2, contributors should hold off posting reviews until the DNS registries are updated
  • Dave had trouble with django evolution when trying to add a new timezone field to a table
  • Changing the field type and the parameter order fixed Dave’s problem
  • Yazan had trouble starting the devserver due to missing database entires
  • Removal of the database folders and rerunning ./reviewboard/manage.py fixed the problem for Yazan
  • Script commands should always be run from the root directory
  • Jacob was waiting on reviews.reviewboard.org to come back up, and it’s back up now
  • Dave discussed various approaches on deciding what timezone to store
  • Christian suggested a method that will get the local time zone of the user
  • Jacob asked about the server side API, it can be found under reviewboard/webapi/resources.py
  • Vladikoff’s  new admin UI improvements impressed everyone

Status Report for November 13th, 2011

Leave a reply

Dave

Status:
  • Created TimeZoneField model & form fields in Djblets
  • Added a timezone field to the profile model and in the user settings page
  • Changed admin ui timezone form to use TimeZoneField
  • Researched pytz and found best way to convert timezones
Next Steps:
  • Implement timezone conversion for outputted timezones
Road Blocks:
  • django-evolution issues

Yazan

Status:
  • Fresh install of rb/djblets/rbtools
  • Old CSS converted to lesscss, waiting on dev-server to work to test it
  • Started implementing new features of review summary box
Next Steps:
  • Post review summary box feature using lesscss
  • Start new feature
Road Blocks:
  • Can’t start dev server: reviewboard.db is empty, size: zero kb

Jacob

Status:
  • Looking at post-review client/server code
Next Steps:
  • Start adding code to enable Git binary attachment upload
Blocks:
  • Reviewboard review site appears to be down?